Unverified Commit 9ea39dc3 authored by crimsoncor's avatar crimsoncor Committed by GitHub
Browse files

Force the builtin module key to be the correct type. (#2814)



* Force the builtin module key to be the correct type.

Previously it was always going to be a std::string which converted into
unicode. Python 2 appears to want module keys to be normal str types, so
this was breaking code that expected plain string types in the
builtins.keys() data structure

* Add a simple unit test to ensure all built-in keys are str

* Update the unit test so it will also run on pypy

* Run pre-commit.

Co-authored-by: default avatarJesse Clemens <jesse.clemens@sony.com>
parent 08bca374
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment