Fix confusing weakref constructor overload (#2832) (6cf6bf20) · Commits · github.com / pybind / pybind11

Unverified Commit 6cf6bf20 authored Jan 31, 2021 by

Yannick Jadoul Committed by GitHub Jan 31, 2021

Fix confusing weakref constructor overload (#2832)

* Demonstrate issue with weakref constructor overloads

* Fix weakref constructor to convert on being passed a non-weakref object

* Improve on nonlocal-scoped variable in test_weakref

* Keep backwards-compatibility by introducing PYBIND11_OBJECT_CVT_DEFAULT macro

* Simplify test_weakref

parent 932769b0

Hide whitespace changes

Inline Side-by-side

Please register or to comment