Commit a52b095f authored by Anders Kaseorg's avatar Anders Kaseorg Committed by John Hood
Browse files

mosh-server: Remove unused mosh_read_line function



This function is buggy.  feof(file) does not become true until after
we’ve tried to read past the last character; it should instead be
checking the getc return value for EOF (which is distinct from any
unsigned char).  Really it should just be replaced by istream
&std::getline(istream &is, string &str).  Fortunately, it’s unused so
we can just delete it.

Resolves a truncated stdio return value issue found by Coverity Scan
service.

Signed-off-by: default avatarAnders Kaseorg <andersk@mit.edu>
parent 0824e654
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment