1. Nov 13, 2023
  2. Nov 12, 2023
    • Tom Rini's avatar
      arm: sunxi: Correct warning in board_fit_config_name_match · f054f120
      Tom Rini authored
      
      
      When building this with clang, we get a warning about having excess
      parenthesis here, or that we're incorrectly using "==" when we want "=".
      Correct these by using the common size macro.
      
      Signed-off-by: default avatarTom Rini <trini@konsulko.com>
      Reviewed-by: default avatarSimon Glass <sjg@chromium.org>
      [Andre: Use SZ_512M as per Simon's suggestion]
      Signed-off-by: default avatarAndre Przywara <andre.przywara@arm.com>
      f054f120
    • Andre Przywara's avatar
      sunxi: board: simplify early PMIC setup conditions · ffb02942
      Andre Przywara authored
      
      
      So far we have a convoluted #ifdef mesh that guards the early AXP PMIC
      setup in board.c. That combination of &&, || and negations is very hard
      to read, maintain and especially to extend.
      
      Fortunately we have those same conditions already modelled in the
      Kconfig file, so they are actually redundant. On top of that the real
      reason we have those preprocessor guards in the first place is about the
      symbols that are *conditionally* defined: without #ifdefs the build
      would break because of them being undefined for many boards.
      
      To simplify this, just change the guards to actually look at the symbols
      needed, so CONFIG_AXP_xxx_VOLT instead of CONFIG_AXPyyy_POWER.
      This drastically improves the readability of this code, and makes adding
      PMIC support a pure Kconfig matter.
      
      Doing this revealed one bug in Kconfig: there is no axp_set_dcdc4() for
      the AXP818, even though CONFIG_AXP_DCDC4_VOLT includes that PMIC.
      Since the AXP818 wasn't included when calling axp_set_dcdc4() in board.c,
      this wasn't an issue, but becomes one now, so also remove the AXP818 from
      the DCDC4 Kconfig symbol.
      
      Signed-off-by: default avatarAndre Przywara <andre.przywara@arm.com>
      ffb02942
  3. Nov 11, 2023
  4. Nov 10, 2023