- Sep 09, 2021
-
-
Louis Dionne authored
This commit partially reverts 0954e2b2 and 3fa4cff9, which make changes to the libc++ documentation implifying that OpenBSD is supported. Neither of these changes have been reviewed AFAICT, so I'm reverting as a matter of enforcing: 1. That changes get reviewed before being committed 2. That we have a discussion and a support plan for supporting OpenBSD officially in libc++ Please note that I would be thrilled to support OpenBSD officially in libc++, however doing so requires more than adding a note in the docs. In particular, please make sure you read the note in [1] about setting up CI testing for OpenBSD. [1]: https://libcxx.llvm.org/#platform-and-compiler-support Differential Revision: https://reviews.llvm.org/D109373
-
Philip Reames authored
None of this logic has anything to do with SCEV's internals, it just uses the existing public APIs. As a result, we can move the code from ScalarEvolution.cpp/hpp to Delinearization.cpp/hpp with only minor changes. This was discussed in advance on today's loop opt call. It turned out to be easy as hoped.
-
Nikita Popov authored
Directly use i8 for GEP, rather than fetching element type of i8*.
-
Louis Dionne authored
In other places in the code, we use lowercase spelling for things that are not available in prior standards. Differential Revision: https://reviews.llvm.org/D109435
-
Akira Hatanaka authored
integer 0/1 for the operand of bundle "clang.arc.attachedcall" https://reviews.llvm.org/D102996 changes the operand of bundle "clang.arc.attachedcall". This patch makes changes to llvm that are needed to handle the new IR. This should make it easier to understand what the IR is doing and also simplify some of the passes as they no longer have to translate the integer values to the runtime functions. Differential Revision: https://reviews.llvm.org/D103000
-
Akira Hatanaka authored
integer 0/1 for the operand of bundle "clang.arc.attachedcall" This should make it easier to understand what the IR is doing and also simplify some of the passes as they no longer have to translate the integer values to the runtime functions. Differential Revision: https://reviews.llvm.org/D102996
-
Matt Morehouse authored
Fixes a build error caused by a bad merge conflict resolution for https://reviews.llvm.org/D105084.
-
Leonard Chan authored
Differential Revision: https://reviews.llvm.org/D109208
-
Leonard Chan authored
Before, COMPILER_RT_TEST_COMPILER was used which pointed to a C compiler. While it is incorrect to assume either of these is the default compiler, using the C++ one allows for linking cpp tests. Differential Revision: https://reviews.llvm.org/D109207
-
Andrew Litteken authored
D104143 introduced canonical value numbering between regions, which allows for the easy identification of items across a region, eliminating the need in the outliner to create parallel lists of instructions for each region, and replace output values in a less convoluted way. Additionally, in a future commit, the output values will not necessarily be recorded values from the region itself, it could be a combination value where the actual value being output is a PHINode instead. This new method allows us to handle the replacement of the output value to the stored value with the corresponding item in the same place for both normal output values, and PHINode outputs instead of handling the different types of outputs in different locations. Reviewers: paquette, roelofs Differential Revision: https://reviews.llvm.org/D108656
-
Joseph Huber authored
This patch changes SPMDization to not trigger for regions with no parallelism. Otherwise, this will introduce unnecessary barriers that will slow the single-threaded region down. Reviewed By: jdoerfert Differential Revision: https://reviews.llvm.org/D109438
-
Leonard Chan authored
Differential Revision: https://reviews.llvm.org/D109199
-
Alex Langford authored
IRExecutionUnit::SearchSpec is a struct that encapsulates information needed to look for a symbol. Specifically, it is comprised of a name represented with a ConstString and a FunctionNameType mask. Because the mask is unused (effectively always set to eFunctionNameTypeFull), we can remove the mask and replace all uses with eFunctionNameTypeFull. After doing that, SearchSpec is effectively a wrapper around a ConstString. As an aside, SearchSpec is similar in purpose to Module::LookupInfo. I briefly considered replacing uses of SearchSpec with LookupInfo, but the current code only cares about symbol names (treating them as eFunctionNameTypeFull). This code does care about language type, so LookupInfo may be appropriate for IRExecutionUnit in the future. Differential Revision: https://reviews.llvm.org/D109384
-
Amara Emerson authored
-
Nick Desaulniers authored
Otherwise we end up with an extra conditional jump, following by an unconditional jump off the end of a function. ie. bb.0: BT32rr .. JCC_1 %bb.4 ... bb.1: BT32rr .. JCC_1 %bb.2 ... JMP_1 %bb.3 bb.2: ... bb.3.unreachable: bb.4: ... Should be equivalent to: bb.0: BT32rr .. JCC_1 %bb.4 ... JMP_1 %bb.2 bb.1: bb.2: ... bb.3.unreachable: bb.4: ... This can occur since at the higher level IR (Instruction) SwitchInsts are required to have BBs for default destinations, even when it can be deduced that such BBs are unreachable. For most programs, this isn't an issue, just wasted instructions since the unreachable has been statically proven. The x86_64 Linux kernel when built with CONFIG_LTO_CLANG_THIN=y fails to boot though once D106056 is re-applied. D106056 makes it more likely that correlation-propagation (CVP) can deduce that the default case of Switc... -
Kirill Stoimenov authored
This should have been the 4 byte version in the first place. Unfortunatelly there is no easy way to add a test as both the 1 byte and 4 byte version are printed as 'jmp' in the assembly code. Reviewed By: kda Differential Revision: https://reviews.llvm.org/D109453
-
Wouter van Oortmerssen authored
It was a FunctionPass before, which subverted its purpose to collect ALL symbols before MCLowering, depending on how LLVM schedules function passes. Fixes https://bugs.llvm.org/show_bug.cgi?id=51555 Differential Revision: https://reviews.llvm.org/D109202
-
Yaxun (Sam) Liu authored
HIP currently diagnose capture of this pointer in device lambda in host member functions. If this pointer points to managed memory, it can be used in both device and host functions. Under this situation, capturing this pointer in device lambda functions in host member functions is valid usage. Change the diagnostic about capturing this pointer to warning. Reviewed by: Artem Belevich Differential Revision: https://reviews.llvm.org/D108493
-
Arthur O'Dwyer authored
Detected by evil-izing the widely used `MoveOnly` testing type. I had to patch some tests that were themselves using its comma operator, but I think that's a worthwhile cost in order to catch more places in our headers that needed comma-proofing. The trick here is that even `++ptr, SomeClass()` can find a comma operator by ADL, if `ptr` is of type `Evil*`. (A comma between two operands of non-class-or-enum type is always treated as the built-in comma, without ADL. But if either operand is class-or-enum, then ADL happens for _both_ operands' types.) Differential Revision: https://reviews.llvm.org/D109414
-
Craig Topper authored
-
Chris Lattner authored
-
Saleem Abdulrasool authored
Precede the `extern template` declaration prior to use. This is helpful as it prevents the compiler from having to worry about instantiating the template as it will be provided for. This is particularly important for Windows where `__declspec(dllexport)` will traverses inheritance clauses resulting in an incorrect application of dll interface to declarations.
-
Jessica Paquette authored
Similar to `DAGCombiner::visitRotate`. This makes `rotl_bitwidth_cst` in postlegalizercombiner-rotate.mir reduce down to a COPY. Modify the checkline to make sure that only rotate_out_of_range runs there. Differential Revision: https://reviews.llvm.org/D109264
-
Craig Topper authored
Identified in D109359
-
Mehdi Amini authored
This is making a tablegen crash into a more friendly error. Differential Revision: https://reviews.llvm.org/D109449
-
Dan Liew authored
Previously the test was failing on platforms where `long` was less than 64-bits wide (e.g. older WatchOS simulators and arm64_32) because the `padding` field was too small. The test currently relies on the `my_object->isa` being scribbled or left unmodified after `my_object` is freed. However, this was not the case because the `isa` pointer intersected with `ChunkHeader::free_context_id`. `free_context_id` starts at the beginning of user memory but it only initialized once the memory is freed. This caused the `isa` pointer to change after it was freed leading to the test crashing. To fix this the `padding` field has been made explicitly 64-bits wide (same size as `ChunkHeader::free_context_id`). rdar://75806757 Differential Revision: https://reviews.llvm.org/D109409
-
Nick Desaulniers authored
Upload a test that shows ISEL taking a SwitchInst that has an unreachable BB for a default target being lowered to an unconditional jump off the end of a function. Link: https://bugs.llvm.org/show_bug.cgi?id=50080 Link: https://github.com/ClangBuiltLinux/linux/issues/679 Link: https://github.com/ClangBuiltLinux/linux/issues/1440 Reviewed By: craig.topper, hans Differential Revision: https://reviews.llvm.org/D109106
-
Craig Topper authored
This is consistent with the RVV intrinsic patterns. This has been shown to prevent some "ran out of registers" errors in our internal testing. Unfortunately, there are some regressions on LMUL=8 tests in here. I think the lack of registers with LMUL=8 just makes it very hard to schedule correctly. Reviewed By: frasercrmck Differential Revision: https://reviews.llvm.org/D109245
-
Benjamin Kramer authored
-
Roman Lebedev authored
Currently, we only deal with the case where we can match the number of low bits to be kept, i.e.: ``` x & ((1 << y) - 1) ``` will extract low `y` bits of `x`. But what will ``` x & (-1 >> y) ``` do? Logically, it will extract `bitwidth(x) - y` low bits, i.e.: ``` x & ~(-1 << (bitwidth(x)-y)) ``` ... except we can't do such a transformation in IR in general, because if we wanted to extract all the bits `(-1 >> 0)` is fine, but `-1 << bitwidth(x)` would be `poison`: https://alive2.llvm.org/ce/z/BKJZfw, Yet, here with BMI's BEXTR and BMI2's BZHI we don't have any such problems with edge-cases. So what we can do is: https://alive2.llvm.org/ce/z/gm5M2B As briefly discussed with @craig.topper, this appears to be not worse than what we'd end up with currently (a pair of shifts): * https://godbolt.org/z/nsPb8bejs (direct data dependency, sequential execution) * https://godbolt.org/z/7bj3zeh1d (no direct data dependency, parallel execution) Reviewed By: craig.topper Differential Revision: https://reviews.llvm.org/D107923
-
Craig Topper authored
The expansion of these pseudos creates ADD instructions. Those ADDs modify a GPR so that it is no longer contains the same value as the input base pointer. Therefore, I believe we should have a GPR as a Def on these instructions and expansion should get the destination register for the ADDs from that operand. At least in our tests here this works out so that register scavenging picks the same register as the base pointer. Reviewed By: frasercrmck Differential Revision: https://reviews.llvm.org/D109405
-
gtt1995 authored
I found that the initial corpus allocation of fork mode has certain defects. I designed a new initial corpus allocation strategy based on size grouping. This method can give more energy to the small seeds in the corpus and increase the throughput of the test. Fuzzbench data (glibfuzzer is -fork_corpus_groups=1): https://www.fuzzbench.com/reports/experimental/2021-08-05-parallel/index.html Reviewed By: morehouse Differential Revision: https://reviews.llvm.org/D105084
-
Saleem Abdulrasool authored
This moves 2 variable declarations from `llvm/Support/Debug.h` to a more appropriate home in the headers for `LLVMAnalysis`. These variables are defined in `LLVMAnalysis` rather than in `LLVMSupport` and although they control debugging behavior, the declarations being colocated in the same library's headers is both easier to locate and aids correctly describing the library's interfaces. Reviewed By: rnk, mehdi_amini, aeubanks Differential Revision: https://reviews.llvm.org/D109396
-
Alexey Lapshin authored
This patch continues refactoring done by D99055. It puts format specific options into the correponding CopyConfig structures. Differential Revision: https://reviews.llvm.org/D102277
-
- Sep 08, 2021
-
-
Andrew Litteken authored
When we start outlining across branches, there is the possibility that we will have two different blocks with different output locations, or a single branch that goes to two blocks outside of the region that is being outlined. While the CodeExtractor provides most of the mechanisms by using the return value of the extracted function as the input to a switch statement to correctly branch to the correct location, we need special handling for different output schemas to each location. This is done by repeating the existing storing scheme for each different exit block. We have a map from the return values used, to the basic block that is used to store the outputs for that particular exit block within the outlined function. Then if needed, we create a switch statement for each return block to branch to the correct set of stored outputs. Reviewers: paquette Differential Revision: https://reviews.llvm.org/D106993
-
Kazu Hirata authored
Note that arg_operands has been deprecated in favor of args.
-
Saleem Abdulrasool authored
This moves the declaration of `VerifyDomInfo` into `llvm/IR/Dominators.h` from `llvm/Support/Debug.h`. Although this is a debugging utility, the definition of the symbol is in LLVMIR, not in LLVMSupport. This moves the declaration to the containing modules' header. Reviewed By: rnk, mehdhi_amini Differential Revision: https://reviews.llvm.org/D109395
-
David Spickett authored
Reviewed By: labath Differential Revision: https://reviews.llvm.org/D109427
-
AndreyChurbanov authored
-
Kunwar Shaanjeet Singh Grover authored
This patch refactors the existing implementation of computing an explicit representation of an identifier as a floordiv in terms of other identifiers and exposes this computation as a public function. The computation of this representation is required to support local identifiers in PresburgerSet subtract, complement and isEqual. Reviewed By: bondhugula, arjunp Differential Revision: https://reviews.llvm.org/D106662
-