- Feb 11, 2023
-
-
Yitzhak Mandelbaum authored
Removes a reference to google-internal document and expands the relevant material in place. Fixes: #60633. Differential Revision: https://reviews.llvm.org/D143750
-
OCHyams authored
Without this patch, migrateDebugInfo doesn't understand how to handle existing fragments that are smaller than the to-be-split store. This can occur if. e.g. a vector store (1 dbg.assign) is split (many dbg.assigns - 1 fragment for each scalar) and later those stores are re-vectorized (many dbg.assigns), and then SROA runs on that. The approach taken in this patch is to drop intrinsics with fragments outside of the slice. For example, starting with: store <2 x float> %v, ptr %dest !DIAssignID !1 call void @llvm.dbg.assign(..., DIExpression(DW_OP_LLVM_fragment, 0, 32), !1, ...) call void @llvm.dbg.assign(..., DIExpression(DW_OP_LLVM_fragment, 32, 32), !1, ...) When visiting the slice of bits 0 to 31 we get: store float %v.extract.0, ptr %dest !DIAssignID !2 call void @llvm.dbg.assign(..., DIExpression(DW_OP_LLVM_fragment, 0, 32), !2, ...) The other dbg.assign associated with the currently-split store is dropped for this split part. And visiting bits 32 to 63 we get the following: store float %v.extract.1, ptr %adjusted.dest !DIAssignID !3 call void @llvm.dbg.assign(..., DIExpression(DW_OP_LLVM_fragment, 32, 32), !3, ...) I've added two tests that cover this case. Implementing this meant re-writing the fragment-calculation part of migrateDebugInfo to work with the absolute offset of the new slice in terms of the base alloca (instead of the offset of the slice into the new alloca), the fragment (if any) of the variable associated with the base alloca, and the fragment associated with the split store. Because we need the offset into the base alloca for the variables being split, some careful wiring is required for memory intrinsics due to the fact that memory intrinsics can be split when either the source or dest allocas are split. In the case where the source alloca drives the splitting, we need to be careful to pass migrateDebugInfo the information in relation to the dest alloca. Reviewed By: StephenTozer Differential Revision: https://reviews.llvm.org/D143146
-
David Green authored
The mid end will reassociate sub(sub(x, m1), m2) to sub(x, add(m1, m2)). This reassociates it back to allow the creation of more mls instructions. Differential Revision: https://reviews.llvm.org/D143143
-
Craig Topper authored
operator~ promote the single bit input to int. The ~ will cause the upper 31 bits to become 1s making it a negative value. This is undefined for shift. Mask it back down to a single bit. The extra 1s were being shifted to bit 8 and above and the they aren't used by the emitByte call so this shouldn't be a functional change.
-
Benjamin Kramer authored
-
Johannes Doerfert authored
-
Johannes Doerfert authored
Even if liveness changed, we only care about certain dead edges in AAIntraFnReachability. If those are still dead, we can avoid an update.
-
Johannes Doerfert authored
If a query uses an exclusion set but we haven't used it to determine the result, we can cache the query without exclusion set too. When we lookup a cached result we can check for the non-exclusion set version first.
-
Johannes Doerfert authored
-
Johannes Doerfert authored
This caused multiple string operations which we don't need if we do not create a profile.
-
Johannes Doerfert authored
-
Johannes Doerfert authored
This change simply avoids the temporary vector and processes the elments right away.
-
Louis Dionne authored
- Add missing _LIBCPP_HIDE_FROM_ABI - Implement inline functions in the class to simplify the code - Add missing `const` to `operator()` - Move _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK to the usual location for function attributes Differential Revision: https://reviews.llvm.org/D143668
-
Michael Buch authored
**Summary** This patch addresses the case where we have a `DW_AT_external` subprogram for a constructor (and/or destructor) that doesn't carry a `DW_AT_linkage_name` attribute. The corresponding DIE(s) that represent the definition will have a linkage name, but if the name contains constructs that LLDBs fallback mechanism for guessing mangled names to resolve external symbols doesn't support (e.g., abi-tags) then we end up failing to resolve the function call. We address this by trying to find the linkage name before we create the constructor/destructor decl, which will get attached using an `AsmLabelAttr` to make symbol resolution easier. **Testing** * Added API test Differential Revision: https://reviews.llvm.org/D143652
-
Michael Buch authored
This relands the commit previously reverted in `8570bee5` due to failures on linux. The problem was that the test executable was built with absolute OSO prefix paths. This re-commit adds a modified version of the executable that strips the absolute OSO prefix paths and makes sure the test appends the OSO prefix appropriately (via the appropriate dsymutil flags). Differential Revision: https://reviews.llvm.org/D143458
-
Florian Hahn authored
The current code incorrectly returned the first instead of the last row. This fixes the debug output.
-
Slava Zakharin authored
Some conversions were still happening under no-complex/character-conversion options. This change fixes that and adds a LIT test. Differential Revision: https://reviews.llvm.org/D143685
-
Markus Böck authored
The current OpenMP implementation assumes the use of typed pointers (or rather typed pointer like types). Given the support for typed pointers in LLVM is now pending removal, the OpenMP Dialect should be able to support opaque pointers as well, given that any users of it must lower OpenMP through the LLVM Dialect. This patch fixes the above and adds support for using LLVM opaque pointers with the OpenMP dialect. This is implemented by making all related code not make use of the element type of pointer arguments. The few (one) op requiring a pointer element type now use an explicit `TypeAttr` for representing the element type. More concretely, the list of changes are: * `omp.atomic.read` now has an extra `TypeAttr` (also in syntax) which is the element type of the values read and stored from the operands * `omp.reduction` now has an type argument in the syntax for both the accmulator and operand since the operand type can no longer be inferred from the accumulator * `OpenMPToLLVMIRTranslation.cpp` was rewritten to never query element types of pointers * Adjusted the verifier to be able to handle pointers without element types Differential Revision: https://reviews.llvm.org/D143582
-
Markus Böck authored
Part of https://discourse.llvm.org/t/rfc-switching-the-llvm-dialect-and-dialect-lowerings-to-opaque-pointers/68179 This patch adds the pass option 'use-opaque-pointers' to allow the dialect conversion from async to LLVM to create LLVM opaque pointers instead of typed pointers. The gist of the changes boil down to having to propagate the choice of whether opaque or typed pointers should be used, to various helper functions that then either create typed pointers or opaque pointers. This sadly creates a bit of a code duplication in comparison to other patches in this series, which I think is mostly unavoidable however, since a lot of the patterns in this lowering require the use of the AsyncTypeConverter, instead of the LLVMTypeConverter. Besides that, the tests have been converter to opaque pointers with one file with typed pointer support having been created as regression tests. Differential Revision: https://reviews.llvm.org/D143661
-
Daniel Grumberg authored
Remove failure conditions for categories in libclang and return empty content instead. Differential Revision: https://reviews.llvm.org/D142101
-
Florian Hahn authored
The current checks show incorrect debug output.
-
Tom Eccles authored
This function returns whether a block is nested inside of a loop. There can be three kinds of loop: 1) The block is nested inside of a LoopLikeOpInterface 2) The block is nested inside another block which is in a loop 3) There is a cycle in the control flow graph This will be useful for Flang's stack arrays pass, which moves array allocations from the heap to the stack. Special handling is needed when allocations occur inside of loops to ensure additional stack space is not allocated on each loop iteration. Differential Revision: https://reviews.llvm.org/D141401
-
- Feb 10, 2023
-
-
Sanjay Patel authored
As shown in issue #60649, the new shuffles were being inserted before a phi, and that is invalid. It seems like most test coverage for this fold (foldSelectShuffle) lives in the AArch64 dir, but this doesn't repro there for a base target.
-
John Brawn authored
When looking for defined symbols, look for symbols that aren't of a type that we don't want, instead of having specific list of symbol types that we do want. This fixes a problem where (when using GNU nm at least) there were some symbol types that we want to export but which weren't in the list.
-
Yitzhak Mandelbaum authored
The parameter in question belongs to a function that is only called once. This patch updates the API to use a reference and changes the caller accordingly. Differential Revision: https://reviews.llvm.org/D143735
-
Mircea Trofin authored
This reverts commit dc4c3cfd. Reverting because D143624 has been reverted.
-
Guillaume Chatelet authored
-
Sanjay Patel authored
-
Sanjay Patel authored
-
Sanjay Patel authored
Tail markings are not propagated if the transform succeeds.
-
David Green authored
This seems to cause large regressions in existing code, as much as 75% slower (4x the time taken). Small always inline functions seem to be used a lot in the cmsis-dsp library. I would add a phase ordering test to show the problems, but one already exists! The llvm/test/Transforms/PhaseOrdering/ARM/arm_mult_q15.ll was just changed by removing alwaysinline to hide the problems that existed. This reverts commit cae033dc. This reverts commit 8e33c41e.
-
Juan Manuel MARTINEZ CAAMAÑO authored
Reviewed By: scott.linder Differential Revision: https://reviews.llvm.org/D142453
-
Benjamin Maxwell authored
This fixes a few places where the addrx3 and strx3 forms were missed. Previously this meant if one of these forms appeared somewhere various errors could occur. This now also adds an extra test case for the addrx3 form (which previously failed). Differential Revision: https://reviews.llvm.org/D143488
-
Denis Fatkulin authored
The refactoring !!Move function body to out-of-line!! produces incorrect code for methods of unnamed classes. For this simple example // foo.h struct Foo { struct { void f^oo() {} } Bar; }; the refactoring generates code: // foo.cpp void Foo::(unnamed struct at D:\test\foo.h:2:3)foo() {} Outplace definition for methods of unnamed classes is meaningless. The patch disables it. Reviewed By: kadircet Differential Revision: https://reviews.llvm.org/D143638 -
Tobias Gysi authored
The revision introduces operation attributes to store tbaa metadata on load and store operations rather than relying using dialect attributes. At the same time, the change also ensures the provided getters and setters instead are used instead of a string based lookup. The latter is done for the tbaa, access groups, and alias scope attributes. The goal of this change is to ensure the metadata attributes are only placed on operations that have the corresponding operation attributes. This is imported since only these operations later on translate these attributes to LLVM IR. Dialect attributes placed on other operations are lost during the translation. Reviewed By: vzakhari, Dinistro Differential Revision: https://reviews.llvm.org/D143654
-
Joseph Huber authored
The function clang_target_link_libraries must only be used with real Clang libraries; with CLANG_LINK_CLANG_DYLIB, it will instead link in clang-cpp. We must use the standard CMake target_link_libraries for the HSA library.
-
v1nh1shungry authored
``` void foobar(int); int main() { foobar(1 + 2); ^ } ``` Currently the CalleeArgInfo will be "Passed by reference", which should be "Passed by value". Fixes https://github.com/clangd/clangd/issues/1467 Differential Revision: https://reviews.llvm.org/D142014 -
LLVM GN Syncbot authored
-
Simon Pilgrim authored
This also requires us to constant fold vXi1 concat_vector nodes
-
Guillaume Chatelet authored
Let's make sure that we only accept boolean expressions when using likely/unlikely. Differential Revision: https://reviews.llvm.org/D143732
-