- Feb 14, 2020
-
-
Alexey Bataev authored
According to OpenMP 5.0, cancel and cancellation point constructs are supported in taskloop directive. Added support for cancellation in taskloop, master taskloop and parallel master taskloop.
-
Fangrui Song authored
Fixes https://bugs.llvm.org//show_bug.cgi?id=44878 When --strip-debug is specified, .debug* are removed from inputSections while .rel[a].debug* (incorrectly) remain. LinkerScript::addOrphanSections() requires the output section of a relocated InputSectionBase to be created first. .debug* are not in inputSections -> output sections .debug* are not created -> getOutputSectionName(.rel[a].debug*) dereferences a null pointer. Fix the null pointer dereference by deleting .rel[a].debug* from inputSections as well. Reviewed By: grimar, nickdesaulniers Differential Revision: https://reviews.llvm.org/D74510
-
Tatyana Krasnukha authored
This commit fixes an issue with lldb-vscode failing to run programs that use different architecture/platform than the "empty" in the target. Original implementation was creating a default target without specifying the target architecture, platform or program, and then would set executable file through SBLaunchInfo, assuming that this would update architecture and platform accordingly. However this wasn't really happening, and architecture and platform would remain at whatever values were in the "empty" target. The simple solution is to create target already for a desired architecture and platform. Function request_attach is updated in a similar fashion. This commit also adds new JSON properties to "launch" and "attach" packets to allow user to override desired platform and architecture. This might be especially important for cases where information in ELF is not enough to derive those values correctly. New code has a behavior similar to LLDB MI [1], where typically IDE would specify target file with -file-exec-and-symbols, and then only do -exec-run command that would launch the process. In lldb-vscode those two actions are merged into one request_launch function. Similarly in the interpreter session, user would first do "file" command, then "process launch" Differential Revision: https://reviews.llvm.org/D70847 Signed-off-by:
Anton Kolesov <anton.kolesov@synopsys.com>
-
Greg Clayton authored
Stop emitting a breakpoint for each location in a breakpoint when responding to breakpoint commands. Summary: The VS Code DAP expects on response for each breakpoint that was requested. If we responsd with multiple entries for one breakpoint the VS Code UI gets out of date. Currently the VS code DAP doesn't handle one breakpoint with multiple locations. If this ever gets fixed we can modify our code. Reviewers: labath Subscribers: lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D73665
-
John Brawn authored
If the target has FP64 but not FP16 then we have custom lowering for FP_EXTEND and STRICT_FP_EXTEND with type f64. However if the extend is from f32 to f64 the current implementation will cause in infinite loop for STRICT_FP_EXTEND due to emitting a merge_values of the original node which after replacement becomes a merge_values of itself. Fix this by not doing anything for f32 to f64 extend when we have FP64, though for STRICT_FP_EXTEND we have to do the strict-to-nonstrict mutation as that doesn't happen automatically for opcodes with custom lowering. Differential Revision: https://reviews.llvm.org/D74559
-
Alexey Bataev authored
We need to capture correctly the value of num_tasks clause and should not try to emit the if clause at all in the task region.
-
- Feb 13, 2020
-
-
Stephan Herhut authored
Summary: To unblock other work, this implements basic lowering based on mapping attributes that have to be provided on all loop.parallel. The lowering does not yet support reduce. Differential Revision: https://reviews.llvm.org/D73893
-
Sanjay Patel authored
We want the extra-use tests to be consistent with the earlier single-use tests and be as cheap as possible in vector form to show cost model edge cases. So use i8 and extract from element 0 since that should be cheap for all x86 targets.
-
Alexey Bataev authored
-
Sanjay Patel authored
See D74495.
-
Francesco Petrogalli authored
-
Sean Fertile authored
Skip the loop over the CalleSavedInfos in 'restoreCalleeSavedRegisters' when the register is a CR field and we are not targeting 32-bit ELF. This is safe because: 1) The helper function 'restoreCRs' returns if the target is not 32-bit ELF, making all the code in the loop related to CR fields dead for every other subtarget. This code is only called on ELF right now, but the patch to extend it for AIX also needs to skip 'restoreCRs'. 2) The loop will not otherwise modify the iterator, so the iterator manipulations at the bottom of the loop end up setting 'I' to its current value. This simplifciation allows us to remove one argument from 'restoreCRs'. Also add a helper function to determine if a register is one of the callee saved condition register fields.
-
Nico Weber authored
-
Pavel Labath authored
Summary: This patch creates a new subclass of the ABI class in order to abstract away the mechanism in which we "augment" register information. This enables alternate augmentation strategies to be introduced. All existing ABI classes have been modified to inherit from RegInfoBasedABI, but they will be refactored in subsequent patches. Reviewers: JDevlieghere, jasonmolenda Subscribers: sdardis, nemanjai, kbarton, jrtc27, atanasyan, jsji, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D74243
-
Simon Pilgrim authored
-
Simon Pilgrim authored
-
Nico Weber authored
Before, the script used `git log -SFoo.cpp` to find a commit where the number of occurrences of "Foo.cpp" changed -- but since a patch with + LLVMFoo.cpp - Foo.cpp contains the same number of instances of "Foo.cpp", the script incorrectly skipped this type of rename. As fix, look for '\bFoo\.cpp\b' instead and pass --pickaxe-regex so that we can grep for word boundaries. To test, check out 7531a503 (which renamed in llvm/lib/IR RemarkStreamer.cpp to LLVMRemarkStreamer.cpp) and look at the output of the script. Before this change, it correctly assigned the addition of LLVMRemarkStreamer.cpp to 7531a503 but incorrectly assigned the removal of RemarkStreamer.cpp to b8a847c0. With this, it correctly assigns both to 7531a503.
-
Jeremy Morse authored
These are some minor things that I've run into on Windows, largely in error handling paths: * Giving --lldb-executable on Windows triggers a "useless option" code path, which touches an attribute that only exists in the list_debuggers tool. Switch this to use hasattr, which will work in all subtools. * We were over-decoding some text reporting errors, but only in an exception path * The path to lldb on Windows needs to be quoted (even though dexter isn't making use of it). Differential Revision: https://reviews.llvm.org/D74546
-
Kirill Bobyrev authored
Summary: Make it possible for the client to adjust the ranking by using the score Clangd calculates for the completion items. Reviewers: sammccall Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D74547
-
Raphael Isemann authored
Summary: The error message from the construct `assertTrue(a == b, "msg") ` are nearly always completely useless for actually debugging the issue. This patch is just replacing this construct (and similar ones like `assertTrue(a != b, ...)` with the proper call to assertEqual or assertNotEquals. This patch was mostly written by a shell script with some manual verification afterwards: ``` lang=python import sys def sanitize_line(line): if line.strip().startswith("self.assertTrue(") and " == " in line: line = line.replace("self.assertTrue(", "self.assertEquals(") line = line.replace(" == ", ", ", 1) if line.strip().startswith("self.assertTrue(") and " != " in line: line = line.replace("self.assertTrue(", "self.assertNotEqual(") line = line.replace(" != ", ", ", 1) return line for a in sys.argv[1:]: with open(a, "r") as f: lines = f.readlines() with open(a, "w") as f: for line in lines: f.write(sanitize_line(line)) ``` Reviewers: labath, JDevlieghere Reviewed By: labath Subscribers: abidh, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D74475 -
Alexander Belyaev authored
Summary: On some platforms the build fails "std::function is not found". The include is used in PassManager::IRPrinterConfig::enableIRPrinting. Differential Revision: https://reviews.llvm.org/D74469
-
Pavel Labath authored
to account for the new location of test files from 99451b44.
-
serge-sans-paille authored
Call llvm_process_pass_plugin from clang when in standalone mode. Differential Revision: https://reviews.llvm.org/D74464
-
serge-sans-paille authored
Basically change the layout to please `go build` and remove references to `llvm-go`. Update llvm/test/Bindings/Go/ to use the system go compiler Differential Revision: https://reviews.llvm.org/D74540
-
Qiu Chaofan authored
Exploit native VSX rounding instruction, x(v|s)r(d|s)pic, which does rounding using current rounding mode. According to C standard library, rint may raise INEXACT exception while nearbyint won't. Reviewed By: lkail Differential Revision: https://reviews.llvm.org/D72685
-
Gabor Marton authored
Summary: Both EOF and the max value of unsigned char is platform dependent. In this patch we try our best to deduce the value of EOF from the Preprocessor, if we can't we fall back to -1. Reviewers: Szelethus, NoQ Subscribers: whisperity, xazax.hun, kristof.beyls, baloghadamsoftware, szepet, rnkovacs, a.sidorin, mikhail.ramalh Tags: #clang Differential Revision: https://reviews.llvm.org/D74473
-
Jeremy Morse authored
When writing the Windows dbgeng driver for Dexter, I couldn't work out why it would either launch a process and leave it free running, or if I started the process suspended, never do anything with it. The result was a hack to create and attach processes manually. This has been flaking out on Reids Windows buildbot, and clearly wasn't a good solution. Digging into this, it turns out that the "normal" cdb / windbg behaviour of breaking whenever we attach to a process is not the default: it has to be explicitly requested from the debug engine. This patch does so (by setting DEBUG_ENGOPT_INITIAL_BREAK in the engine options), after which we can simply call "CreateProcessAndAttach2" and everything automagically works. No test for this behaviour: everything was just broken before. Differential Revision: https://reviews.llvm.org/D74409
-
Haojian Wu authored
-
stozer authored
This reverts commit 61b35e41. This commit causes a timeout in chromium builds; likely to have a similar cause to the previous timeout issue caused by this commit (see 6ded69f2 for more details). It is possible that there is no way to fix this bug that will not cause this issue; further investigations as to the efficiency of handling large amounts of debug info will be necessary.
-
Haojian Wu authored
-
Christof Douma authored
When the clang baremetal driver selects the rt.builtins static library it prefix with "-l" and appends ".a". The result is a nonsense option which lld refuses to accept. Differential Revision: https://reviews.llvm.org/D73904 Change-Id: Ic753b6104e259fbbdc059b68fccd9b933092d828
-
Daniel Kiss authored
In some cases BTI landing pad is inserted even compatible instruction was there already. Meta instruction does not count in this case therefore skip them in the check for first instructions in the function. Differential revision: https://reviews.llvm.org/D74492
-
Kerry McLaughlin authored
Summary: Implements the following intrinsics: - @llvm.aarch64.sve.dup - @llvm.aarch64.sve.mul.lane - @llvm.aarch64.sve.mla.lane - @llvm.aarch64.sve.mls.lane Reviewers: c-rhodes, sdesmalen, dancgr, efriedma, rengolin Reviewed By: sdesmalen Subscribers: tschuett, kristof.beyls, hiraditya, rkruppe, psnobl, cfe-commits, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D74222
-
Guillaume Chatelet authored
-
David Green authored
Simon pointed out that this function is doing a bitcast, which can be incorrect for big endian. That makes the lowering of VMOVN in MVE wrong, but the function is shared between Neon and MVE so both can be incorrect. This attempts to fix things by using the newly added VECTOR_REG_CAST instead of the BITCAST. As it may now be used on Neon, I've added the relevant patterns for it there too. I've also added a quick dag combine for it to remove them where possible. Differential Revision: https://reviews.llvm.org/D74485
-
David Green authored
-
Roman Lebedev authored
-
Peter Smith authored
Recommit of 0b4a047b (reverted in c2900381) to incorporate subsequent fix and add a warning when LLD's interworking behavior has changed. D73474 disabled the generation of interworking thunks for branch relocations to non STT_FUNC symbols. This patch handles the case of BL and BLX instructions to non STT_FUNC symbols. LLD would normally look at the state of the caller and the callee and write a BL if the states are the same and a BLX if the states are different. This patch disables BL/BLX substitution when the destination symbol does not have type STT_FUNC. This brings our behavior in line with GNU ld which may prevent difficult to diagnose runtime errors when switching to lld. This change does change how LLD handles interworking of symbols that do not have type STT_FUNC from previous versions including the 10.0 release. This brings LLD in line with ld.bfd but there may be programs that have not been linked with ld.bfd that depend on LLD's previous behavior. We emit a warning when the behavior changes. A summary of the difference between 10.0 and 11.0 is that for symbols that do not have a type of STT_FUNC LLD will not change a BL to a BLX or vice versa. The table below enumerates the changes | relocation | STT_FUNC | bit(0) | in | 10.0- out | 11.0+ out | | R_ARM_CALL | no | 1 | BL | BLX | BL | | R_ARM_CALL | no | 0 | BLX | BL | BLX | | R_ARM_THM_CALL | no | 1 | BLX | BL | BLX | | R_ARM_THM_CALL | no | 0 | BL | BLX | BL | Differential Revision: https://reviews.llvm.org/D73542
-
Pavel Labath authored
- reduce indentation by removing the defensive GetID()!=INVALID_PROCESS_ID check -- this function is only called when an attach or launch succeeds - replace LLDB_LOGF with LLDB_LOG
-
Haojian Wu authored
Summary: Though this is not needed when using clangd's own index, other indexes (e.g. kythe) need it, as classes and their constructors are different symbols, otherwise we will miss renaming constructors. Reviewers: kbobyrev Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, usaxena95, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D74411
-