- Feb 11, 2023
-
-
Craig Topper authored
-
Jay Foad authored
These are similar to hardware registers already added for GFX940, but with different numbers and slightly different names. Differential Revision: https://reviews.llvm.org/D143740
-
AmosLewis authored
Add TOSA f64 type support for cast op Reviewed By: eric-k256 Differential Revision: https://reviews.llvm.org/D142599
-
Markus Böck authored
See https://github.com/llvm/llvm-project/issues/57475 for more context. Using auto-generated constructors and options has significant advantages: * It forces a uniform style and expectation for consuming a pass * It allows to very easily add, remove or change options to a pass by simply making the changes in TableGen * Its less code This patch in particular ports all the conversion passes which lower to LLVM to use the auto generated constructors and options. For the most part, care was taken so that auto generated constructor functions have the same name as they previously did. Only following slight breaking changes (which I consider as worth the churn) have been made: * `mlir::cf::createConvertControlFlowToLLVMPass` has been moved to the `mlir` namespace. This is consistent with basically all conversion passes * `createGpuToLLVMConversionPass` now takes a proper options struct array for its pass options. The pass options are now also autogenerated. * `LowerVectorToLLVMOptions` has been replaced by the autogenerated `ConvertVectorToLLVMPassOptions` which is automatically kept up to date by TableGen * I had to move one function in the GPU to LLVM lowering as it is used as default value for an option. * All passes that previously returned `unique_ptr<OperationPass<...>>` now simply return `unique_ptr<Pass>` Differential Revision: https://reviews.llvm.org/D143773
-
Alex Brachet authored
Differential Revision: https://reviews.llvm.org/D137800
-
Alex Brachet authored
Differential Revision: https://reviews.llvm.org/D137799
-
Rahman Lavaee authored
D100808 implemented the new version, but kept version 1 as the emitted version. This patch changes the version to 2 and updates the codegen tests. Differential Revision: https://reviews.llvm.org/D139799
-
Konstantin Varlamov authored
Differential Revision: https://reviews.llvm.org/D143245
-
Changpeng Fang authored
Summary: This is part of the leftover work for https://reviews.llvm.org/D143138. In this work, we pass code object version as an argument to initialize target ID and use it for targetID dump. Reviewers: arsenm Differential Revision https://reviews.llvm.org/D143293
-
Dani Ferreira Franco Moura authored
If the modifiedType and the minimally desugared type of an AttributedType are the same, then we do not need to show both in an AST dump. Here, we change VisitAttributedType to only visit the modifiedType when it is different from the equivalentType (the minimally desugared type), because the latter is already visited by default. Reviewed By: sammccall Differential Revision: https://reviews.llvm.org/D142637
-
ManuelJBrito authored
-
Jim Kitchen authored
Previously, when performing a reduction on a sparse tensor, the result would be different depending on iteration order. For expanded access pattern, an empty row would contribute no entry in the output. For lex ordering, the identity would end up in the output. This code changes that behavior and keeps track of whether any entries were actually reduced in lex ordering, making the output consistent between the two iteration styles. Differential Revision: https://reviews.llvm.org/D142050
-
Tue Ly authored
Properly set floating point exceptions and add more exceptional values for non-FMA x86-64 targets. Reviewed By: michaelrj Differential Revision: https://reviews.llvm.org/D143699
-
Fangrui Song authored
-
BigPeet authored
Fixes #55869 Reviewed By: njames93, nicovank Differential Revision: https://reviews.llvm.org/D142939
-
Michael Buch authored
Also make expected mangling more flexible since it's different between Linux and Darwin Differential Revision: https://reviews.llvm.org/D143652
-
Arthur Eubanks authored
Namely CrossDSOCFI and GlobalSplit. These are part of the optimization pipeline, of which the legacy pass manager version is deprecated.
-
Michael Jones authored
Fuzzing the string to integer and float functions without relying on the system libc allows for tests to be run in a wider variety of places. Reviewed By: sivachandra Differential Revision: https://reviews.llvm.org/D143616
-
Tom Weaver authored
The revert of https://reviews.llvm.org/rG65f9719913eca9c7c72d1abf4eddab767abaebf6 removes a system-windows guard but does not remove the test causing windows system failures. This patch adds back a guard to prevent further failures.
-
Yitzhak Mandelbaum authored
Removes a reference to google-internal document and expands the relevant material in place. Fixes: #60633. Differential Revision: https://reviews.llvm.org/D143750
-
OCHyams authored
Without this patch, migrateDebugInfo doesn't understand how to handle existing fragments that are smaller than the to-be-split store. This can occur if. e.g. a vector store (1 dbg.assign) is split (many dbg.assigns - 1 fragment for each scalar) and later those stores are re-vectorized (many dbg.assigns), and then SROA runs on that. The approach taken in this patch is to drop intrinsics with fragments outside of the slice. For example, starting with: store <2 x float> %v, ptr %dest !DIAssignID !1 call void @llvm.dbg.assign(..., DIExpression(DW_OP_LLVM_fragment, 0, 32), !1, ...) call void @llvm.dbg.assign(..., DIExpression(DW_OP_LLVM_fragment, 32, 32), !1, ...) When visiting the slice of bits 0 to 31 we get: store float %v.extract.0, ptr %dest !DIAssignID !2 call void @llvm.dbg.assign(..., DIExpression(DW_OP_LLVM_fragment, 0, 32), !2, ...) The other dbg.assign associated with the currently-split store is dropped for this split part. And visiting bits 32 to 63 we get the following: store float %v.extract.1, ptr %adjusted.dest !DIAssignID !3 call void @llvm.dbg.assign(..., DIExpression(DW_OP_LLVM_fragment, 32, 32), !3, ...) I've added two tests that cover this case. Implementing this meant re-writing the fragment-calculation part of migrateDebugInfo to work with the absolute offset of the new slice in terms of the base alloca (instead of the offset of the slice into the new alloca), the fragment (if any) of the variable associated with the base alloca, and the fragment associated with the split store. Because we need the offset into the base alloca for the variables being split, some careful wiring is required for memory intrinsics due to the fact that memory intrinsics can be split when either the source or dest allocas are split. In the case where the source alloca drives the splitting, we need to be careful to pass migrateDebugInfo the information in relation to the dest alloca. Reviewed By: StephenTozer Differential Revision: https://reviews.llvm.org/D143146
-
David Green authored
The mid end will reassociate sub(sub(x, m1), m2) to sub(x, add(m1, m2)). This reassociates it back to allow the creation of more mls instructions. Differential Revision: https://reviews.llvm.org/D143143
-
Craig Topper authored
operator~ promote the single bit input to int. The ~ will cause the upper 31 bits to become 1s making it a negative value. This is undefined for shift. Mask it back down to a single bit. The extra 1s were being shifted to bit 8 and above and the they aren't used by the emitByte call so this shouldn't be a functional change.
-
Benjamin Kramer authored
-
Johannes Doerfert authored
-
Johannes Doerfert authored
Even if liveness changed, we only care about certain dead edges in AAIntraFnReachability. If those are still dead, we can avoid an update.
-
Johannes Doerfert authored
If a query uses an exclusion set but we haven't used it to determine the result, we can cache the query without exclusion set too. When we lookup a cached result we can check for the non-exclusion set version first.
-
Johannes Doerfert authored
-
Johannes Doerfert authored
This caused multiple string operations which we don't need if we do not create a profile.
-
Johannes Doerfert authored
-
Johannes Doerfert authored
This change simply avoids the temporary vector and processes the elments right away.
-
Louis Dionne authored
- Add missing _LIBCPP_HIDE_FROM_ABI - Implement inline functions in the class to simplify the code - Add missing `const` to `operator()` - Move _LIBCPP_DISABLE_UBSAN_UNSIGNED_INTEGER_CHECK to the usual location for function attributes Differential Revision: https://reviews.llvm.org/D143668
-
Michael Buch authored
**Summary** This patch addresses the case where we have a `DW_AT_external` subprogram for a constructor (and/or destructor) that doesn't carry a `DW_AT_linkage_name` attribute. The corresponding DIE(s) that represent the definition will have a linkage name, but if the name contains constructs that LLDBs fallback mechanism for guessing mangled names to resolve external symbols doesn't support (e.g., abi-tags) then we end up failing to resolve the function call. We address this by trying to find the linkage name before we create the constructor/destructor decl, which will get attached using an `AsmLabelAttr` to make symbol resolution easier. **Testing** * Added API test Differential Revision: https://reviews.llvm.org/D143652
-
Michael Buch authored
This relands the commit previously reverted in `8570bee5` due to failures on linux. The problem was that the test executable was built with absolute OSO prefix paths. This re-commit adds a modified version of the executable that strips the absolute OSO prefix paths and makes sure the test appends the OSO prefix appropriately (via the appropriate dsymutil flags). Differential Revision: https://reviews.llvm.org/D143458
-
Florian Hahn authored
The current code incorrectly returned the first instead of the last row. This fixes the debug output.
-
Slava Zakharin authored
Some conversions were still happening under no-complex/character-conversion options. This change fixes that and adds a LIT test. Differential Revision: https://reviews.llvm.org/D143685
-
Markus Böck authored
The current OpenMP implementation assumes the use of typed pointers (or rather typed pointer like types). Given the support for typed pointers in LLVM is now pending removal, the OpenMP Dialect should be able to support opaque pointers as well, given that any users of it must lower OpenMP through the LLVM Dialect. This patch fixes the above and adds support for using LLVM opaque pointers with the OpenMP dialect. This is implemented by making all related code not make use of the element type of pointer arguments. The few (one) op requiring a pointer element type now use an explicit `TypeAttr` for representing the element type. More concretely, the list of changes are: * `omp.atomic.read` now has an extra `TypeAttr` (also in syntax) which is the element type of the values read and stored from the operands * `omp.reduction` now has an type argument in the syntax for both the accmulator and operand since the operand type can no longer be inferred from the accumulator * `OpenMPToLLVMIRTranslation.cpp` was rewritten to never query element types of pointers * Adjusted the verifier to be able to handle pointers without element types Differential Revision: https://reviews.llvm.org/D143582
-
Markus Böck authored
Part of https://discourse.llvm.org/t/rfc-switching-the-llvm-dialect-and-dialect-lowerings-to-opaque-pointers/68179 This patch adds the pass option 'use-opaque-pointers' to allow the dialect conversion from async to LLVM to create LLVM opaque pointers instead of typed pointers. The gist of the changes boil down to having to propagate the choice of whether opaque or typed pointers should be used, to various helper functions that then either create typed pointers or opaque pointers. This sadly creates a bit of a code duplication in comparison to other patches in this series, which I think is mostly unavoidable however, since a lot of the patterns in this lowering require the use of the AsyncTypeConverter, instead of the LLVMTypeConverter. Besides that, the tests have been converter to opaque pointers with one file with typed pointer support having been created as regression tests. Differential Revision: https://reviews.llvm.org/D143661
-
Daniel Grumberg authored
Remove failure conditions for categories in libclang and return empty content instead. Differential Revision: https://reviews.llvm.org/D142101
-
Florian Hahn authored
The current checks show incorrect debug output.
-