1. Jan 20, 2020
  2. Jan 19, 2020
  3. Jan 18, 2020
    • Eric Astor's avatar
      Revert "[ms] [llvm-ml] Add placeholder for llvm-ml, based on llvm-mc" · 0eeddf1a
      Eric Astor authored
      This reverts commit 22af2cbe, due to breakages on ARM platforms.
      0eeddf1a
    • Saar Raz's avatar
      Revert "[Concepts] Requires Expressions" · baa84d8c
      Saar Raz authored
      This reverts commit 02793189.
      
      There have been some failing tests on some platforms, reverting while investigating.
      baa84d8c
    • Simon Pilgrim's avatar
      [X86] Rename lowerShuffleAsRotate -> lowerShuffleAsVALIGN · 69bc4508
      Simon Pilgrim authored
      Since it can only ever create VALIGN nodes.
      69bc4508
    • Simon Pilgrim's avatar
    • Saar Raz's avatar
      [Concepts] Requires Expressions · 02793189
      Saar Raz authored
      Implement support for C++2a requires-expressions.
      
      Differential Revision: https://reviews.llvm.org/D50360
      02793189
    • Michael Liao's avatar
    • Fred Riss's avatar
      [lldb/testsuite] Modernize 2 test Makefiles · 546f8f42
      Fred Riss authored
      Those old Makefiles used completely ad-hoc rules for building files,
      which means they didn't obey the test harness' variants.
      
      They were somewhat tricky to update as they use very peculiar build
      flags for some files. For this reason I was careful to compare the
      build commands before and after the change, which is how I found the
      discrepancy fixed by the previous commit.
      
      While some of the make syntax used here might not be easy to grasp for
      newcomers (per-target variable overrides), it seems better than to
      have to repliacte the Makefile.rules logic for the test variants and
      platform support.
      546f8f42
    • Fred Riss's avatar
      [lldb/Makefile.rules] Force the default target to be 'all' · 509b7888
      Fred Riss authored
      The test harness invokes the test Makefiles with an explicit 'all'
      target, but it's handy to be able to recursively call Makefile.rules
      without speficying a goal.
      
      Some time ago, we rewrote some tests in terms of recursive invocations
      of Makefile.rules. It turns out this had an unintended side
      effect. While using $(MAKE) for a recursive invocation passes all the
      variables set on the command line down, it doesn't pass the make
      goals. This means that those recursive invocations would invoke the
      default rule. It turns out the default rule of Makefile.rules is not
      'all', but $(EXE). This means that ti would work becuase the
      executable is always needed, but it also means that the created
      binaries would not follow some of the other top-level build
      directives, like MAKE_DSYM.
      
      Forcing 'all' to be the default target seems easier than making sure
      all the invocations are correct going forward. This patch does this
      using the .DEFAULT_GOAL directive rather than hoisting the 'all' rule
      to be the first one of the file. It seems like this explicit approach
      will be less prone to be broken in the future. Hopefully all the make
      implementations we use support it.
      509b7888
    • David Blaikie's avatar
      DebugInfo: Move SectionLabel tracking into CU's addRange · 58b10df5
      David Blaikie authored
      This makes the SectionLabel handling more resilient - specifically for
      future PROPELLER work which will have more CU ranges (rather than just
      one per function).
      
      Ultimately it might be nice to make this more general/resilient to
      arbitrary labels (rather than relying on the labels being created for CU
      ranges & then being reused by ranges, loclists, and possibly other
      addresses). It's possible that other (non-rnglist/loclist) uses of
      addresses will need the addresses to be in SectionLabels earlier (eg:
      move the CU.addRange to be done on function begin, rather than function
      end, so during function emission they are already populated for other
      use).
      58b10df5
    • David Blaikie's avatar
      [IR] Remove some unnecessary cleanup in Module's dtor, and use a unique_ptr to simplify some · 46ed9331
      David Blaikie authored
      Follow on from D72812, based on Mehdi Amini's feedback.
      46ed9331
    • Derek Schuff's avatar
      [WebAssembly] Track frame registers through VReg and local allocation · ff171acf
      Derek Schuff authored
      This change has 2 components:
      
      Target-independent: add a method getDwarfFrameBase to TargetFrameLowering. It
      describes how the Dwarf frame base will be encoded.  That can be a register (the
      default), the CFA (which replaces NVPTX-specific logic in DwarfCompileUnit), or
      a DW_OP_WASM_location descriptr.
      
      WebAssembly: Allow WebAssemblyFunctionInfo::getFrameRegister to return the
      correct virtual register instead of FP32/SP32 after WebAssemblyReplacePhysRegs
      has run.  Make WebAssemblyExplicitLocals store the local it allocates for the
      frame register. Use this local information to implement getDwarfFrameBase
      
      The result is that the DW_AT_frame_base attribute is correctly encoded for each
      subprogram, and each param and local variable has a correct DW_AT_location that
      uses DW_OP_fbreg to refer to the frame base.
      
      This is a reland of rG3a05c396 with fixes for the expensive-checks
      and Windows builds
      
      Differential Revision: https://reviews.llvm.org/D71681
      ff171acf
    • Frank Laub's avatar
      [MLIR] LLVM dialect: modernize and cleanups · ee2de955
      Frank Laub authored
      Summary:
      Modernize some of the existing custom parsing code in the LLVM dialect.
      While this reduces some boilerplate code, it also reduces the precision
      of the diagnostic error messges.
      
      Reviewers: ftynse, nicolasvasilache, rriddle
      
      Reviewed By: rriddle
      
      Subscribers: merge_guards_bot, mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, liufengdb, llvm-commits
      
      Tags: #llvm
      
      Differential Revision: https://reviews.llvm.org/D72967
      ee2de955
    • Matt Arsenault's avatar
    • Matt Arsenault's avatar
      Consolidate internal denormal flushing controls · a4451d88
      Matt Arsenault authored
      Currently there are 4 different mechanisms for controlling denormal
      flushing behavior, and about as many equivalent frontend controls.
      
      - AMDGPU uses the fp32-denormals and fp64-f16-denormals subtarget features
      - NVPTX uses the nvptx-f32ftz attribute
      - ARM directly uses the denormal-fp-math attribute
      - Other targets indirectly use denormal-fp-math in one DAGCombine
      - cl-denorms-are-zero has a corresponding denorms-are-zero attribute
      
      AMDGPU wants a distinct control for f32 flushing from f16/f64, and as
      far as I can tell the same is true for NVPTX (based on the attribute
      name).
      
      Work on consolidating these into the denormal-fp-math attribute, and a
      new type specific denormal-fp-math-f32 variant. Only ARM seems to
      support the two different flush modes, so this is overkill for the
      other use cases. Ideally we would error on the unsupported
      positive-zero mode on other targets from somewhere.
      
      Move the logic for selecting the flush mode into the compiler driver,
      instead of handling it in cc1. denormal-fp-math/denormal-fp-math-f32
      are now both cc1 flags, but denormal-fp-math-f32 is not yet exposed as
      a user flag.
      
      -cl-denorms-are-zero, -fcuda-flush-denormals-to-zero and
      -fno-cuda-flush-denormals-to-zero will be mapped to
      -fp-denormal-math-f32=ieee or preserve-sign rather than the old
      attributes.
      
      Stop emitting the denorms-are-zero attribute for the OpenCL flag. It
      has no in-tree users. The meaning would also be target dependent, such
      as the AMDGPU choice to treat this as only meaning allow flushing of
      f32 and not f16 or f64. The naming is also potentially confusing,
      since DAZ in other contexts refers to instructions implicitly treating
      input denormals as zero, not necessarily flushing output denormals to
      zero.
      
      This also does not attempt to change the behavior for the current
      attribute. The LangRef now states that the default is ieee behavior,
      but this is inaccurate for the current implementation. The clang
      handling is slightly hacky to avoid touching the existing
      denormal-fp-math uses. Fixing this will be left for a future patch.
      
      AMDGPU is still using the subtarget feature to control the denormal
      mode, but the new attribute are now emitted. A future change will
      switch this and remove the subtarget features.
      a4451d88
    • Matt Arsenault's avatar
      AMDGPU/GlobalISel: Select llvm.amdgcn.update.dpp · 592de000
      Matt Arsenault authored
      The existing test is overly reliant on -mattr=-flat-for-global, and
      some missing optimizations to re-use.
      592de000
    • Matt Arsenault's avatar
      ec962831
    • Reid Kleckner's avatar
      Remove unneeded FoldingSet.h include from Attributes.h · 423e3db6
      Reid Kleckner authored
      Avoids 637 extra FoldingSet.h and Allocator.h includes. FoldingSet.h
      needs Allocator.h, which is relatively expensive.
      423e3db6