Skip to content
GitLab
  1. Mar 03, 2020
    • Mitch Phillips's avatar
      Revert "Syndicate, test and fix base64 implementation" · 49684f9d
      Mitch Phillips authored 
      This reverts commit 5a1958f2.

This change broke the UBSan build bots. See
https://reviews.llvm.org/D75057 for more information.
      49684f9d
    • Mitch Phillips's avatar
      Revert "Fix Base64Test - for StringRef size" · 21e83244
      Mitch Phillips authored 
      This reverts commit b52355f8.

The change this patch depends on
(5a1958f2) broke the UBSan buildbots.
See https://reviews.llvm.org/D75057 for more information.
      21e83244
    • Teresa Johnson's avatar
      [ThinLTO/LowerTypeTests] Handle unpromoted local type ids · 873c0d07
      Teresa Johnson authored 
      Summary:
Fixes an issue that cropped up after the changes in D73242 to delay
the lowering of type tests. LTT couldn't handle any type tests with
non-string type id (which happens for local vtables, which we try to
promote during the compile step but cannot always when there are no
exported symbols).

We can simply treat the same as having an Unknown resolution, which
delays their lowering, still allowing such type tests to be used in
subsequent optimization (e.g. planned usage during ICP). The final
lowering which simply removes these handles them fine.

Beefed up an existing ThinLTO test for such unpromoted type ids so that
the internal vtable isn't removed before lower type tests, which hides
the problem.

Reviewers: evgeny777, pcc

Subscribers: inglorion, hiraditya, steven_wu, dexonsmith, aganea, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D75201
      873c0d07
    • Matthias Kramm's avatar
      [mlir][DialectConversion] Abort early if a subregion has a disconnected CFG. · 7a25bd1d
      Matthias Kramm authored 
      Summary:
Make computeConversionSet bubble up errors from nested regions. Note
that this doesn't change top-level behavior - since the nested region
calls emitError, the error was visible before, just not surfaced as
quickly.

Differential Revision: https://reviews.llvm.org/D75369
      7a25bd1d
    • Vedant Kumar's avatar
      Second attempt to disable instrprof-merging.cpp · 806bb1e0
      Vedant Kumar authored 
      The first attempt in f82ae3ad was not handled correctly, as
'UNSUPPORTED: *' is not accepted by lit.
      806bb1e0
    • River Riddle's avatar
      [mlir] Update several usages of IntegerType to properly handled unsignedness. · de5a81b1
      River Riddle authored 
      Summary: For example, DenseElementsAttr currently does not properly round-trip unsigned integer values.

Differential Revision: https://reviews.llvm.org/D75374
      de5a81b1
    • Volkan Keles's avatar
      GlobalISel: Move Localizer::shouldLocalize(..) to TargetLowering · 4167645d
      Volkan Keles authored 
      Add a new target hook for shouldLocalize so that
targets can customize the logic.

https://reviews.llvm.org/D75207
      4167645d
    • Arkady Shlykov's avatar
      [Loop Peeling] Add possibility to enable peeling on loop nests. · 3dcaf296
      Arkady Shlykov authored 
      Summary:
Current peeling implementation bails out in case of loop nests.
The patch introduces a field in TargetTransformInfo structure that
certain targets can use to relax the constraints if it's
profitable (disabled by default).
Also additional option is added to enable peeling manually for
experimenting and testing purposes.

Reviewers: fhahn, lebedev.ri, xbolva00

Reviewed By: xbolva00

Subscribers: RKSimon, xbolva00, hiraditya, zzheng, llvm-commits

Differential Revision: https://reviews.llvm.org/D70304
      3dcaf296
    • Nicolas Vasilache's avatar
      [mlir] Add padding to 1-D Vector in CRunnerUtils.h · 78f9e5d0
      Nicolas Vasilache authored 
      Summary:
This revision adds padding for 1-D Vector in the common case of x86
execution with a stadard data layout. This supports properly interfacing
codegen with arrays of e.g. `vector<9xf32>`.

Such vectors are already assumed padded to the next power of 2 by LLVM
codegen with the default x86 data layout:
```
define void @test_vector_add_1d_2_3(<3 x float>* nocapture readnone %0,
<3 x float>* nocapture readonly %1, i64 %2, i64 %3, i64 %4, <3 x float>*
nocapture readnone %5, <3 x float>* nocapture readonly %6, i64 %7, i64
%8, i64 %9, <3 x float>* nocapture readnone %10, <3 x float>* nocapture
%11, i64 %12, i64 %13, i64 %14) local_unnamed_addr {
  %16 = getelementptr <3 x float>, <3 x float>* %6, i64 1
  %17 = load <3 x float>, <3 x float>* %16, align 16
  %18 = getelementptr <3 x float>, <3 x float>* %1, i64 1
  %19 = load <3 x float>, <3 x float>* %18, align 16
  %20 = fadd <3 x float> %17, %19
  %21 = getelementptr <3 x float>, <3 x float>* %11, i64 1
```

The pointer addressing a `vector<3xf32>` is assumed aligned `@16`.
Similarly, the pointer addressing a `vector<65xf32>` is assumed aligned
`@512`.

This revision allows using objects such as `vector<3xf32>` properly with
the standard x86 data layout used in the JitRunner. Integration testing
is done out of tree, at the moment such testing fails without this
change.

Reviewers: ftynse

Subscribers: mehdi_amini, rriddle, jpienaar, burmako, shauheen, antiagainst, arpith-jacob, mgester, lucyrfox, liufengdb, Joonsoo, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D75459
      78f9e5d0
  3. Mar 02, 2020