- Sep 01, 2020
-
-
Yang Fan authored
Function Sema::isOpenMPGlobalCapturedDecl() has a parameter `unsigned Level`, but use `Level >= 0` as the condition of `while`, thus cause an infinite loop. Fix by changing the loop condition to `Level > 0`. Reviewed By: ABataev Differential Revision: https://reviews.llvm.org/D86858
-
Vitaly Buka authored
-
Xing GUO authored
This patch adds tests for dumping the .debug_line_str section. The dumper of the debug_line_str section is able to write nonprintable strings as escaped chars while the dumper of the debug_str and debug_str.dwo sections cannot. I will fix them and add tests for them in a follow-up patch. Reviewed By: jhenderson Differential Revision: https://reviews.llvm.org/D86916
-
David Nicuesa authored
Fix compilation of libcxx when using -DLIBCXX_BUILD_EXTERNAL_THREAD_LIBRARY. Target `cxx_external_threads` gets linked to `cxx-headers` to include all needed headers and flags. Reviewed By: #libc, ldionne Differential Revision: https://reviews.llvm.org/D86773
-
Georgii Rymar authored
`amdgpu-elf-definitions.test` is a file that tests `Format`, 'OS/ABI' and 'Machine' fields printed for EM_AMDGPU. It uses a precompiled object. It is not needed to have it, because: 1) We already test formats in `file-header-format.test` + `llvm/unittests/Object/ELFObjectFileTest.cpp`. 2) We test 'OS/ABI' in `file-header-os-abi.test` for all possible values. 3) We test machine types in `file-header-machine-types.test` In addition we have `amdgpu-elf-headers.test` which tests EM_AMDGPU specific flags. I.e. it also tests the fact that llvm-readobj/elf are able to dump such objects. This patch removes the test case and the corresponding binary. Differential revision: https://reviews.llvm.org/D86774
-
Georgii Rymar authored
Addresses post commit review comment for D86771.
-
Georgii Rymar authored
This replaces `reportError` calls with `reportUniqueWarning` and improves testing for the code that is related to stack sizes dumping. Differential revision: https://reviews.llvm.org/D86783
-
Sourabh Singh Tomar authored
-
Raphael Isemann authored
This reverts commit 297f69af. It broke the Fedora 33 x86-64 bot. See the review for more info.
-
Gabor Marton authored
By using optionals, we no longer have to check the validity of types that we get from a lookup. This way, the definition of the summaries have a declarative form, there are no superflous conditions in the source code. Differential Revision: https://reviews.llvm.org/D86531
-
David Sherwood authored
I have fixed up a number of warnings resulting from TypeSize -> uint64_t casts and calling getVectorNumElements() on scalable vector types. I think most of the changes are fairly trivial except for those in DAGTypeLegalizer::SplitVecRes_MLOAD I've tried to ensure we create the MachineMemoryOperands in a sensible way for scalable vectors. I have added a CHECK line to the following test: CodeGen/AArch64/sve-split-load.ll that ensures no new warnings are added. Differential Revision: https://reviews.llvm.org/D86697
-
David Green authored
Expensive checks are failing, complaining about additional MMO operands added to the branch.
-
Richard Smith authored
-Wtautological-unsigned-zero-compare not under -Wtautological-value-range-compare.
-
Richard Smith authored
Continue to heuristically pick the wider of the two operands for narrowing conversion warnings so that some_char + 1 isn't treated as being wider than a char, but use the more accurate computation for tautological comparison warnings. Differential Revision: https://reviews.llvm.org/D85778
-
Max Kazantsev authored
-
Richard Smith authored
-frewrite-includes. Remove the special-case (and highly implausible) diagnostic for a compound token that crosses a file boundary, and instead model that case the same as a compound token separated by whitespace, so that file transitions and presumed file transitions behave the same way.
-
Richard Smith authored
Use of a linebreak between the `(` and `{` in a GNU statement-expression appears to be too common to include this warning in -Wall -- this occurs in some Linux kernel headers, for example. -
Petr Hosek authored
Currently it is hard to avoid having LLVM link to the system install of ncurses, since it uses check_library_exists to find e.g. libtinfo and not find_library or find_package. With this change the ncurses lib is found with find_library, which also considers CMAKE_PREFIX_PATH. This solves an issue for the spack package manager, where we want to use the zlib installed by spack, and spack provides the CMAKE_PREFIX_PATH for it. This is a similar change as https://reviews.llvm.org/D79219, which just landed in master. Patch By: haampie Differential Revision: https://reviews.llvm.org/D85820
-
Alina Sbirlea authored
MemoryPhis with a single value are correct, but can lead to errors when updating. Clean up single entry Phis newly added when cloning blocks. Resolves PR46574.
-
Xing GUO authored
This patch makes the debug_str section optional. When the debug_str section exists but doesn't contain anything, yaml2obj will emit a section header for it. Reviewed By: grimar Differential Revision: https://reviews.llvm.org/D86860
-
Hamilton Tobon Mosquera authored
-
Valentin Clement authored
This patch add the missing operands to the acc.loop operation. Only the device_type information is not part of the operation for now. Reviewed By: rriddle, kiranchandramohan Differential Revision: https://reviews.llvm.org/D86753
-
peter klausler authored
Specifically, ensure that initializers conform with their objects according to 8.2 para 4. Differential Revision: https://reviews.llvm.org/D86886
-
Mehdi Amini authored
Clients who rely on the Context loading dialects from the global registry can call `mlir::enableGlobalDialectRegistry(true);` before creating an MLIRContext Differential Revision: https://reviews.llvm.org/D86897
-
Christopher Tetreault authored
Differential Revision: https://reviews.llvm.org/D86898
-
peter klausler authored
Change the expression representation TypeParamInquiry from being a class that's templatized on the integer KIND of its result into a monomorphic representation that results in a SubscriptInteger that can then be converted. This is a minor simplification, but it's worth doing because it is believed to also be a work-around for bugs in the MSVC compiler with overload resolution that affect the expression traversal framework. Differential Revision: https://reviews.llvm.org/D86551
-
Lang Hames authored
The unused Main variable was accidentally left in an earlier commit.
-
Jonas Devlieghere authored
Add a reproducer verifier that catches: - Missing or invalid home directory - Missing or invalid working directory - Missing or invalid module/symbol paths - Missing files from the VFS The verifier is enabled by default during replay, but can be skipped by passing --reproducer-no-verify. Differential revision: https://reviews.llvm.org/D86497
-
Christopher Tetreault authored
getNumElements() is being removed from base VectorType in order to eliminate the class of bugs in which a scalable vector is accidentally treated like a fixed length vector. Clients of this function should either call getElementCount(), and handle the case where getElementCount().isScalable() is true, or they can cast to FixedVectorType and call getNumElements() if they are sure that the vector has fixed width. Deprecated VectorType functions will be removed after the LLVM 12 branch. See: http://lists.llvm.org/pipermail/llvm-dev/2020-March/139811.html Reviewed By: fpetrogalli Differential Revision: https://reviews.llvm.org/D78127
-
Hubert Tong authored
Speculative fix for `-Werror,-Wsuggest-override` build failures on the ppc64le-lld-multistage-test bot.
-
peter klausler authored
Compilation of the following program currently generates a warning message: i = 1 if (i .eq. 0) then write(6, 200) i 200 format (I8) end if write(6, 200) i end x.f90:6:9: Label '200' is not in scope write(6, 200) i ^^^^^^^^^^^^^^^ Whereas branch targets must conform to the Clause 11.1.2.1 program requirement "Transfer of control to the interior of a block from outside the block is prohibited, ...", this doesn't apply to format statement references. -
Hamilton Tobon Mosquera authored
getValuesInOffloadArrays goes through the offload arrays in __tgt_target_data_begin_mapper getting the values stored in them before the call is issued. call void @__tgt_target_data_begin_mapper(arg0, arg1, i8** %offload_baseptrs, i8** %offload_ptrs, i64* %offload_sizes, ...) Diferential Revision: https://reviews.llvm.org/D86300 -
River Riddle authored
This is possible now that the declarative assembly form supports regions. Differential Revision: https://reviews.llvm.org/D86830
-
River Riddle authored
This adds some initial support for regions and does not support formatting the specific arguments of a region. For now this can be achieved by using a custom directive that formats the arguments and then parses the region. Differential Revision: https://reviews.llvm.org/D86760
-
River Riddle authored
Symbol names are a special form of StringAttr that get treated specially in certain areas, such as formatting. This revision adds a special derived attr for them in ODS and adds support in the assemblyFormat for formatting them properly. Differential Revision: https://reviews.llvm.org/D86759
-
River Riddle authored
This revision adds support for custom directives to the declarative assembly format. This allows for users to use C++ for printing and parsing subsections of an otherwise declaratively specified format. The custom directive is structured as follows: ``` custom-directive ::= `custom` `<` UserDirective `>` `(` Params `)` ``` `user-directive` is used as a suffix when this directive is used during printing and parsing. When parsing, `parseUserDirective` will be invoked. When printing, `printUserDirective` will be invoked. The first parameter to these methods must be a reference to either the OpAsmParser, or OpAsmPrinter. The type of rest of the parameters is dependent on the `Params` specified in the assembly format. Differential Revision: https://reviews.llvm.org/D84719
-
Arthur Eubanks authored
Fixes C:\src\llvm-project\llvm\docs\CommandGuide\FileCheck.rst:745:Bullet list ends without a blank line; unexpected unindent.
-
Craig Topper authored
-
Sanjay Patel authored
The 1st try was reverted because I missed an assert that needed softening. As discussed in D86798 / rG09652721 , we were potentially returning a different result for whether an Instruction is commutable depending on if we call the base class or derived class method. This requires relaxing asserts in GVN, but that pass seems to be working otherwise. NewGVN requires more work because it uses different code paths for numbering binops and calls.
-
Christopher Tetreault authored
Reviewed By: efriedma Differential Revision: https://reviews.llvm.org/D82237
-