- May 05, 2020
-
-
Stephen Neuendorffer authored
Portions of MLIR which depend on LLVMIR generally need to depend on intrinsics_gen, to ensure that tablegen'd header files from LLVM are built first. Without this, we get errors, typically about llvm/IR/Attributes.inc not being found. Note that previously the Linalg Dialect depended on intrinsics_gen, but it doesn't need to, since it doesn't use LLVMIR. Differential Revision: https://reviews.llvm.org/D79389
-
Jonas Devlieghere authored
This patch threads the virtual file system through dsymutil. Currently there is no good way to find out exactly what files are necessary in order to reproduce a dsymutil link, at least not without knowledge of how dsymutil's internals. My motivation for this change is to add lightweight "reproducers" that automatically gather the input object files through the FileCollectorFileSystem. The files together with the YAML mapping will allow us to transparently reproduce a dsymutil link, even without having to mess with the OSO path prefix. Differential revision: https://reviews.llvm.org/D79376
-
River Riddle authored
This revision adds support for merging identical blocks, or those with the same operations that branch to the same successors. Operands that mismatch between the different blocks are replaced with new block arguments added to the merged block. Differential Revision: https://reviews.llvm.org/D79134
-
Geoffrey Martin-Noble authored
This change removes tabs from the comments printed by the asmprinter after basic block declarations in favor of two spaces. This is currently the only place in the printed IR that uses tabs. Differential Revision: https://reviews.llvm.org/D79377
-
Sergey Dmitriev authored
Summary: Otherwise we can get unaccounted references to call graph nodes. Reviewers: jdoerfert, sstefan1 Reviewed By: jdoerfert Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D79382
-
Yaxun (Sam) Liu authored
union ctor does not call ctors of its data members. union dtor does not call dtors of its data members. Also union does not have base class. Currently when clang checks whether union has an empty ctor/dtor, it checks the ctors/dtors of its data members. This causes incorrectly diagnose device side global variables and shared variables as having non-empty ctors/dtors. This patch fixes that. Differential Revision: https://reviews.llvm.org/D79367
-
Zakk Chen authored
Summary: That unless the user requested an output object (--lto-obj-path), the an unused empty combined module is not emitted. This changed is helpful for some target (ex. RISCV-V) which encoded the ABI info in IR module flags (target-abi). Empty unused module has no ABI info so the linker would get the linking error during merging incompatible ABIs. Reviewers: tejohnson, espindola, MaskRay Subscribers: emaste, inglorion, arichardson, hiraditya, simoncook, MaskRay, steven_wu, dexonsmith, PkmX, dang, lenary, s.egerton, luismarques, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D78988
-
Adrian Prantl authored
-
Nicolas Vasilache authored
Summary: In the particular case of an insertion in a block without a terminator, the BlockBuilder insertion point should be block->end(). Adding a unit test to exercise this. Differential Revision: https://reviews.llvm.org/D79363
-
River Riddle authored
This allows for walking the operations nested directly within a region, without traversing nested regions. Differential Revision: https://reviews.llvm.org/D79056
-
River Riddle authored
This removes the unnecessary/costly context synchronization when parsing, as the context is guaranteed to not be used by any other threads.
-
Reid Kleckner authored
It looks like the new implementation is correct, since there were TODOs here about getting the new behavior. I am not sure if "C:..\.." should become "C:" or "C:\", though. The new output doesn't precisely match the TODO message, but it seems appropriate given the specification of remove_dots and how .. traversals work at the root directory.
-
Lang Hames authored
Refering to the link order of a dylib better matches the terminology used in static compilation. As upcoming patches will increase the number of places where link order matters (for example when closing JITDylibs) it's better to get this name change out of the way early.
-
Reid Kleckner authored
This reverts commit fb5fd746. Re-instates commit 53913a65 The fix is to trim off trailing separators, as in `/foo/bar/` and produce `/foo/bar`. VFS tests rely on this. I added unit tests for remove_dots.
-
Reid Kleckner authored
Profiling shows that time is spent destroying the allocator member of PDBLinker, and that is unneeded.
-
Hanhan Wang authored
Summary: As D78974, this patch implements the emulation for store op. The emulation is done with atomic operations. E.g., if the storing value is i8, rewrite the StoreOp to: 1) load a 32-bit integer 2) clear 8 bits in the loading value 3) store 32-bit value back 4) load a 32-bit integer 5) modify 8 bits in the loading value 6) store 32-bit value back The step 1 to step 3 are done by AtomicAnd as one atomic step, and the step 4 to step 6 are done by AtomicOr as another atomic step. Differential Revision: https://reviews.llvm.org/D79272
-
Haruki Imai authored
This std::copy_n copies 8 byte data (APInt raw data) by 1 byte from the beginning of char array. This is no problem in little endian, but the data is not copied correctly in big endian because the data should be copied from the end of the char array. - Example of 4 byte data (such as float32) Little endian (First 4 bytes): Address | 0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 Data | 0xcd 0xcc 0x8c 0x3f 0x00 0x00 0x00 0x00 Big endian (Last 4 bytes): Address | 0x01 0x02 0x03 0x04 0x05 0x06 0x07 0x08 Data | 0x00 0x00 0x00 0x00 0x3f 0x8c 0xcc 0xcd In general, when it copies N(N<8) byte data in big endian, the start address should be incremented by (8 - N) bytes. The original code has no problem when it includes 8 byte data(such as double) even in big endian. Differential Revision: https://reviews.llvm.org/D78076
-
Fangrui Song authored
We currently only support extern relocations. `X86_64_RELOC_SIGNED_{1,2,4}` are like X86_64_RELOC_SIGNED, but with the implicit addend fixed to 1, 2, and 4, respectively. See the comment in `lib/Target/X86/MCTargetDesc/X86MachObjectWriter.cpp RecordX86_64Relocation`. Reviewed By: int3 Differential Revision: https://reviews.llvm.org/D79311 -
Krzysztof Parzyszek authored
Register live ranges may have had gaps that after coalescing should be removed. This is done by adding a new segment to the range, and merging it with neighboring segments. When doing so, do not assume that each subrange of the register ended at the same index. If a subrange ended earlier, adding this segment could make the live range invalid. Instead, if the subrange is not live at the start of the segment, extend it first.
-
Vedant Kumar authored
Allow Language() to be called from const methods within UserExpression.
-
Jonas Devlieghere authored
Fix warning: ISO C++ requires the name after '::~' to be found in the same scope as the name before '::~' [-Wdtor-name]
-
Sanjay Patel authored
D79360 could change this kind of sequence.
-
Davide Italiano authored
Debug info generation & codegen now steps onto the correct line.
-
Stephen Neuendorffer authored
Previous patch broken flang, which has some yet-to-be resolved cyclic dependencies. This patch fixes the breakage by restricting the dependencies which are generated to public libraries, which is probably more sensible anyway. Differential Revision: https://reviews.llvm.org/D79366
-
Vedant Kumar authored
Summary: Languages can have different ways of formatting special characters. E.g. when debugging C++ code a string might look like "\b", but when debugging Swift code the same string would look like "\u{8}". To make this work, plugins override GetStringPrinterEscapingHelper. However, because there's a large amount of subtly divergent work done in each override, we end up with large amounts of duplicated code. And all the memory smashers fixed in one copy of the logic (see D73860) don't get fixed in the others. IMO the GetStringPrinterEscapingHelper is overly general and hard to use. I propose deleting it and replacing it with an EscapeStyle enum, which can be set as needed by each plugin. A fix for some swift-lldb memory smashers falls out fairly naturally from this deletion (https://github.com/apple/llvm-project/pull/1046). As the swift logic becomes really tiny, I propose moving it upstream as part of this change. I've added unit tests to cover it. rdar://61419673 Reviewers: JDevlieghere, davide Subscribers: mgorny, lldb-commits Tags: #lldb Differential Revision: https://reviews.llvm.org/D77843 -
Vedant Kumar authored
This reverts commit 88d9e432. Revert an accidental commit.
-
Vedant Kumar authored
Allow Language() to be called from const methods within UserExpression.
-
Vedant Kumar authored
Summary: Constrain which metadata nodes are allowed to be, or contain, DILocations. This ensures that logic for updating DILocations in a Module is complete. Currently, !llvm.loop metadata is the only odd duck which contains nested DILocations. This has caused problems in the past: some passes forgot to visit the nested locations, leading to subtly broken debug info and late verification failures. If there's a compelling reason for some future metadata to nest DILocations, we'll need to introduce a generic API for updating the locations attached to an Instruction before relaxing this check. Reviewers: aprantl, dsanders Subscribers: hiraditya, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D79245
-
shafik authored
The overloaded new operator in TestCppOperators.py are working by accident because of how we currently deal with artificial methods. Differential Revision: https://reviews.llvm.org/D79251
-
David Green authored
-
Dan Liew authored
It looks like some bots are failing with os log not giving any output. This might be due to the system under test being heavy load so the 2 minute window might not be large enough. This patch makes the window larger in the hope that this test will be more reliable. rdar://problem/62141527
-
Sander de Smalen authored
It seems this patch broke some buildbots, so reverting until I have had a chance to investigate. This reverts commit 6b90a688.
-
Erich Keane authored
There are some lookup oddities with these as reported in PR45780, and GCC doesn't support these behaviors at all. To be more consistent with GCC and prevent the crashes caused by our lookup issues, nip the problem in the bud and prohibit enums here.
-
Julian Lettner authored
abhinavgaba reported that that the custom-result-category.py test hangs on a Windows build bot [1]. Disable it for now. [1] https://reviews.llvm.org/D78164#2018178
-
Lang Hames authored
Also adds target_link_libraries. Thanks to @jcmac for spotting this.
-
Lang Hames authored
Thanks to @jcmac for pointing this out.
-
Stephen Neuendorffer authored
This reverts commit 4f0f4367. This seems to show some compile dependence problems, and also breaks flang.
-
Sander de Smalen authored
* svdupq builtins that duplicate scalars to every quadword of a vector are defined using builtins for svld1rq (load and replicate quadword). * svdupq builtins that duplicate boolean values to fill a predicate vector are defined using `svcmpne`. Reviewers: SjoerdMeijer, efriedma, ctetreau Reviewed By: efriedma Tags: #clang Differential Revision: https://reviews.llvm.org/D78750
-
Eli Friedman authored
If a varargs function is calling a non-varargs function, or vice versa, make sure we use the correct "varargs" bit for each. Fixes https://bugs.llvm.org/show_bug.cgi?id=45234 Differential Revision: https://reviews.llvm.org/D79199
-
Sanjay Patel authored
-