[lldb] Use LLVM's implementation of AppleTables for apple_debug_types
This commit is replacing really old LLDB code, and we've found some odd behavior while doing this replacement. While the changes here are largely NFC, there are some subtle changes that fix such odd behavior. The most curious example of this is the method `FindCompleteObjCClassName`, which has a flag `must_be_implementation`. This flag was _only_ being respected for accelerator tables containing the atom `type_flags`, which seems counter-intuitive. The implementation for DWARF 5 tables does not do that and neither does the code introduced in this patch. There were other weird cases, for example, we found boolean logic that was always true in a code path: look for a `if !has_qualified_name...` deleted line; that condition was true by simple if/else analysis. Differential Revision: https://reviews.llvm.org/D153867
parent
98390ccb
Please register or sign in to comment