Unverified Commit c458f928 authored by Duo Wang's avatar Duo Wang Committed by GitHub
Browse files

[NFC][clang][test][asan] Make `instantiation-depth-default.cpp` a valid test...

[NFC][clang][test][asan] Make `instantiation-depth-default.cpp` a valid test case under `asan` and `ubsan` configs (#75254)

Clang test `instantiation-depth-default.cpp` fails on Windows when built
with `ubsan` due to extra warnings printed by the compiler:
```console
File instantiation-depth-default.cpp Line 11: stack nearly exhausted; compilation time may suffer, and crashes due to stack overflow are likely
```
The test case was disabled for `asan` in 571a6478 because of the extra
stack usage. Since `ubsan` also increases stack usage, seems like the
two configs should be treated uniformly.

On the other hand, we might be able to re-enable this test case for
`asan`. During some preliminary testing on Windows, Linux, and macOS
with the host compiler being as old as clang-10, the test case exited
successfully if the `stack-exhausted` warnings are suppressed, though I
haven't done exhaustive testing across platforms and clang versions. Any
insights into whether this change will introduce any risks to existing
buildbots is appreciated.

Enabling this test case for `asan` helps to improve our test coverage,
but if it causes problems on any buildbot, marking it as unsupported for
`ubsan` is also a viable solution.
parent 0eefcaf9
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment