[mlir][NFC] modernize / clean up some loop transform utils, affine analysis utils

Summary:
- remove stale declarations on flat affine constraints
- avoid allocating small vectors where possible
- clean up code comments, rename some variables

Differential Revision: https://reviews.llvm.org/D76117