[lldb][Symtab][NFCI] Replace vector::swap with shrink_to_fit (#70918)

Replaces the old idiom (of swapping the container to shrink it) with the
newer STL alternative.

Similar transition in LLDB was done in: https://reviews.llvm.org/D47492