Unverified Commit 8fb28e45 authored by Kristof Beyls's avatar Kristof Beyls Committed by GitHub
Browse files

[BOLT] Fix data race in MCPlusBuilder::getOrCreateAnnotationIndex (#67004)



MCPlusBuilder::getOrCreateAnnotationIndex(Name) can be called from
different threads, for example when making use of
ParallelUtilities::runOnEachFunctionWithUniqueAllocId.

The race occurs when an Index for a particular annotation Name needs to
be created for the first time.

For example, this can easily happen when multiple "copies" of an
analysis pass run on different BinaryFunctions, and the analysis pass
creates a new Annotation Index to be able to store analysis results as
annotations.

This was found by using the ThreadSanitizer.

No regression test was added; I don't think there is good way to write
regression tests that verify the absence of data races?

---------

Co-authored-by: default avatarAmir Ayupov <fads93@gmail.com>
parent 3769aaaf
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment