Commit 6d4a3e91 authored by Tomas Matheson's avatar Tomas Matheson
Browse files

Revert "[TableGen] Use heap allocated arrays instead of vectors for...

Revert "[TableGen] Use heap allocated arrays instead of vectors for TreePatternNode::Types and ResultPerm. NFC"

While working on DAGISelMatcherEmitter I've hit several runtime errors
caused by accessing TreePatternNode::Types out of bounds. These were
difficult to debug because the switch from std::vector to unique_ptr
removes bounds checking.

I don't think the slight reduction in class size is worth the extra
debugging and memory safety problems, so I suggest we revert this.

This reverts commit d34125a1.

Differential Revision: https://reviews.llvm.org/D154781
parent 4c66b032
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment