Unverified Commit 5850f6ba authored by agozillon's avatar agozillon Committed by GitHub
Browse files

[Flang][OpenMP] Parse and semantically analyze common blocks in map clauses correctly (#89847)

Currently, you cannot provide the common block syntax that you should be
able to provide for map clauses (and that you can for declare target)
e.g.:

` !$omp target map(tofrom: /var/)`

This PR seeks to change that and allow this syntax via a small tweak,
which may also allow a wider range of types to be provided without issue
as well via the utilisation of ResolveOmpObject a helper function used
by the majority of other OmpObject handling clauses.

A by product of this change, is that we now emit an error for the
following syntax, when provided to map clauses with an assumed size
array:

`!$omp target map(arr(:))`

This seems inline with the specification from what I understand of it
(do feel free to correct me if that is not your reading or I am
incorrect!) and other OpenMP compilers i.e. gfortran, ifx, ifort.
parent 91446e2a
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment