Commit 480a10c4 authored by Christian Ulmann's avatar Christian Ulmann
Browse files

[MLIR][LLVM] Remove the type consistency pass

This commit removes the LLVM dialect's type consistency pass. This pass
was originally introduced to make type information on memory operations
consistent. The main benefactor of this consistency where Mem2Reg and
SROA, which were in the meantime improved to no longer require consitent
type information.

Appart from providing a no longer required functionality, the pass had
some fundamental flaws that lead to issues:
* It introduced trivial GEPs (only zero indices) that could fold be
  folded again.
* Aggressively splitting stores lead to substantial performance
  regressions in some cases. Subsequent memory coalescings were not
  able to recover this information, due to using non-trivial
  bit-fiddling.
parent 1cf75cc7
Pipeline #2632 failed with stages
in 0 seconds
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment