[clang][Sema][NFC] Clean up ShouldDiagnoseUnusedDecl

Const qualify a few locals, merge two if statements and use
dyn_cast_if_present instead of _or_null.