[MachineBasicBlock] Fix SlotIndexUpdater for insertion order (#69424)

Follow up fix for #68786 to address that MachineFunction handleInsertion
is actually called before a new instruction has been inserted into the
block. Hence new instructions must be recorded and SlotIndex updates
performed after the delegate call.