Factor out duplication between lvalue-to-rvalue conversions and variable

assignments in constant expressions. No significant functionality changes
(slight improvement to potential constant expression checking). 

llvm-svn: 181170