This patch fixes my think-o in ValueObject::UpdateValueIfNeeded() about the right thing to assert()

It also comes with a (rudimentary) test case that gets itself in a failed update scenario, and checks that we don't crash
This is the easiest case I could think of that forces the failed update case Zachary was seeing

llvm-svn: 225463