- Aug 21, 2023
-
-
Luke D. Jones authored
After the addition of the mid fan custom curve functionality various incorrect behaviour was uncovered. This commit fixes these areas. - Ensure mid fan attributes actually use the correct fan ID - Correction to a bit mask for selecting the correct fan data - Refactor the curve show/store functions to be cleaner and match each others layout Fixes: 536fce82 ("platform/x86: asus-wmi: add support for showing middle fan RPM") Signed-off-by:
Luke D. Jones <luke@ljones.dev> Link: https://lore.kernel.org/r/20230815014209.44903-1-luke@ljones.dev Signed-off-by:
Hans de Goede <hdegoede@redhat.com> Reviewed-by:
-
Andy Shevchenko authored
We have a common helper to represent a boolean value as "on"/"off" string. Use it for the sake of the unified style. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by:
Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Reviewed-by:
Muhammad Usama Anjum <usama.anjum@collabora.com> Link: https://lore.kernel.org/r/20230811131330.71263-1-andriy.shevchenko@linux.intel.com Signed-off-by:
-
Ruan Jinjie authored
Use memdup_user_nul() helper instead of open-coding to simplify the code. Signed-off-by:
Ruan Jinjie <ruanjinjie@huawei.com> Link: https://lore.kernel.org/r/20230810122012.2110410-1-ruanjinjie@huawei.com Reviewed-by:
-
- Aug 14, 2023
-
-
Hans de Goede authored
-
Arnd Bergmann authored
The simatic-ipc driver no longer depends on PCI, but its watchdog portion still needs it, otherwise P2SB runs into a build failure: WARNING: unmet direct dependencies detected for P2SB Depends on [n]: PCI [=n] && X86 [=y] Selected by [m]: - SIEMENS_SIMATIC_IPC_WDT [=m] && WATCHDOG [=y] && SIEMENS_SIMATIC_IPC [=y] drivers/platform/x86/p2sb.c:121:3: error: call to undeclared function 'pci_bus_write_config_dword'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] pci_bus_write_config_dword(bus, devfn_p2sb, P2SBC, 0); Add back the minimum dependendency to make it build in random configurations again. Fixes: b72da71c ("platform/x86: simatic-ipc: drop PCI runtime depends and header") Signed-off-by:Arnd Bergmann <arnd@arndb.de> Reviewed-by:
Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/r/20230814073924.1066390-1-arnd@kernel.org Signed-off-by:
-
Gerd Haeussler authored
There are different IPC driver modules in the kernel that are actively maintained by Siemens but not yet listed in the MAINTAINERS file. Add the missing entries. Signed-off-by:
Gerd Haeussler <gerd.haeussler.ext@siemens.com> Acked-by:
-
- Aug 10, 2023
-
-
Hans de Goede authored
-
Asmaa Mnebhi authored
The BlueField has internal registers to store the ARM boot states. Support setting the BlueField ARM boot state to "OS up". Signed-off-by:
Asmaa Mnebhi <asmaa@nvidia.com> Reviewed-by:
Vadim Pasternak <vadimp@nvidia.com> Link: https://lore.kernel.org/r/20230809162857.21243-3-asmaa@nvidia.com Signed-off-by:
-
Asmaa Mnebhi authored
Enable reading and writing the size of the memory region associated with the large ICM carveout. The max size of the large ICM carveout is 1TB, has a granularity of 128MB and will be passed and printed in hex. The size unit is MB. Signed-off-by:
-
xingtong.wu authored
The variable "priv.devmode" is missing from if statement that leads to a logical error. Add the missing variable to the if condition. Fixes: c56beff2 ("platform/x86/siemens: simatic-ipc-batt: add support for module BX-59A") Reported-by:
kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202308010001.BGYCSQrl-lkp@intel.com/ Reviewed-by:
xingtong.wu <xingtong.wu@siemens.com> Link: https://lore.kernel.org/r/20430802173844.2483-1-xingtong_wu@163.com Signed-off-by:
-
xingtong.wu authored
The variable "ledmode" is missing from if statement that leads to a logical error. Add the missing variable to the if condition. Fixes: b8af7795 ("platform/x86/siemens: simatic-ipc: add new models BX-56A/BX-59A") Reported-by:
-
Yang Yingliang authored
Fix wrong pointer pass to PTR_ERR() if devm_gpiod_get_index() fails. Fixes: 917f5434 ("platform/x86: simatic-ipc: add CMOS battery monitoring") Signed-off-by:
Yang Yingliang <yangyingliang@huawei.com> Reviewed-by:
-
Armin Wolf authored
If a duplicate attribute is found using kset_find_obj(), a reference to that attribute is returned. This means that we need to dispose it accordingly. Use kobject_put() to dispose the duplicate attribute in such a case. Compile-tested only. Fixes: e8a60aa7 ("platform/x86: Introduce support for Systems Management Driver over WMI for Dell Systems") Signed-off-by:
Armin Wolf <W_Armin@gmx.de> Link: https://lore.kernel.org/r/20230805053610.7106-1-W_Armin@gmx.de Reviewed-by:
-
- Aug 09, 2023
-
-
Srinivas Pandruvada authored
This version addresses issues with: - CPU count display for power domain != 0 - Support more than 8 sockets - Error on max CPU count exceeds in one request - Prevent trying CPU 0 hotplug for kernel version 6.5 or later - Change mem-frequency display to max-mem-frequency Signed-off-by:Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
-
Srinivas Pandruvada authored
The mem-frequency displayed by each profile is not the actual memory frequency of DIMMs, but the maximum the CPU can support. Change the mem-frequency field to max-mem-frequency. Signed-off-by: -
Srinivas Pandruvada authored
Kernel 6.5 version deprecated CPU 0 hotplug. This will cause all requests to fail to offline CPU 0. Check version number of kernel and ignore CPU 0 hotplug request with debug aid to use cgroup isolation feature for CPU 0. Signed-off-by: -
Srinivas Pandruvada authored
There is a limit on number of CPUs in one request. This is set to 256. Currently tool silently ignores request for count over 256. Give an error message to indicate this. Signed-off-by: -
Frank Ramsay authored
MAX_PACKAGE_COUNT limits the intel-speed-select to systems with 8 sockets or fewer. On a system with more than 8 sockets intel-speed-select silently ignores everything beyond the 8th socket, rendering the tool useless for those systems. Increase MAX_PACKAGE_COUNT to support systems with up to 32 sockets. Signed-off-by:
Frank Ramsay <frank.ramsay@hpe.com> Signed-off-by:
-
Srinivas Pandruvada authored
Fix CPU count display for power domain != 0. In the function punit_id is always 0, so it never incremented cpu count for power domain id != 0. Update punit_id after call to update_punit_cpu_info() to what is actually received from the kernel. Signed-off-by:
-
- Aug 07, 2023
-
-
Li Zetao authored
There are some warnings reported by coccinelle: ./drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:317:35-42: WARNING opportunity for kmemdup ./drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:270:40-47: WARNING opportunity for kmemdup ./drivers/platform/x86/hp/hp-bioscfg/spmobj-attributes.c:233:36-43: WARNING opportunity for kmemdup Use kmemdup rather than duplicating its implementation. Signed-off-by:
Li Zetao <lizetao1@huawei.com> Reviewed-by:
Jorge Lopez <jorge.lopez2@hp.com> Link: https://lore.kernel.org/r/20230803032027.3044851-1-lizetao1@huawei.com Reviewed-by:
-
Jorge Lopez authored
Replace use of same variable in inner loop. Signed-off-by:
-
Jorge Lopez authored
Update steps how password encoding size is evaluated Signed-off-by:
-
Jorge Lopez authored
Updates steps how enum possible values size is evaluated Signed-off-by:
-
Jorge Lopez authored
Update steps how order list size is evaluated Signed-off-by:
-
Jorge Lopez authored
Update steps taken to evaluate prerequisites size value Signed-off-by:
-
Jorge Lopez authored
Replace the word 'HACK' with 'step' from source code Signed-off-by:
-
Jorge Lopez authored
Fix uninitialized variable errors. Signed-off-by:
-
Jorge Lopez authored
Address memory leaks while handling elements in packages. Signed-off-by:
-
- Jul 31, 2023
-
-
Armin Wolf authored
The WMI Binary MOF driver is important for the development of modern WMI drivers, i am willing to maintain it. Also fix the mailing list address. Signed-off-by:
-
Armin Wolf authored
Replace offset handling code with a single call to memory_read_from_buffer() to simplify read_bmof(). Tested on a ASUS PRIME B650-PLUS. Reviewed-by:
Thomas Weißschuh <linux@weissschuh.net> Tested-by:
-
Armin Wolf authored
Use device_create_bin_file() instead of sysfs_create_bin_file() to avoid having to access the device kobject. Tested on a ASUS PRIME B650-PLUS. Reviewed-by:
-
Hans de Goede authored
Immutable branch between pdx86 simatic branch and LED due for the v6.6 merge window ib-pdx86-simatic-v6.6-2: v6.5-rc1 + ib-pdx86-simatic-v6.6 + more recent pdx86 simatic-ipc patches for merging into the LED subsystem for v6.6.
-
xingtong.wu authored
This is used for the Siemens Simatic IPC BX-59A, which can monitor the voltage of the CMOS battery with two bits that indicate low or empty state Signed-off-by:
-
xingtong.wu authored
This adds support for the Siemens Simatic IPC models BX-56A/BX-59A, led/watchdog/battery on these models are same, actual drivers for models will be sent in separate patches. Signed-off-by:
-
Henning Schild authored
There was a copy and paste mistake where the module name was not correct. Fixes: 917f5434 ("platform/x86: simatic-ipc: add CMOS battery monitoring") Signed-off-by:
Henning Schild <henning.schild@siemens.com> Link: https://lore.kernel.org/r/20230725093113.9739-3-henning.schild@siemens.com Reviewed-by:
-
xingtong.wu authored
There was a case missing in a switch statement which lead to that model not actually reading the GPIOs. That switch statement got simplified now. Additionally on that model we need to initialize one pin differently. As a drive-by finding also add a missing newline. Fixes: 917f5434 ("platform/x86: simatic-ipc: add CMOS battery monitoring") Reported-by:
-
Henning Schild authored
With more files around move everything to a subdirectory. Users will only see the several options once they enable the main one. Suggested-by:
-
Henning Schild authored
If a user did choose to enable Siemens Simatic platform support they likely want the LED drivers to be enabled without having to flip more config switches. So we make the LED drivers config switch default to the platform driver switches value. Signed-off-by:
Lee Jones <lee@kernel.org> Link: https://lore.kernel.org/r/20230719153518.13073-3-henning.schild@siemens.com Signed-off-by:
-
Henning Schild authored
If a user did choose to enable Siemens Simatic platform support they likely want that driver to be enabled without having to flip more config switches. So we make the watchdog driver config switch default to the platform driver switches value. Signed-off-by:
-
- Jul 26, 2023
-
-
Dan Carpenter authored
Return a negative error code instead of returning success. Fixes: a34fc329 ("platform/x86: hp-bioscfg: bioscfg") Signed-off-by:
Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/138641cc-52c0-41a5-8176-ad01c7e28c67@moroto.mountain Reviewed-by:
-
