- Nov 07, 2021
-
-
Trond Myklebust authored
Ensure that the values supplied by the server do not exceed the size of the largest allowed slot table. Reported-by:
<rtm@csail.mit.edu> Signed-off-by:
Trond Myklebust <trond.myklebust@hammerspace.com>
-
- Nov 06, 2021
-
-
Anna Schumaker authored
Wa can check if the fattr has an allocated label when needed Signed-off-by:
Anna Schumaker <Anna.Schumaker@Netapp.com> Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Pull the label from the fattr instead. Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
Signed-off-by:
-
Anna Schumaker authored
And usethe fattr's label field instead. I also adjust function calls to remove labels along the way. Signed-off-by:
-
Anna Schumaker authored
Again, use the fattr's label field instead. Signed-off-by:
-
Anna Schumaker authored
Instead, use the label embedded in the attached fattr. Signed-off-by:
-
Anna Schumaker authored
And instead allocate the fattr using nfs_alloc_fattr_with_label() Signed-off-by:
-
Anna Schumaker authored
For creating fattrs with the label field already allocated for us. I also update nfs_free_fattr() to free the label in the end. Signed-off-by:
-
Trond Myklebust authored
We're about to add a check in nfs_free_fattr() for whether or not the label is non-zero. Signed-off-by: -
Trond Myklebust authored
Signed-off-by: -
Trond Myklebust authored
The preferred behaviour is always to allocate struct nfs_fattr from the slab. Signed-off-by: -
Trond Myklebust authored
It is completely redundant to the server capability check. Signed-off-by: -
Trond Myklebust authored
The return value of xdr_inline_decode() is not being checked, leading to a potential Oops. Just replace the open coded array decode with the generic XDR version. Reported-by:
-
Trond Myklebust authored
The server is supposed to return the same tag that the client sends in the outgoing RPC call, but we should still sanity check the length just in case. Reported-by:
-
Trond Myklebust authored
If fhandle is NULL or fattr is NULL, then 'error' is uninitialised. Reported-by:
Nathan Chancellor <nathan@kernel.org> Signed-off-by:
-
- Nov 05, 2021
-
-
Trond Myklebust authored
If we have already set up the socket and are waiting for it to connect, then don't immediately close and retry. Signed-off-by: -
Trond Myklebust authored
Ensure that we bump the xprt->connect_cookie when we set the XPRT_CLOSE_WAIT flag so that another call to xprt_conditional_disconnect() won't race with the reconnection. Signed-off-by: -
Olga Kornievskaia authored
Add tracepoint to OFFLOAD_CANCEL operation. Signed-off-by:
Olga Kornievskaia <kolga@netapp.com> Signed-off-by:
-
Olga Kornievskaia authored
Add a tracepoint to COPY_NOTIFY operation. Signed-off-by:
-
Olga Kornievskaia authored
Add a tracepoint to the CB_OFFLOAD operation. Signed-off-by:
-
Olga Kornievskaia authored
Add a tracepoint to the CLONE operation. Signed-off-by:
-
Olga Kornievskaia authored
Add a tracepoint to the COPY operation. Signed-off-by:
-
Olga Kornievskaia authored
Add a tracepoint to the FALLOCATE/DEALLOCATE operations. Signed-off-by:
-
Olga Kornievskaia authored
Add a tracepoint to the SEEK operation. Signed-off-by:
-
Anna Schumaker authored
xprts don't immediately reconnect when changing the "dstaddr" property, instead this gets handled the next time an operation uses the transport. This could lead to NULL pointer dereferences when trying to read sysfs files between the disconnect and reconnect operations. Fix this by returning an error if the xprt is not connected. Signed-off-by:
-
- Nov 03, 2021
-
-
Jonathan Corbet authored
Commit 19fcae3d ("scsi: remove the SCSI OSD library") deleted the last file that included <linux/pnfs_osd_xdr.h> but left that file behind. It's unused, get rid of it now. Cc: Christoph Hellwig <hch@lst.de> Cc: Trond Myklebust <trond.myklebust@hammerspace.com> Cc: Anna Schumaker <anna.schumaker@netapp.com> Cc: linux-nfs@vger.kernel.org Signed-off-by:
Jonathan Corbet <corbet@lwn.net> Signed-off-by:
-
Scott Mayhew authored
During umount, the session slot tables are freed. If there are outstanding FREE_STATEID tasks, a use-after-free and slab corruption can occur when rpc_exit_task calls rpc_call_done -> nfs41_sequence_done -> nfs4_sequence_process/nfs41_sequence_free_slot. Prevent that from happening by taking a reference on the nfs_client in nfs41_free_stateid and putting it in nfs41_free_stateid_release. Signed-off-by:
Scott Mayhew <smayhew@redhat.com> Signed-off-by:
-
Dave Wysochanski authored
Add the byte offset of the readahead request to the tracepoint output so we know where the read starts. Before this patch: cat-8104 [002] ..... 813.168775: nfs_aop_readahead: fileid=00:31:141 fhandle=0xe55807f6 version=1756509392533525500 nr_pages=256 cat-8104 [002] ..... 813.174973: nfs_aop_readahead_done: fileid=00:31:141 fhandle=0xe55807f6 version=1756509392533525500 nr_pages=256 ret=0 cat-8104 [002] ..... 813.175963: nfs_aop_readahead: fileid=00:31:141 fhandle=0xe55807f6 version=1756509392533525500 nr_pages=256 cat-8104 [002] ..... 813.183742: nfs_aop_readahead_done: fileid=00:31:141 fhandle=0xe55807f6 version=1756509392533525500 nr_pages=1 ret=0 After this patch: cat-6392 [001] ..... 73.107782: nfs_aop_readahead: fileid=00:31:141 fhandle=0xed22403f version=1756511950029502774 offset=5242880 nr_pages=256 cat-6392 [001] ..... 73.112466: nfs_aop_readahead_done: fileid=00:31:141 fhandle=0xed22403f version=1756511950029502774 nr_pages=256 ret=0 cat-6392 [001] ..... 73.115692: nfs_aop_readahead: fileid=00:31:141 fhandle=0xed22403f version=1756511950029502774 offset=6291456 nr_pages=256 cat-6392 [001] ..... 73.123283: nfs_aop_readahead_done: fileid=00:31:141 fhandle=0xed22403f version=1756511950029502774 nr_pages=256 ret=0 Signed-off-by:
Dave Wysochanski <dwysocha@redhat.com> Signed-off-by:
-
Benjamin Coddington authored
This minor fix-up keeps GCC from complaining that "last' may be used uninitialized", which breaks some build workflows that have been running with all warnings treated as errors. Signed-off-by:
Benjamin Coddington <bcodding@redhat.com> Signed-off-by:
-
Chuck Lever authored
Refactor: surface useful show_ macros so they can be shared between the client and server trace code. Additional clean up: - Housekeeping: ensure the correct #include files are pulled in and add proper TRACE_DEFINE_ENUM where they are missing - Use a consistent naming scheme for the helpers - Store values to be displayed symbolically as unsigned long, as that is the type that the __print_yada() functions take Signed-off-by:
Chuck Lever <chuck.lever@oracle.com> Signed-off-by:
-
Chuck Lever authored
Refactor: Surface useful show_ macros for use by other trace subsystems. Signed-off-by:
-
- Nov 01, 2021
-
-
Trond Myklebust authored
Move the error handling into a single switch statement for clarity. Signed-off-by: -
Trond Myklebust authored
Since we do things like setting flags, etc it really is more appropriate to use sock_lock(). Signed-off-by:
-
