- Aug 01, 2010
-
-
Avi Kivity authored
We drop the mmu lock between freeing memory and allocating the roots; this allows some other vcpu to sneak in and allocate memory. While the race is benign (resulting only in temporary overallocation, not oom) it is simple and easy to fix by moving the freeing close to the allocation. Signed-off-by:
Avi Kivity <avi@redhat.com> Signed-off-by:
Marcelo Tosatti <mtosatti@redhat.com>
-
Gleb Natapov authored
Do not kill VM when instruction emulation fails. Inject #UD and report failure to userspace instead. Userspace may choose to reenter guest if vcpu is in userspace (cpl == 3) in which case guest OS will kill offending process and continue running. Signed-off-by:
Gleb Natapov <gleb@redhat.com> Signed-off-by:
-
Avi Kivity authored
Signed-off-by: -
Avi Kivity authored
Signed-off-by: -
Gui Jianfeng authored
Currently, kvm_mmu_zap_page() returning the number of freed children sp. This might confuse the caller, because caller don't know the actual freed number. Let's make kvm_mmu_zap_page() return the number of pages it actually freed. Signed-off-by:
Gui Jianfeng <guijianfeng@cn.fujitsu.com> Signed-off-by:
-
Gui Jianfeng authored
Fix a debug output error in walk_addr Signed-off-by:
-
Gui Jianfeng authored
Sometime cmpxchg_gpte doesn't modify gpte, in such case, don't mark page table page as dirty. Signed-off-by:
-
Joerg Roedel authored
This patch enables setting of efer bit 13 which is allowed in all SVM capable processors. This is necessary for the SLES11 version of Xen 4.0 to boot with nested svm. Signed-off-by:
Joerg Roedel <joerg.roedel@amd.com> Signed-off-by:
-
Joerg Roedel authored
This patch adds a function to dump the vmcb into the kernel log and calls it after a failed vmrun to ease debugging. Signed-off-by:
-
Avi Kivity authored
KVM_REQ_KICK poisons vcpu->requests by having a bit set during normal operation. This causes the fast path check for a clear vcpu->requests to fail all the time, triggering tons of atomic operations. Fix by replacing KVM_REQ_KICK with a vcpu->guest_mode atomic. Signed-off-by: -
Gleb Natapov authored
Return exception as a result of instruction emulation and handle injection in KVM code. Signed-off-by:
-
Gleb Natapov authored
Emulator shouldn't access vcpu directly. Signed-off-by:
-
Gleb Natapov authored
Emulator shouldn't access vcpu directly. Signed-off-by:
-
Gleb Natapov authored
emulate_sysexit() should use shadowed registers copy instead of looking into vcpu state directly. Signed-off-by:
-
Gleb Natapov authored
Removes the need for set_flags() callback. Signed-off-by:
-
Gleb Natapov authored
Return new RIP as part of instruction emulation result instead of updating KVM's RIP from x86 emulator code. Signed-off-by:
-
Gleb Natapov authored
If emulation failed return immediately. Signed-off-by:
-
Gleb Natapov authored
Return error to x86 emulator instead of injection exception behind its back. Signed-off-by:
-
Gleb Natapov authored
It is not called directly outside of the file it's defined in anymore. Signed-off-by:
-
Gleb Natapov authored
Currently emulator returns -1 when emulation failed or IO is needed. Caller tries to guess whether emulation failed by looking at other variables. Make it easier for caller to recognise error condition by always returning -1 in case of failure. For this new emulator internal return value X86EMUL_IO_NEEDED is introduced. It is used to distinguish between error condition (which returns X86EMUL_UNHANDLEABLE) and condition that requires IO exit to userspace to continue emulation. Signed-off-by:
-
Gleb Natapov authored
Fill in run->mmio details in (read|write)_emulated function just like pio does. There is no point in filling only vcpu fields there just to copy them into vcpu->run a little bit later. Signed-off-by:
-
Gleb Natapov authored
Currently X86EMUL_PROPAGATE_FAULT, X86EMUL_RETRY_INSTR and X86EMUL_CMPXCHG_FAILED have the same value so caller cannot distinguish why function such as emulator_cmpxchg_emulated() (which can return both X86EMUL_PROPAGATE_FAULT and X86EMUL_CMPXCHG_FAILED) failed. Signed-off-by:
-
Gleb Natapov authored
Make (get|set)_dr() callback return error if it fails instead of injecting exception behind emulator's back. Signed-off-by:
-
Gleb Natapov authored
Make set_cr() callback return error if it fails instead of injecting #GP behind emulator's back. Signed-off-by:
-
Gleb Natapov authored
Use callbacks from x86_emulate_ops to access segments instead of calling into kvm directly. Signed-off-by:
-
Gleb Natapov authored
On VMX it is expensive to call get_cached_descriptor() just to get segment base since multiple vmcs_reads are done instead of only one. Introduce new call back get_cached_segment_base() for efficiency. Signed-off-by:
-
Gleb Natapov authored
Add (set|get)_msr callbacks to x86_emulate_ops instead of calling them directly. Signed-off-by:
-
Gleb Natapov authored
Add (set|get)_dr callbacks to x86_emulate_ops instead of calling them directly. Signed-off-by:
-
Gleb Natapov authored
ljmp/lcall instruction operand contains address and segment. It can be 10 bytes long. Currently we decode it as two different operands. Fix it by introducing new kind of operand that can hold entire far address. Signed-off-by:
-
Gleb Natapov authored
Make it more explicit what we are checking for. Signed-off-by:
-
Gleb Natapov authored
Dst operand is already initialized during decoding stage. No need to reinitialize. Signed-off-by:
-
Gleb Natapov authored
This instruction does not need generic decoding for its dst operand. Signed-off-by:
-
Gleb Natapov authored
Introduce read cache which is needed for instruction that require more then one exit to userspace. After returning from userspace the instruction will be re-executed with cached read value. Signed-off-by:
-
Avi Kivity authored
cr0.ts may change between entries, so we copy cr0 to HOST_CR0 before each entry. That is slow, so instead, set HOST_CR0 to have TS set unconditionally (which is a safe value), and issue a clts() just before exiting vcpu context if the task indeed owns the fpu. Saves ~50 cycles/exit. Signed-off-by: -
Avi Kivity authored
Annotate it thusly. Signed-off-by: -
Takuya Yoshikawa authored
Although we always allocate a new dirty bitmap in x86's get_dirty_log(), it is only used as a zero-source of copy_to_user() and freed right after that when memslot is clean. This patch uses clear_user() instead of doing this unnecessary zero-source allocation. Performance improvement: as we can expect easily, the time needed to allocate a bitmap is completely reduced. In my test, the improved ioctl was about 4 to 10 times faster than the original one for clean slots. Furthermore, reducing memory allocations and copies will produce good effects to caches too. Signed-off-by:
Takuya Yoshikawa <yoshikawa.takuya@oss.ntt.co.jp> Signed-off-by:
-
Avi Kivity authored
!! is not needed due to the cast to bool. Signed-off-by: -
Huang Ying authored
In common cases, guest SRAO MCE will cause corresponding poisoned page be un-mapped and SIGBUS be sent to QEMU-KVM, then QEMU-KVM will relay the MCE to guest OS. But it is reported that if the poisoned page is accessed in guest after unmapping and before MCE is relayed to guest OS, userspace will be killed. The reason is as follows. Because poisoned page has been un-mapped, guest access will cause guest exit and kvm_mmu_page_fault will be called. kvm_mmu_page_fault can not get the poisoned page for fault address, so kernel and user space MMIO processing is tried in turn. In user MMIO processing, poisoned page is accessed again, then userspace is killed by force_sig_info. To fix the bug, kvm_mmu_page_fault send HWPOISON signal to QEMU-KVM and do not try kernel and user space MMIO processing for poisoned page. [xiao: fix warning introduced by avi] Reported-by:
Max Asbock <masbock@linux.vnet.ibm.com> Signed-off-by:
Huang Ying <ying.huang@intel.com> Signed-off-by:
Xiao Guangrong <xiaoguangrong@cn.fujitsu.com> Signed-off-by:
-
- Jul 29, 2010
-
-
git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdbLinus Torvalds authored
* 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb: x86,kgdb: Fix hw breakpoint regression
-
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6Linus Torvalds authored
* git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6: [SCSI] ibmvscsi: Fix oops when an interrupt is pending during probe [SCSI] zfcp: Update status read mempool [SCSI] zfcp: Do not wait for SBALs on stopped queue [SCSI] zfcp: Fix check whether unchained ct_els is possible [SCSI] ipr: fix resource path display and formatting
-
