- Aug 12, 2015
-
-
Viresh Kumar authored
This is done from a common place now, no need to replicate it. Signed-off-by:
Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by:
Greg Kroah-Hartman <gregkh@google.com>
-
Viresh Kumar authored
This is done from a common place now, no need to replicate it. Signed-off-by:
-
Viresh Kumar authored
This is done from a common place now, no need to replicate it. Signed-off-by:
-
Viresh Kumar authored
This is done from a common place now, no need to replicate it. Signed-off-by:
-
Viresh Kumar authored
This is done from a common place now, no need to replicate it. Signed-off-by:
-
Viresh Kumar authored
This is done from a common place now, no need to replicate it. Signed-off-by:
-
Viresh Kumar authored
This is done from a common place now, no need to replicate it. Signed-off-by:
-
Viresh Kumar authored
This is done from a common place now, no need to replicate it. Signed-off-by:
-
Viresh Kumar authored
This is done from a common place now, no need to replicate it. Signed-off-by:
-
Viresh Kumar authored
This can (should) be done from a common place as its required for most of the protocols. Do it. Signed-off-by:
-
Viresh Kumar authored
Save major/minor number supported by the module inside connection structure, as this can be used later. Signed-off-by:
-
Viresh Kumar authored
Some request numbers (like invalid and get_version) are same across all protocols. Create common macros for them. Signed-off-by:
-
Viresh Kumar authored
Its possible for connection_init() to fail, in such cases the disconnected event must be sent to the module. It is missing currently, fix it. Signed-off-by:
-
Viresh Kumar authored
!= was used in place of <, while comparing expected and actual payload size. The module may be running a higher version of the protocol and might have some extra fields (towards the end) in the structure, and the AP needs to ignore them. This also updates the print (expected-payload-size < actual-payload-size), when the size doesn't match for requests received by the module. This gives more details required for debugging. Signed-off-by:
-
Viresh Kumar authored
This increases readability a bit more, as it tells which value is actual size and which one is expected size. Signed-off-by:
-
Viresh Kumar authored
Its handled by the firmware driver now, drop the FIXME comment from svc code. Signed-off-by:
-
- Aug 11, 2015
-
-
Viresh Kumar authored
We already have macros for these, use them instead of writing fixed values. Signed-off-by:
-
Viresh Kumar authored
We already have macros for these, use them instead of writing fixed values. Signed-off-by:
-
Viresh Kumar authored
We already have macros for these, use them instead of writing fixed values. Signed-off-by:
-
Viresh Kumar authored
We already have macros for these, use them instead of writing fixed values. Signed-off-by:
-
Viresh Kumar authored
We already have macros for these, use them instead of writing fixed values. Signed-off-by:
-
Viresh Kumar authored
We already have macros for these, use them instead of writing fixed values. Signed-off-by:
-
Viresh Kumar authored
We already have macros for these, use them instead of writing fixed values. Signed-off-by:
-
Viresh Kumar authored
We already have macros for these, use them instead of writing fixed values. Signed-off-by:
-
Viresh Kumar authored
We already have macros for these, use them instead of writing fixed values. Signed-off-by:
-
Viresh Kumar authored
Minor spell fix. Signed-off-by:
-
Viresh Kumar authored
!= was used in place of <, while comparing expected and actual payload size. The module may be running a higher version of the protocol and might have some extra fields (towards the end) in the structure, and the AP needs to ignore them. This also updates the print (expected-payload-size < actual-payload-size), when the size doesn't match for requests received by the module. This gives more details required for debugging. Signed-off-by:
-
Viresh Kumar authored
Print (expected-payload-size actual-payload-size), when the size doesn't match for requests received by the module. This gives more details required for debugging the issue. Signed-off-by:
Alex Elder <elder@linaro.org> Signed-off-by:
-
Viresh Kumar authored
Print (expected-payload-size actual-payload-size), when the size doesn't match for requests received by the module. This gives more details required for debugging the issue. Signed-off-by:
-
- Aug 05, 2015
-
-
Alex Elder authored
These were not defined, and I just posted patches that use them. Signed-off-by:
Mark Greer <mgreer@animalcreek.com> Signed-off-by:
-
- Aug 04, 2015
-
-
Alex Elder authored
The error paths in gb_loopback_connection_init() are kind of screwed up--not in proper order, and the label naming convention seems a little inconsistent. Fix this, ensuring each error cleans up the setup that's been done up to that point. Use the convention that the label indicates the first thing that needs to be cleaned up. Reorder the statements in gb_loopback_connection_exit() to match the order of cleanup in gb_loopback_connection_init(). Signed-off-by:
Bryan O'Donoghue <bryan.odonoghue@linaro.org> Signed-off-by:
-
Alex Elder authored
Stop recording and updating the average every time a sample is recorded. Instead, compute it from the sum and count only when it's required. Signed-off-by:
-
Alex Elder authored
Define a separate macro for displaying the average of the samples collected. This will be used so we can calculate the average only when requested, rather than every time a new value gets recorded. Signed-off-by:
-
Alex Elder authored
The only values passed to the gb_loopback_ro_attr() macro are unsigned 32-bit values. So there's no need to pass a "type" format specifier. Signed-off-by:
-
Alex Elder authored
The error count is unsigned, so fix the format specifier used in its attribute definition. Signed-off-by:
-
Alex Elder authored
The count of statistical samples recorded is currently a 64-bit value. 32 bits is sufficient, and in fact anything more than that won't work for the do_div() call it's pass to anyway. So make the count field be 32 bits. Signed-off-by:
-
Alex Elder authored
The minimum and maximum values for stats values are always 32 bits. Change the type for these fields to reflect this. Signed-off-by:
-
Alex Elder authored
The only values supplied to gb_loopback_update_stats() are 32-bits, so change the type of the second argument to reflect that. Signed-off-by:
-
Alex Elder authored
Use the largest representable value when initializing the "min" field when resetting loopback statistics. Signed-off-by:
-
Alex Elder authored
There is no need to cast a void pointer to a particular type. Drop the casts used in this way, mainly in the attribute definition macros. Signed-off-by:
-
