Skip to content
GitLab
  1. Sep 29, 2022
  3. Sep 26, 2022
    • Uwe Kleine-König's avatar
      pxa: Drop if with an always false condition · a4d18465
      Uwe Kleine-König authored 
      

The remove callback is only called after probe completed successfully.
In this case platform_set_drvdata() was called with a non-NULL argument
and so ssp is never NULL.

Also note that returning an error code from a remove callback doesn't
result in the device staying bound. It's still removed and devm
callbacks are called. So the memory that ssp pointed to during probe,
goes away without the node being removed from ssp_list. The probable
result of an early exit is accessing freed memory when the list is
walked the next time.

Signed-off-by: Uwe Kleine-König <(address hidden)>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      a4d18465
  5. Sep 24, 2022
  7. Sep 18, 2022
  9. Sep 17, 2022
    • Arnd Bergmann's avatar
      ARM: disallow PCI with MMU=n again · 47723de8
      Arnd Bergmann authored 
      My cleanup patch allowed enabling PCI on MMU-less builds,
which breaks for at least one driver and is never required:

   In file included from include/linux/irqchip/arm-gic-v3.h:604,
                    from drivers/pci/controller/pcie-iproc.c:17:
   arch/arm/include/asm/arch_gicv3.h: In function 'write_ICC_EOIR1_EL1':
arch/arm/include/asm/arch_gicv3.h:44:9: error: implicit declaration of function 'write_sysreg' [-Werror=implicit-function-declaration]

Fixes: 6fd09c9a

 ("ARM: Kconfig: clean up platform selection")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      47723de8
  11. Sep 16, 2022
  13. Sep 15, 2022
    • Arnd Bergmann's avatar
      ARM: footbridge: remove custom DMA address handling · be7f3f90
      Arnd Bergmann authored 
      

Footbridge is the last Arm platform that has its own
__virt_to_bus()/__bus_to_virt()/phys_to_dma()/dma_to_phys() abstraction,
but this is just a simple offset now.

For PCI devices, the offset that is programmed into the PCI bridge must
also be set in each device using dma_direct_set_offset().  As Arm does
not have a pcibios_bus_add_device() helper yet, just use a bus notifier
for this.

For the ISA DMA, drivers now pass a non-translated physical address into
set_dma_addr(), so they have to be converted back with the corresponding
isa_bus_to_virt() function and then into the correct bus address with
the offset using the isa_dma_dev.

Tested-by: default avatarMarc Zyngier <maz@kernel.org>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      be7f3f90
  15. Sep 13, 2022
  17. Sep 09, 2022
  19. Sep 02, 2022
  21. Aug 30, 2022
    • Arnd Bergmann's avatar
      ARM: make ARCH_MULTIPLATFORM user-visible · 84fc8636
      Arnd Bergmann authored 
      

Some options like CONFIG_DEBUG_UNCOMPRESS and CONFIG_CMDLINE_FORCE are
fundamentally incompatible with portable kernels but are currently allowed
in all configurations. Other options like XIP_KERNEL are essentially
useless after the completion of the multiplatform conversion.

Repurpose the existing CONFIG_ARCH_MULTIPLATFORM option to decide
whether the resulting kernel image is meant to be portable or not,
and using this to guard all of the known incompatible options.

This is similar to how the RISC-V kernel handles the CONFIG_NONPORTABLE
option (with the opposite polarity).

A few references to CONFIG_ARCH_MULTIPLATFORM were left behind by
earlier clanups and have to be removed now up.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      84fc8636
    • Arnd Bergmann's avatar
      ARM: fix XIP_KERNEL dependencies · 5408445b
      Arnd Bergmann authored 
      

CONFIG_XIP_KERNEL does not work with any option that involves patching
the read-only kernel .text.

Since at least CONFIG_SMP_ON_UP is required in certain configurations,
flip the dependency to always allow the .text patching options but make
XIP_KERNEL have the dependency instead.

This is a prerequisite for allowing CONFIG_ARCH_MULTIPLATFORM to
be disabled.

Reviewed-by: default avatarGeert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
      5408445b
  23. Aug 29, 2022