- Feb 21, 2016
-
-
Liang Zhen authored
returned value of lnet_post_send_locked and lnet_post_routed_recv_locked are changed to -ve by: http://review.whamcloud.com/#/c/9369/ this is wrong because callers rely on +ve to identify blocked message which is not a failure. To respect linux kernel coding style and not use positive error code, this patch adds two macros as non-error returned values of these functions: LNET_CREDIT_OK has credit for message LNET_CREDIT_WAIT no credit and message is blocked both these functions will return these two values instead of 0 and EAGAIN Signed-off-by:
Liang Zhen <liang.zhen@intel.com> Signed-off-by:
James Simmons <uja.ornl@gmail.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5151 Reviewed-on: http://review.whamcloud.com/10625 Reviewed-by:
Chris Horn <hornc@cray.com> Reviewed-by:
Andreas Dilger <andreas.dilger@intel.com> Reviewed-by:
Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
John L. Hammond authored
Remove most uses of IS_ERR_VALUE(). This macro was often given an int argument coming from PTR_ERR(). This invokes implementation defined behavior since the long value gotten by applying PTR_ERR() to a kernel pointer will usually not be representable as an int. Moreover it may be just plain wrong to do this since the expressions IS_ERR(p) and IS_ERR_VALUE((int) PTR_ERR(p)) are not equivalent for a general pointer p. Signed-off-by:
John L. Hammond <john.hammond@intel.com> Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-3498 Reviewed-on: http://review.whamcloud.com/6759 Reviewed-by:
Dmitry Eremin <dmitry.eremin@intel.com> Reviewed-by:
-
James Simmons authored
Remove the bulk of code for the no longer supported SeaStar interconnect found on older Cray systems. Signed-off-by:
Doug Oucharek <doug.s.oucharek@intel.com> Reviewed-by:
Chuck Fossen <chuckf@cray.com> Reviewed-by:
-
Liang Zhen authored
error handler of lnet_create_reply_msg() didn't release lnet_res_lock if lnet_msg_alloc() failed. It can be fixed by moving validation check of msg out from lock. Signed-off-by:
Isaac Huang <he.huang@intel.com> Reviewed-by:
-
Chris Horn authored
We consider routes "down" if the router is down or the router NI for the target network is down. This should be reflected in the output of /proc/sys/lnet/routes Signed-off-by:
Cory Spitz <spitzcor@cray.com> Reviewed-by:
-
Chris Horn authored
Rename several variables in lnet_find_route_locked to make the code easier to understand. Broken out of patch 7857. Signed-off-by:
-
- Feb 20, 2016
-
-
Bhumika Goyal authored
This patch gets rid of struct typedefs wilc_cfg_byte_t, wilc_cfg_hword_t, wilc_cfg_word_t and wilc_cfg_str_t as as linux kernel coding style guidelines suggest not using typdefs for structure types. Also drop '_t' from the names. Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
This change has been made with the goal that kernel functions should return something more descriptive than -1 on failure. The return value on an alloc_etherdev failure should be -ENOMEM, and not -1. This was found using Coccinelle. A simplified version of the semantic patch used is: //<smpl> @@ expression *e; identifier l1; @@ e = alloc_etherdev(...); if (e == NULL) { ... return - -1 + -ENOMEM ; } //</smpl Furthermore, introduced `ret` variable to store and return the corresponding error code returned by register_netdev on failure. The two call sites store the return value in a variable which only checks that the value is non-zero, hence no change is required at the call sites. Signed-off-by:Amitoj Kaur Chawla <amitoj1606@gmail.com> Reviewed-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
-
Janani Ravichandran authored
Split statement across multiple lines as the line modified is over 80 chars in length. Signed-off-by:
Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by:
-
Janani Ravichandran authored
Use kmalloc_array instead of kmalloc for arrays to prevent integer overflows. Signed-off-by:
-
Janani Ravichandran authored
tcp_process() returns int, which is not used anywhere. So, change function header to return void intead of int and remove all uses of the local variable ret, which is used as a return variable in the function. Signed-off-by:
-
Amitoj Kaur Chawla authored
Remove wilc_wlan_global_reset function since it is not used anywhere in this driver. This also silences the following sparse warning: drivers/staging/wilc1000/wilc_wlan.c:1120:6: warning: symbol 'wilc_wlan_global_reset' was not declared. Should it be static? Signed-off-by:
-
Roger H. Newell authored
This patch corrects warnings generated by checkpatch.pl by removing braces from single block statements. Signed-off-by:
Roger H. Newell <newell.roger@gmail.com> Signed-off-by:
-
Roger H. Newell authored
This patch corrects errors generated by checkpatch.pl by removing whitespace between parameters passed to dev_err() Signed-off-by:
-
Chaehyun Lim authored
This patch uses netdev_err instead of PRINT_ER that is a custom debug print. Signed-off-by:
Chaehyun Lim <chaehyun.lim@gmail.com> Signed-off-by:
-
Chaehyun Lim authored
This patch renames result to ret that is used to get return value from wilc_send_config_pkt. It will be changed until all handle_*() function has same variable name as ret. Signed-off-by:
-
Chaehyun Lim authored
result variable gets value from wilc_send_config_pkt that has return value of int. This patch changes data type of result variable to int. Signed-off-by:
-
Chaehyun Lim authored
When handle_set_mac_address is called in hostIFthread that is a kernel thread, it is not checked return type of this function. This patch changes return type to void and removes a brace of if statement due to have a single statement. Signed-off-by:
-
Chaehyun Lim authored
This patch replaces kmalloc followed by memcpy with kmemdup. Signed-off-by:
-
Chaehyun Lim authored
This patch fix return error code of kmalloc as -ENOMEM instead of -EFAULT. Signed-off-by:
-
Chaehyun Lim authored
There is no need to print debug message when kmalloc is failed. This message is redundant. The code already show us that kmalloc is failed. The brace of if statement is remove as well due to have a single statement. Signed-off-by:
-
Alison Schofield authored
Remove unused semaphore declarations, initializations, and unlocks. The functions that locked these semaphores were previously removed, so this cleans up the remains. Signed-off-by:
Alison Schofield <amsfield22@gmail.com> Reviewed-by:
-
Eva Rachel Retuya authored
Delete the space around '->' as it is prohibited and breaks the code. Checkpatch found this issue. ERROR: spaces prohibited around that '->' Signed-off-by:
Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by:
-
Eva Rachel Retuya authored
Remove unnecessary whitespaces as pointed out by checkpatch: ERROR: trailing whitespace Signed-off-by:
-
- Feb 19, 2016
-
-
Thierry Reding authored
The fsl_mc_allocator_driver_exit() function is marked __exit, but is called by the error handling code in fsl_mc_allocator_driver_init(). This results in a section mismatch, which in turn could lead to executing random code. Remove the __exit annotation to fix this. Cc: J. German Rivera <German.Rivera@freescale.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
Thierry Reding <treding@nvidia.com> Signed-off-by:
-
Thierry Reding authored
This driver uses functionality (MSI IRQ domain) whose symbols aren't exported, and hence the modular build fails. While arguably there might be reasons to make these symbols available to modules, that change would be fairly involved and the set of exported functions should be carefully auditioned. Fix the build failure for now by marking the driver boolean. Cc: J. German Rivera <German.Rivera@freescale.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
-
- Feb 16, 2016
-
-
Mike Rapoport authored
Use stratight-forward definition of CRT_FB_ADDRESS register fields and use open-coded implementation for register manipulation Signed-off-by:
Mike Rapoport <mike.rapoport@gmail.com> Signed-off-by:
-
Mike Rapoport authored
Use stratight-forward definition of CRT_FB_WIDTH register fields and use open-coded implementation for register manipulation Signed-off-by:
-
Mike Rapoport authored
Use stratight-forward definition of DE_WINDOW_WIDTH register fields and use open-coded implementation for register manipulation Signed-off-by:
-
Mike Rapoport authored
Use stratight-forward definition of DE_STRETCH_FORMAT register fields and use open-coded implementation for register manipulation Signed-off-by:
-
Mike Rapoport authored
Use stratight-forward definition of DE_PITCH register fields and use open-coded implementation for register manipulation Signed-off-by:
-
Mike Rapoport authored
Use stratight-forward definition of DE_CONTROL register fields and use open-coded implementation for register manipulation Signed-off-by:
-
Mike Rapoport authored
Use stratight-forward definition of DE_DIMENSION register fields and use open-coded implementation for register manipulation Signed-off-by:
-
Mike Rapoport authored
Use stratight-forward definition of DE_DESTINATION register fields and use open-coded implementation for register manipulation Signed-off-by:
-
Mike Rapoport authored
Use stratight-forward definition of DE_SOURCE register fields and use open-coded implementation for register manipulation Signed-off-by:
-
Mike Rapoport authored
Use straight-forward definition of HWC_COLOR_{12,3} register fields instead of magic numbers Signed-off-by: -
Mike Rapoport authored
Use BIT() macro for single-bit fields of HWC_LOCATION register and define HWC_LOCATION_{X,Y}_MASK for masking the address bits. Signed-off-by: -
Mike Rapoport authored
Use BIT() macro for single-bit fields of HWC_ADDRESS register and define HWC_ADDRESS_ADDRESS_MASK for masking the address bits. Signed-off-by:
-
Mike Rapoport authored
Use stratight-forward definition of PANEL_VERTICAL_SYNC register fields and use open-coded implementation for register manipulation Signed-off-by:
-
Mike Rapoport authored
Use stratight-forward definition of PANEL_VERTICAL_TOTAL register fields and use open-coded implementation for register manipulation Signed-off-by:
-
