- Jun 03, 2017
-
-
Nikola Jelic authored
Temporary variable is used only as __be32, for both assignments and reads, but the type is inconsistent (__u32). Signed-off-by:
Nikola Jelic <nikola.jelic83@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Nikola Jelic authored
sockaddr_in.sin_addr.s_addr is __be32 integral type, so the (__force u32) cast after the htonl call is unnecessary, and also detected by sparse: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2309:33: warning: incorrect type in assignment (different base types) drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2381:30: warning: incorrect type in assignment (different base types) Signed-off-by:
-
Valentin Vidic authored
Introduces a local var to collect flags and convert them to le32. Fixes the following sparse warnings: drivers/staging/lustre/lustre/lmv/lmv_obd.c:2305:23: warning: invalid assignment: |= drivers/staging/lustre/lustre/lmv/lmv_obd.c:2305:23: left side has type restricted __le32 drivers/staging/lustre/lustre/lmv/lmv_obd.c:2305:23: right side has type int drivers/staging/lustre/lustre/lmv/lmv_obd.c:2383:39: warning: invalid assignment: |= drivers/staging/lustre/lustre/lmv/lmv_obd.c:2383:39: left side has type restricted __le32 drivers/staging/lustre/lustre/lmv/lmv_obd.c:2383:39: right side has type int Signed-off-by:
Valentin Vidic <Valentin.Vidic@CARNet.hr> Signed-off-by:
-
Mathias Rav authored
Reported by checkpatch.pl: "WARNING: Prefer seq_puts to seq_printf". Signed-off-by:
Mathias Rav <mathiasrav@gmail.com> Signed-off-by:
-
Mathias Rav authored
Clean up the helper functions used to implement "dump_granted_max" in debugfs. Replace the lprocfs_rd_uint() and lprocfs_wr_uint() generic callbacks with a simpler, more direct implementation of ldlm_rw_uint_fops. There's a slight change in lustre debugfs write semantics: Using kstrtox causes EINVAL when the written number is followed by other (garbage) characters, whereas previously the garbage would be ignored and such a write would succeed. Signed-off-by:
-
Konrad Malkowski authored
This patch fixes the checkpoint.pl warning: WARNING: Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit Signed-off-by:
Konrad Malkowski <konrad.malkowski@gmail.com> Signed-off-by:
-
- May 29, 2017
-
-
Stefan Wahren authored
This replaces all remaining BUG_ON with WARN_ON. So in case of a VCHIQ bug the system is still usable. Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Signed-off-by:
-
Stefan Wahren authored
Properly handle the error case in case of an invalid tx_pos. Signed-off-by:
-
Stefan Wahren authored
Bail out properly if the process index doesn't match the remote insert. We also drop the BUG in case the process index is at local insert, so we can trigger the WARN_ON again some steps later. Signed-off-by:
-
Stefan Wahren authored
If the ref counter of service has an unexpected value then we better bail out. Signed-off-by:
-
Stefan Wahren authored
In the unlikely case that service is NULL we should bail out instead of calling BUG_ON(). The other BUG_ON calls will be fixed in separate patches. Signed-off-by:
-
Stefan Wahren authored
VCHIQ suspend and resume isn't implemented, but even it was there is no need to call BUG(). Signed-off-by:
-
Stefan Wahren authored
In case VCHIQ state is already initialized we need to bailout in order to aovid a memory leak. Signed-off-by:
-
Stefan Wahren authored
Since the ARM side of VCHIQ support only 1 state, we could simplify the init code. This makes it possible to avoid BUG_ON and a theoretical overflow of id. Signed-off-by:
-
Stefan Wahren authored
Use the PAGE_MASK instead of open code it. Signed-off-by:
-
Stefan Wahren authored
In case vmalloc_to_page returns NULL create_pagelist must abort imediatly. Signed-off-by:
-
Stefan Wahren authored
Assuming the intension of the function is to clean up, so fix the function name accordingly. Signed-off-by:
-
Stefan Wahren authored
Reduce the indentation within vchiq_dump_service_use_state in order to avoid a multiline derefernce. Signed-off-by:
-
Stefan Wahren authored
This comment was apparently forgotten in the correction of CamelCase. Signed-off-by:
-
Stefan Wahren authored
The variable slot_mem_size is assigned a value which is never used. This issue has been found by CppCheck. Signed-off-by:
-
Stefan Wahren authored
We can reduce the scope of the counting variable i. This has been found by CppCheck. Signed-off-by:
-
Stefan Wahren authored
Instead of saving the return value of mutex_lock_killable in a local variable we could use the value directly. Signed-off-by:
-
Juliana Rodrigues authored
This patch fixes multiple comparison to NULL checkpatch errors by rewriting the conditional as a negation. Signed-off-by:
Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by:
-
Juliana Rodrigues authored
Removes numerous unnecessary blank lines in order to fix checkpatch styling issues. Signed-off-by:
-
Juliana Rodrigues authored
This patch removes numerous unnecessary parentheses in order to fix checkpatch styling issues. Signed-off-by:
-
Juliana Rodrigues authored
This patch fixes a checkpatch issue caused by using function names inside strings. Those function names were replaced by __func__. Signed-off-by:
-
Juliana Rodrigues authored
This patch solves a checkpatch issue caused by not using spaces around an OR sign. Signed-off-by:
-
Juliana Rodrigues authored
This patch adds * on block comments subsequent lines, which were causing a checkpatch styling warning. Signed-off-by:
-
Juliana Rodrigues authored
This patch fixes some checkpatch errors in which comments go over 80 characters per line. Signed-off-by:
-
Szilveszter Székely authored
Comparisons should place the constant on the right side of the test This patch fixes coding style issues as reported by checkpatch. Signed-off-by:
Szilveszter Székely <szekelyszilv@gmail.com> Signed-off-by:
-
Ioana Radulescu authored
WRIOP hardware may need to write to the hardware annotation area of Tx buffers (e.g. frame status bits) and also to the data area (e.g. L4 checksum in frame header). Map these buffers as DMA_BIDIRECTIONAL, otherwise the write transaction through SMMU will not be allowed. Signed-off-by:
Nipun Gupta <nipun.gupta@nxp.com> Signed-off-by:
Ioana Radulescu <ruxandra.radulescu@nxp.com> Signed-off-by:
-
Ioana Radulescu authored
Use the correct mechanisms for translating a DMA-mapped IOVA address into a virtual one. Without this fix, once SMMU is enabled on Layerscape platforms, the Ethernet driver throws IOMMU translation faults. Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
Derek Robson <robsonde@gmail.com> Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
Derek Robson authored
Fixed block comment alignment, Style fix only Found using checkpatch Signed-off-by:
-
