- Jun 28, 2021
-
-
Nathan Chancellor authored
clang versions prior to the current development version of 13.0.0 cannot compile s390 after commit 3abbdfde5a65 ("s390/bitops: use register pair instead of register asm") and the s390 maintainers do not intend to work around this in the kernel. Codify this in scripts/min-tool-version.sh similar to arm64 with GCC 5.1.0 so that there are no reports of broken builds. [hca@linux.ibm.com: breaking compatibility with older clang compilers is intended to finally make use of a feature which allows the compiler to allocate even/odd register pairs. This is possible since a very long time with gcc, but only since llvm-project commit d058262b1471 ("[SystemZ] Support i128 inline asm operands.") with clang. Using that feature allows to get rid of error prone register asm statements, of which the above named kernel commit is only the first of a larger not yet complete series.] Reported-by:Naresh Kamboju <naresh.kamboju@linaro.org> Signed-off-by:
Nathan Chancellor <nathan@kernel.org> Acked-by:
Nick Desaulniers <ndesaulniers@google.com> Acked-by:
Masahiro Yamada <masahiroy@kernel.org> Link: https://lore.kernel.org/r/20210617193139.856957-1-nathan@kernel.org Signed-off-by:
Heiko Carstens <hca@linux.ibm.com> Signed-off-by:
Vasily Gorbik <gor@linux.ibm.com>
-
- Jun 18, 2021
-
-
Heiko Carstens authored
Signed-off-by:
-
Heiko Carstens authored
The tprot() inline asm temporarily changes the program check new psw to redirect a potential program check on the diag instruction. Restoring of the program check new psw is done in C code behind the inline asm. This can be problematic, especially if the function is inlined, since the compiler can reorder instructions in such a way that a different instruction, which may result in a program check, might be executed before the program check new psw has been restored. To avoid such a scenario move restoring into the inline asm. For consistency reasons move also saving of the original program check new psw into the inline asm. Signed-off-by:
-
Heiko Carstens authored
...and slightly cleanup the inline asm. Signed-off-by:
-
Heiko Carstens authored
The __diag260() inline asm temporarily changes the program check new psw to redirect a potential program check on the diag instruction. Restoring of the program check new psw is done in C code behind the inline asm. This can be problematic, especially if the function is inlined, since the compiler can reorder instructions in such a way that a different instruction, which may result in a program check, might be executed before the program check new psw has been restored. To avoid such a scenario move restoring into the inline asm. For consistency reasons move also saving of the original program check new psw into the inline asm. Signed-off-by:
-
Heiko Carstens authored
Signed-off-by:
-
Heiko Carstens authored
Signed-off-by:
-
Heiko Carstens authored
Signed-off-by:
-
Heiko Carstens authored
Signed-off-by:
-
Heiko Carstens authored
...and slightly cleanup the inline asm. Signed-off-by:
-
Heiko Carstens authored
The __diag308() inline asm temporarily changes the program check new psw to redirect a potential program check on the diag instruction. Restoring of the program check new psw is done in C code behind the inline asm. This can be problematic, especially if the function is inlined, since the compiler can reorder instructions in such a way that a different instruction, which may result in a program check, might be executed before the program check new psw has been restored. To avoid such a scenario move restoring into the inline asm. For consistency reasons move also saving of the original program check new psw into the inline asm. Signed-off-by:
-
Niklas Schnelle authored
Reviewed-by:
Niklas Schnelle <schnelle@linux.ibm.com> Signed-off-by:
-
Julian Wiedmann authored
Power management support was removed for s390 with commit 39421627 ("s390: remove broken hibernate / power management support"). Remove the hvc_iucv_driver, but keep the device struct around so that it can continue to provide the hvc_iucv_dev_attr_groups attributes. Signed-off-by:
Julian Wiedmann <jwi@linux.ibm.com> Acked-by:
Peter Oberparleiter <oberpar@linux.ibm.com> Signed-off-by:
-
Dimitri John Ledkov authored
Enable ztsd support in s390/boot, to enable booting with zstd compressed kernel when configured with CONFIG_KERNEL_ZSTD=y. BOOT_HEAP_SIZE is defined to 0x30000 in this case. Actual decompressor memory usage with allyesconfig is currently 0x26150. BugLink: https://bugs.launchpad.net/bugs/1931725 Signed-off-by:
Dimitri John Ledkov <dimitri.ledkov@canonical.com> cc: Heiko Carstens <hca@linux.ibm.com> cc: Vasily Gorbik <gor@linux.ibm.com> cc: Christian Borntraeger <borntraeger@de.ibm.com> cc: linux-s390@vger.kernel.org Link: https://lore.kernel.org/r/20210615114150.325080-1-dimitri.ledkov@canonical.com [gor: added BOOT_HEAP_SIZE for zstd] Signed-off-by:
-
Vasily Gorbik authored
Currently BOOT_HEAP_SIZE is always defined as 0x400000 due to bogus condition. Use CONFIG_KERNEL_BZIP2 instead of CONFIG_HAVE_KERNEL_BZIP2 to correct that. BOOT_HEAP_SIZE of 0x10000 is still good enough for every decompressor algorithm but bzip2. Actual decompressor memory usage with allyesconfig is the following: gzip 0xbc28 bzip2 0x379518 xz 0x7410 lzma 0x3e6c lzo 0 lz4 0 Signed-off-by: -
Zou Wei authored
convert list_for_each() to list_for_each_entry() where applicable. Reported-by:
Hulk Robot <hulkci@huawei.com> Signed-off-by:
Zou Wei <zou_wei@huawei.com> Link: https://lore.kernel.org/r/1623740220-15846-1-git-send-email-zou_wei@huawei.com Signed-off-by:
-
Heiko Carstens authored
Remove register asm usage from diag8_noresponse() since it wasn't needed at all. There is no requirement for even/odd register pairs for diag 0x8. For diag_response() use register pairs to fulfill the rx+1 and ry+1 requirements as required if a response buffer is specified. Also change the inline asm to return the condition code of the diagnose instruction and do the conditional handling of response length calculation in C. Signed-off-by:
-
Heiko Carstens authored
Signed-off-by:
-
Heiko Carstens authored
Signed-off-by:
-
Heiko Carstens authored
Signed-off-by:
-
Heiko Carstens authored
Signed-off-by:
-
Heiko Carstens authored
Signed-off-by:
-
Heiko Carstens authored
Signed-off-by:
-
Heiko Carstens authored
Signed-off-by:
-
Heiko Carstens authored
Get rid of register asm statement and use a register pair. This allows the compiler to allocate registers on its own. Signed-off-by:
-
Heiko Carstens authored
Introduce a register pair union, which is supposed to be used for inline assemblies where instructions require parameters in even/odd numbered register pairs. This is more or less the same register pair construct which was available for 31 bit builds which was removed with commit 5a79859a ("s390: remove 31 bit support"). Signed-off-by:
-
Peter Oberparleiter authored
Power management support was removed for s390 with commit 39421627 ("s390: remove broken hibernate / power management support"). Remove leftover vmlogrdr-related power management code. Acked-by:
-
Peter Oberparleiter authored
Power management support was removed for s390 with commit 39421627 ("s390: remove broken hibernate / power management support"). Remove leftover sclp base-related power management code. Note that we keep the registration of the sclp platform driver since it is used to externalize non-PM related attributes in sysfs. Acked-by:
-
Peter Oberparleiter authored
Power management support was removed for s390 with commit 39421627 ("s390: remove broken hibernate / power management support"). Remove leftover sclp quiesce-related power management code. Acked-by:
-
Peter Oberparleiter authored
Power management support was removed for s390 with commit 39421627 ("s390: remove broken hibernate / power management support"). Remove leftover sclp memory hotplug-related power management code. Acked-by:
-
Peter Oberparleiter authored
Power management support was removed for s390 with commit 39421627 ("s390: remove broken hibernate / power management support"). Remove leftover sclp vt220-related power management code. Acked-by:
-
Peter Oberparleiter authored
Power management support was removed for s390 with commit 39421627 ("s390: remove broken hibernate / power management support"). Remove leftover sclp console-related power management code. Acked-by:
-
Peter Oberparleiter authored
Power management support was removed for s390 with commit 39421627 ("s390: remove broken hibernate / power management support"). Remove leftover monwriter-related power management code. Acked-by:
-
Peter Oberparleiter authored
Power management support was removed for s390 with commit 39421627 ("s390: remove broken hibernate / power management support"). Remove leftover monreader-related power management code. Acked-by:
-
Peter Oberparleiter authored
Power management support was removed for s390 with commit 39421627 ("s390: remove broken hibernate / power management support"). Remove leftover xpram-related power management code. Acked-by:
-
Peter Oberparleiter authored
Power management support was removed for s390 with commit 39421627 ("s390: remove broken hibernate / power management support"). Remove leftover dcssblk-related power management code. Acked-by:
-
Vineeth Vijayan authored
Currently css_wait_for_slow_path() gets called inside the chp->lock. The path-verification-loop of slowpath inside this lock could lead to deadlock as reported by the lockdep validator. The ccw_device_get_chp_desc() during the instance of a device-set-online would try to acquire the same 'chp->lock' to read the chp->desc. The instance of this function can get called from multiple scenario, like probing or setting-device online manually. This could, in some corner-cases lead to the deadlock. lockdep validator reported this as, CPU0 CPU1 ---- ---- lock(&chp->lock); lock(kn->active#43); lock(&chp->lock); lock((wq_completion)cio); The chp->lock was introduced to serialize the access of struct channel_path. This lock is not needed for the css_wait_for_slow_path() function, so invoke the slow-path function outside this lock. Fixes: b730f3a9 ("[S390] cio: add lock to struct channel_path") Cc: <stable@vger.kernel.org> Reviewed-by:Vineeth Vijayan <vneethv@linux.ibm.com> Signed-off-by:
-
Heiko Carstens authored
All s390 irqflags functions are very small and should be always inlined. Therefore mark them __always_inline. This also allows to get rid of the rather odd notrace attribute for these small functions, which was only added to prevent tracing iff any of these functions would not be inlined. Signed-off-by:
-
Heiko Carstens authored
s390 is the only architecture which makes use of the __no_kasan_or_inline attribute for two functions. Given that both stap() and __load_psw_mask() are very small functions they can and should be always inlined anyway. Therefore get rid of __no_kasan_or_inline and always inline these functions. Signed-off-by:
-
Peter Oberparleiter authored
When read via debugfs, s390dbf debug-views print the kernel address of the call-site that created a trace entry. The kernel's %p pointer hashing feature obfuscates this address, and commit 860ec7c6 ("s390/debug: use pK for kernel pointers") made this obfuscation configurable via the kptr_restrict sysctl. Obfuscation of kernel address data printed via s390dbf debug-views does not add any additional protection since the associated debugfs files are only accessible to the root user that typically has enough other means to obtain kernel address data. Also trace payload data may contain binary representations of kernel addresses as part of logged data structues. Requiring such payload data to be obfuscated as well would be impractical and greatly diminish the use of s390dbf. Therefore completely remove pointer obfuscation from s390dbf debug-views. Reviewed-by:
Steffen Maier <maier@linux.ibm.com> Acked-by:
-
