1. Mar 26, 2009
    • Rusty Russell's avatar
      x86: Correct behaviour of irq affinity · e06b1b56
      Rusty Russell authored
      
      
      Impact: get correct smp_affinity as user requested
      
      The effect of setting desc->affinity (ie. from userspace via sysfs) has
      varied over time.  In 2.6.27, the 32-bit code anded the value with
      cpu_online_map, and both 32 and 64-bit did that anding whenever a cpu
      was unplugged.
      
      2.6.29 consolidated this into one routine (and fixed hotplug) but
      introduced another variation: anding the affinity with cfg->domain.
      
      We should just set it to what the user said - if possible.
      
      (cpu_mask_to_apicid_and already takes cpu_online_mask into account)
      
      Signed-off-by: default avatarYinghai Lu <yinghai@kernel.org>
      Acked-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      LKML-Reference: <49C94DDF.2010703@kernel.org>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      e06b1b56
  2. Mar 25, 2009
    • Yinghai Lu's avatar
      x86: use default_cpu_mask_to_apicid for 64bit · f56e5034
      Yinghai Lu authored
      
      
      Impact: cleanup
      
      Use online_mask directly on 64bit too.
      
      Signed-off-by: default avatarYinghai Lu <yinghai@kernel.org>
      Cc: Andrew Morton <akpm@linux-foundation.org>
      Cc: "Eric W. Biederman" <ebiederm@xmission.com>
      Cc: Rusty Russell <rusty@rustcorp.com.au>
      LKML-Reference: <49C94DAE.9070300@kernel.org>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      f56e5034
    • Yinghai Lu's avatar
      x86: fix set_extra_move_desc calling · fa74c907
      Yinghai Lu authored
      Impact: fix bug with irq-descriptor moving when logical flat
      
      Rusty observed:
      
      > The effect of setting desc->affinity (ie. from userspace via sysfs) has varied
      > over time.  In 2.6.27, the 32-bit code anded the value with cpu_online_map,
      > and both 32 and 64-bit did that anding whenever a cpu was unplugged.
      >
      > 2.6.29 consolidated this into one routine (and fixed hotplug) but introduced
      > another variation: anding the affinity with cfg->domain.  Is this right, or
      > should we just set it to what the user said?  Or as now, indicate that we're
      > restricting it.
      
      Eric pointed out that desc->affinity should be what the user requested,
      if it is at all possible to honor the user space request.
      
      This bug got introduced by commit 22f65d31
      
       "x86: Update io_apic.c to use
      new cpumask API".
      
      Fix it by moving the masking to before the descriptor moving ...
      
      Reported-by: default avatarRusty Russell <rusty@rustcorp.com.au>
      Reported-by: default avatarEric W. Biederman <ebiederm@xmission.com>
      LKML-Reference: <49C94134.4000408@kernel.org>
      Signed-off-by: default avatarIngo Molnar <mingo@elte.hu>
      fa74c907
  3. Mar 24, 2009
  4. Mar 23, 2009
  5. Mar 22, 2009
  6. Mar 21, 2009