1. Jan 19, 2023
  2. Jan 18, 2023
    • Takashi Sakamoto's avatar
      firewire: fix memory leak for payload of request subaction to IEC 61883-1 FCP region · 531390a2
      Takashi Sakamoto authored
      This patch is fix for Linux kernel v2.6.33 or later.
      
      For request subaction to IEC 61883-1 FCP region, Linux FireWire subsystem
      have had an issue of use-after-free. The subsystem allows multiple
      user space listeners to the region, while data of the payload was likely
      released before the listeners execute read(2) to access to it for copying
      to user space.
      
      The issue was fixed by a commit 281e2032 ("firewire: core: fix
      use-after-free regression in FCP handler"). The object of payload is
      duplicated in kernel space for each listener. When the listener executes
      ioctl(2) with FW_CDEV_IOC_SEND_RESPONSE request, the object is going to
      be released.
      
      However, it causes memory leak since the commit relies on call of
      release_request() in drivers/firewire/core-cdev.c. Against the
      expectation, the function is never called due to the design of
      release_client_resource(). The function delegates release task
      to caller when called with non-NULL fourth argument. The implementation
      of ioctl_send_response() is the case. It should release the object
      explicitly.
      
      This commit fixes the bug.
      
      Cc: <stable@vger.kernel.org>
      Fixes: 281e2032
      
       ("firewire: core: fix use-after-free regression in FCP handler")
      Signed-off-by: default avatarTakashi Sakamoto <o-takashi@sakamocchi.jp>
      Link: https://lore.kernel.org/r/20230117090610.93792-2-o-takashi@sakamocchi.jp
      
      
      Signed-off-by: default avatarTakashi Iwai <tiwai@suse.de>
      531390a2
  3. Jan 13, 2023
  4. Jan 12, 2023
  5. Jan 10, 2023
  6. Jan 09, 2023
  7. Jan 07, 2023
  8. Jan 06, 2023
  9. Jan 05, 2023
  10. Jan 04, 2023
  11. Jan 03, 2023
  12. Jan 02, 2023
  13. Dec 30, 2022
  14. Dec 29, 2022
  15. Dec 28, 2022
    • Takashi Iwai's avatar
      ALSA: hda/hdmi: Static PCM mapping again with AMD HDMI codecs · 090ddad4
      Takashi Iwai authored
      The recent code refactoring for HD-audio HDMI codec driver caused a
      regression on AMD/ATI HDMI codecs; namely, PulseAudioand pipewire
      don't recognize HDMI outputs any longer while the direct output via
      ALSA raw access still works.
      
      The problem turned out that, after the code refactoring, the driver
      assumes only the dynamic PCM assignment, and when a PCM stream that
      still isn't assigned to any pin gets opened, the driver tries to
      assign any free converter to the PCM stream.  This behavior is OK for
      Intel and other codecs, as they have arbitrary connections between
      pins and converters.  OTOH, on AMD chips that have a 1:1 mapping
      between pins and converters, this may end up with blocking the open of
      the next PCM stream for the pin that is tied with the formerly taken
      converter.
      
      Also, with the code refactoring, more PCM streams are exposed than
      necessary as we assume all converters can be used, while this isn't
      true for AMD case.  This may change ...
      090ddad4
  16. Dec 27, 2022