- Oct 05, 2021
-
-
Sergio Paracuellos authored
This reverts commit 50fb34ec . Since IO_SPACE_LIMIT is not really being changed there is no real need to adjust the ioport_resource end limit. Acked-by:
Arnd Bergmann <arnd@arndb.de> Signed-off-by:
Sergio Paracuellos <sergio.paracuellos@gmail.com> Link: https://lore.kernel.org/r/20210925203224.10419-3-sergio.paracuellos@gmail.com Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Sergio Paracuellos authored
This reverts commit 15969747 . There is no real need to increase IO_SPACE_LIMIT if PCI_IOBASE is properly set to 'mips_io_port_base'. Hence revert this commit first before doing anything else. Acked-by:
Thomas Bogendoerfer <tsbogend@alpha.franken.de> Signed-off-by:
-
Saurav Girepunje authored
Remove the same expression (!memcmp(pIE->data, BROADCOM_OUI2, 3)) on both the side of "||" . Signed-off-by:
Saurav Girepunje <saurav.girepunje@gmail.com> Link: https://lore.kernel.org/r/YVme3xtnCHN/hOjS@user Signed-off-by:
-
Saurav Girepunje authored
Remove assignment of 'pHalData->TRxAntDivType' to itself. Signed-off-by:
-
Saurav Girepunje authored
Remove unused local variable macAddr. Acked-by:
Michael Straube <straube.linux@gmail.com> Signed-off-by:
-
Saurav Girepunje authored
Remove unused variable pAdapter in Efuse_Read1ByteFromFakeContent. Acked-by:
-
Kai Song authored
fix memdup.cocci warning: drivers/staging/r8188eu/os_dep/ioctl_linux.c:4452:33-40: WARNING opportunity for kmemdup Generated by: scripts/coccinelle/api/memdup.cocci Signed-off-by:
Kai Song <songkai01@inspur.com> Link: https://lore.kernel.org/r/20211003072841.215903-1-songkai01@inspur.com Signed-off-by:
-
Saurav Girepunje authored
Remove function power_saving_wk_hdl is it just calling rtw_ps_processor. Instead of power_saving_wk_hdl() call rtw_ps_processor(). Acked-by:
-
Michael Straube authored
Function rtl8188e_silentreset_for_specific_platform() is empty. Remove it and remove code that does nothing other than using the unwanted DBG_88E macro now. Signed-off-by:
-
Dawid Esterhuizen authored
This path fixes four checkpatch.pl warnings: Statements should start on a tabstop Signed-off-by:
Dawid Esterhuizen <desterhuizen@gmail.com> Link: https://lore.kernel.org/r/YVXGsMZDGmdGjErJ@kkobus.whirley.local Signed-off-by:
-
Michael Straube authored
Remove inirp_deinit from struct hal_ops and remove the wrappers rtw_hal_inirp_deinit() and rtl8188eu_inirp_deinit(). Call rtw_read_port_cancel() directly instead. Signed-off-by:
-
Michael Straube authored
Remove inirp_init from struct hal_ops and remove its wrapper rtw_hal_inirp_init(). Call rtl8188eu_inirp_init() directly instead. Signed-off-by:
-
Michael Straube authored
Remove free_recv_priv from struct hal_ops and remove its wrapper rtw_hal_free_recv_priv(). Call rtl8188eu_free_recv_priv() directly instead. Signed-off-by:
-
Michael Straube authored
Remove init_recv_priv from struct hal_ops and remove its wrapper rtw_hal_init_recv_priv(). Call rtl8188eu_init_recv_priv() directly instead. Signed-off-by:
-
Michael Straube authored
Remove init_xmit_priv from struct hal_ops an remove its wrapper rtw_hal_init_xmit_priv(). Call rtl8188eu_init_xmit_priv() directly instead. Signed-off-by:
-
Michael Straube authored
Remove GetHalDefVarHandler from struct hal_ops and remove its wrapper rtw_hal_get_def_var(). Call GetHalDefVar8188EUsb() directly instead. Signed-off-by:
-
Michael Straube authored
Remove SetHalDefVarHandler from struct hal_ops and remove its wrapper rtw_hal_set_def_var(). Call SetHalDefVar8188EUsb() directly instead. Signed-off-by:
-
Michael Straube authored
Function odm_GlobalAdapterCheck() is empty, remove it. Signed-off-by:
-
Michael Straube authored
SupportICType is ODM_RTL8188E in this driver. So function odm_DynamicBBPowerSaving() does nothing, remove it. It is the only user of odm_1R_CCA(), remove that function as well. Signed-off-by:
-
Saurav Girepunje authored
remove unused static variable channels. Signed-off-by:
-
Saurav Girepunje authored
Remove unused local variable ieee from ActivateBAEntry(). Signed-off-by:
-
Gustavo A. R. Silva authored
One-element and zero-length arrays are deprecated and should be replaced with flexible-array members[1]. Replace zero-length array with flexible-array member and make use of the struct_size() helper in kmalloc(). [1] https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays Link: https://github.com/KSPP/linux/issues/78 Link: https://github.com/KSPP/linux/issues/160 Signed-off-by:
Gustavo A. R. Silva <gustavoars@kernel.org> Link: https://lore.kernel.org/r/20210929193658.GA339070@embeddedor Signed-off-by:
-
Saurav Girepunje authored
Remove reassignment of same value to variable pstat->auth_seq. On if (seq == 1) assigning the value 2. At the end of if statement also assigning the value pstat->auth_seq = seq + 1 that is again assigning the value 2. Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Signed-off-by:
-
Saurav Girepunje authored
Remove condition which never get execute. as pattrib->mdata is always zero before if condition check. Reviewed-by:
-
Gustavo A. R. Silva authored
One-element and zero-length arrays are deprecated and should be replaced with flexible-array members[1]. Replace zero-length array with flexible-array member and make use of the struct_size() helper. [1] https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays Link: https://github.com/KSPP/linux/issues/78 Link: https://github.com/KSPP/linux/issues/160 Signed-off-by:
-
Longji Guo authored
kfree(NULL) is safe and the check 'if (pstat->passoc_req)' before kfree is not necessary. Reviewed-by:
Longji Guo <guolongji@uniontech.com> Link: https://lore.kernel.org/r/20210929110613.29979-1-guolongji@uniontech.com Signed-off-by:
-
Stefan Wahren authored
After merging vchiq_2835_arm.c into vchiq_arm.c some platform structs doesn't need to exported anymore. So move them into the C file. Signed-off-by:
Stefan Wahren <stefan.wahren@i2se.com> Link: https://lore.kernel.org/r/1633264369-998-4-git-send-email-stefan.wahren@i2se.com Signed-off-by:
-
Stefan Wahren authored
vchiq_arm.h contains some unnecessary declarations, so drop them. Signed-off-by:
-
Stefan Wahren authored
This moves vchiq_arm_init_state() above its caller, so we can drop the now unnecessary forward declaration and make the function static. Signed-off-by:
-
Tommaso Merciai authored
Replace camel case variable name for variable pbyCxtBuf with snake case equivalent, in mac.h Signed-off-by:
Tommaso Merciai <tomm.merciai@gmail.com> Link: https://lore.kernel.org/r/20211001202504.410383-1-tomm.merciai@gmail.com Signed-off-by:
-
- Sep 28, 2021
-
-
Larry Finger authored
This header defines a number of symbols/macros that are not used and can be removed. In addition, it defines a number of synonym symbols that are used interchangeably in the source. Only one is now selected. In addition to the above, a number of comments that have no meaning for this chip have been removed. Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Link: https://lore.kernel.org/r/20210927214527.5341-1-Larry.Finger@lwfinger.net Signed-off-by:
-
Nikita Yushchenko authored
For better maintainability, replace conditional expressions with if statements in the drivers' probe routine. Signed-off-by:
Nikita Yushchenko <nikita.yoush@cogentembedded.com> Link: https://lore.kernel.org/r/20210927160649.29209-1-nikita.yoush@cogentembedded.com Signed-off-by:
-
Nikita Yushchenko authored
Per Renesas datasheet, MLBC0 register's fcnt field in the embedded dim2 module must be never set to value different from 3. Enforce that, via an optional field in struct dim2_platform_data. Signed-off-by:
-
- Sep 27, 2021
-
-
Pavel Skripkin authored
Remove mutex 'usb_vendor_req_mutex'. It was used to protect a shared buffer for USB requests and, since that buffer is removed in previous patch, this mutex is now useless. Furthermore, because it was used to serialize the calls to the Core USB API, we thoroughly tested the enabling of concurrent firing of USB requests without the mutex and found no problems of any kind in common use cases. Co-developed-by:
Fabio M. De Francesco <fmdefrancesco@gmail.com> Signed-off-by:
Pavel Skripkin <paskripkin@gmail.com> Link: https://lore.kernel.org/r/20210924122705.3781-17-fmdefrancesco@gmail.com Signed-off-by:
-
Pavel Skripkin authored
Remove the shared buffer for USB requests because it is not necessary and use a local on stack variable since the new Core USB API does not have the constraints of usb_control_msg(). Co-developed-by:
-
Fabio M. De Francesco authored
Create and call new usb_write() instead of usbctrl_vendorreq() from inside rtw_write{8,16,32,N}(). In old code, rtw_write{8,16,32,N}() called usbctrl_vendorreq() which in turn uses usb_control_msg() from within a "while" loop to build a control URB, send it off and wait for completion. usbctrl_vendorreq() was used for both receiving and sending messages, depending on the "requesttype" argument which is passed by callers. Compared to usbctrl_vendorreq(), which manages both reads and writes from and to the USB endpoint, the new usb_write() manages only writes. For this purpose it uses the newer USB Core usb_control_msg_send() API. The latter is preferred according both to suggestions by Greg Kroah-Hartman and also to its actual design. A noteworthy feature of usb_control_msg_send() is that the data pointer can be made to a reference on the stack because it does not have the restriction that usb_control_msg() has where the data pointer must be to dynamically allocated memory. usbctrl_vendorreq() used a "while" loop that we considered unnecessary so that it is not in the new usb_write(). Furthermore, the latter has no redundant checking, less obvious comments, no debug prints, and it manages errors before success case. All in all, usb_write() is simpler than usbctrl_vendorreq() and uses less lines of code. Suggested-by: -
Fabio M. De Francesco authored
Create and call new usb_read() instead of usbctrl_vendorreq() from inside rtw_read{8,16,32}(). In old code, rtw_read{8,16,32}() called usbctrl_vendorreq() which in turn uses usb_control_msg() from within a "while" loop to build a control URB, send it off and wait for completion. usbctrl_vendorreq() was used for both receiving and sending messages, depending on the "requesttype" argument which was passed by callers. Compared to usbctrl_vendorreq(), which managed both reads and writes from and to the USB endpoint, the new usb_read() manages only reads. For this purpose it uses the newer USB Core usb_control_msg_recv() API. The latter is preferred according both to a suggestion by Greg Kroah-Hartman and also to its actual design. Two noteworthy features of usb_control_msg_recv() are that (1) the data pointer can be made to a reference on the stack because it does not have the restriction that usb_control_msg() has where the data pointer must be to dynamically allocated memory, and that (2) the whole message must be properly received from the device in order for this function to be successfuli (if a device returns less than the expected amount of data, then the function will fail). usbctrl_vendorreq() uses a "while" loop that we considered unnecessary so that it is not in the new usb_read(). Furthermore, the latter has no redundant checking, less obvious comments, and it manages errors before success cases. All in all, usb_read() is simpler than usbctrl_vendorreq() and uses less lines of code. Suggested-by: -
Fabio M. De Francesco authored
Remove an unnecessary 'if' test from usbctrl_vendorreq() because "length" is never greater than MAX_VENDOR_REQ_CMD_SIZE. Co-developed-by:
-
Fabio M. De Francesco authored
Change the type of "data" from __le32 to __le16. The size of the data that usbctrl_vendorreq() will read is two bytes in little endian order, so the most suitable type is __le16. With the old code, since the two most significant bytes of data are not initialized, KMSan can likely detect the reading of uninitialized data, so this change can prevent the checker from complaining. Co-developed-by:
-
Fabio M. De Francesco authored
Remove an unnecessary bitwise AND because "length" can never be greater than 0xffff since VENDOR_CMD_MAX_DATA_LEN is defined as '254'. Co-developed-by:
-
