Skip to content
GitLab
  1. Jun 15, 2013
    • Al Viro's avatar
      snd_pcm_link(): fix a leak... · dd6c5cd8
      Al Viro authored 
      

in case when snd_pcm_stream_linked(substream) is true, we end up leaking
group.

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      dd6c5cd8
    • Al Viro's avatar
      use can_lookup() instead of direct checks of ->i_op->lookup · 05252901
      Al Viro authored 
      

a couple of places got missed back when Linus has introduced that one...

Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      05252901
    • Oleg Nesterov's avatar
      move exit_task_namespaces() outside of exit_notify() · 8aac6270
      Oleg Nesterov authored 
      exit_notify() does exit_task_namespaces() after
forget_original_parent(). This was needed to ensure that ->nsproxy
can't be cleared prematurely, an exiting child we are going to
reparent can do do_notify_parent() and use the parent's (ours) pid_ns.

However, after 32084504

 "pidns: use task_active_pid_ns in
do_notify_parent" ->nsproxy != NULL is no longer needed, we rely
on task_active_pid_ns().

Move exit_task_namespaces() from exit_notify() to do_exit(), after
exit_fs() and before exit_task_work().

This solves the problem reported by Andrey, free_ipc_ns()->shm_destroy()
does fput() which needs task_work_add().

Note: this particular problem can be fixed if we change fput(), and
that change makes sense anyway. But there is another reason to move
the callsite. The original reason for exit_task_namespaces() from
the middle of exit_notify() was subtle and it has already gone away,
now this looks confusing. And this allows us do simplify exit_notify(),
we can avoid unlock/lock(tasklist) and we can use ->exit_state instead
of PF_EXITING in forget_original_parent().

Reported-by: default avatarAndrey Vagin <avagin@openvz.org>
Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Acked-by: default avatar"Eric W. Biederman" <ebiederm@xmission.com>
Acked-by: default avatarAndrey Vagin <avagin@openvz.org>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      8aac6270
    • Oleg Nesterov's avatar
      fput: task_work_add() can fail if the caller has passed exit_task_work() · e7b2c406
      Oleg Nesterov authored 
      

fput() assumes that it can't be called after exit_task_work() but
this is not true, for example free_ipc_ns()->shm_destroy() can do
this. In this case fput() silently leaks the file.

Change it to fallback to delayed_fput_work if task_work_add() fails.
The patch looks complicated but it is not, it changes the code from

	if (PF_KTHREAD) {
		schedule_work(...);
		return;
	}
	task_work_add(...)

to
	if (!PF_KTHREAD) {
		if (!task_work_add(...))
			return;
		/* fallback */
	}
	schedule_work(...);

As for shm_destroy() in particular, we could make another fix but I
think this change makes sense anyway. There could be another similar
user, it is not safe to assume that task_work_add() can't fail.

Reported-by: default avatarAndrey Vagin <avagin@openvz.org>
Signed-off-by: default avatarOleg Nesterov <oleg@redhat.com>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
      e7b2c406
  3. Jun 08, 2013
  5. Jun 05, 2013
  7. Jun 04, 2013
  9. Jun 03, 2013