- Oct 12, 2017
-
-
Mauro Carvalho Chehab authored
Currently, there are two handlers for ioctls: - dvb_frontend_ioctl_properties() - dvb_frontend_ioctl_legacy() Despite their names, both handles non-legacy DVB ioctls. Besides that, there's no reason why to not handle all ioctls on a single handler function. So, merge them into a single function (dvb_frontend_handle_ioctl) and reorganize the ioctl's to indicate what's the current DVB API and what's deprecated. Despite the big diff, the handling logic for each ioctl is the same as before. Reviewed-by:
Shuah Khan <shuahkh@osg.samsung.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab@s-opensource.com>
-
Mauro Carvalho Chehab authored
Use a switch() on this function, just like on other ioctl handlers and handle parameters inside each part of the switch. That makes it easier to integrate with the already existing ioctl handler function. Reviewed-by:
-
Mauro Carvalho Chehab authored
Now that all clients of set_property() were removed, get rid of this callback. Signed-off-by: -
Mauro Carvalho Chehab authored
Only lg2160 implement gets_property, but there's no need for that, as no other driver calls this callback, as get_frontend() does the same, and set_frontend() also calls lg2160 get_frontend(). So, get rid of it. Signed-off-by:
Michael Ira Krufky <mkrufky@linuxtv.org> Signed-off-by:
-
Mauro Carvalho Chehab authored
This callback is not actually doing anything but making it to return an error depending on the DTV frontend command. Well, that could break userspace for no good reason, and, if needed, should be implemented, instead, at set_frontend() callback. So, get rid of it. Signed-off-by: -
Mauro Carvalho Chehab authored
The stv6110 has a weird code that checks if get_property and set_property ioctls are defined. If they're, it initializes a "srate" var from properties cache. Otherwise, it sets to 15MBaud, with won't make any sense. Thankfully, it seems that someone else discovered the issue in the past, as "srate" is currently not used anywhere! So, get rid of that really weird dead code logic. Reported-by:
Honza Petrous <jpetrous@gmail.com> Signed-off-by:
-
Mauro Carvalho Chehab authored
This driver doesn't implement support for set_property(). Yet, it implements a boilerplate for it. Get rid of it. Signed-off-by: -
Sean Young authored
Without device tree, there is no way to use this driver. Signed-off-by:
Sean Young <sean@mess.org> Acked-by:
Andi Shyti <andi.shyti@samsung.com> Signed-off-by:
-
Sean Young authored
The ioctl LIRC_SET_REC_TIMEOUT would set a timeout of 704ns if called with a timeout of 4294968us. Cc: <stable@vger.kernel.org> Signed-off-by:
-
Marc Gonzalez authored
Add DT binding for the HW IR decoder embedded in SMP86xx/SMP87xx. Signed-off-by:
Marc Gonzalez <marc_gonzalez@sigmadesigns.com> Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
-
Mans Rullgard authored
The tango HW IR decoder supports NEC, RC-5, RC-6 protocols. Signed-off-by:
Mans Rullgard <mans@mansr.com> Signed-off-by:
-
Marc Gonzalez authored
Add a keymap for the Sigma Designs Vantage (dev board) remote control. Signed-off-by:
-
Sean Young authored
Without device tree, there is no way to use this driver. Signed-off-by:
-
Sean Young authored
Without device tree, there is no way to use this driver. Signed-off-by:
-
Sean Young authored
If the kernel is built without device tree, this driver cannot be used and without gpiolib it cannot control any gpio pin. Signed-off-by:
-
Sean Young authored
When receiving an nec repeat, rc_repeat() is called and then rc_keydown() with the last decoded scancode. That last call is redundant. Fixes: 265a2988 ("media: rc-core: consistent use of rc_repeat()") Cc: <stable@vger.kernel.org> # v4.14 Signed-off-by:
-
David Härdeman authored
There are no users of this functionality (ir-lirc-codec.c has its own implementation and lirc_zilog.c doesn't use it) so remove it. This only affects users of the lirc kapi, not rc-core drivers. Signed-off-by:
David Härdeman <david@hardeman.nu> Signed-off-by:
-
- Oct 05, 2017
-
-
Ladislav Michl authored
The 0-day robot reports: drivers/media/rc/gpio-ir-recv.c: In function 'gpio_ir_recv_irq': >> drivers/media/rc/gpio-ir-recv.c:38:8: error: implicit declaration of function 'gpiod_get_value' [-Werror=implicit-function-declaration] Fixes: eed008e6 ("[media] media: rc: gpio-ir-recv: use gpiolib API") For some reason only partial patch was applied. Also include gpio/consumer.h otherwise compile test fails. Reported-by:
kbuild test robot <fengguang.wu@intel.com> Signed-off-by:
Ladislav Michl <ladis@linux-mips.org> Acked-by:
-
Sakari Ailus authored
The clock control is not explicitly controlled by the driver in two cases: ACPI based systems and when the clock is part of the power sequence of the camera module. Signed-off-by:
Sakari Ailus <sakari.ailus@linux.intel.com> Signed-off-by:
Mauro Carvalho Chehab <mchehab@osg.samsung.com>
-
Sakari Ailus authored
Obtain the clock rate from the clock framework if it's not available through DT. The assumption is that the parent device (camera module) defines the rate as clock control is a part of the power on and power off sequences --- which are camera module specific. Also use the clock rate from DT if no clock is provided. Signed-off-by:
-
Sakari Ailus authored
The external clock frequency was set by the driver but the obtained frequency was never verified. Do that. Being able to obtain the exact frequency is important as the value is used for PLL calculations which may result in frequencies that violate the PLL tree limits. Signed-off-by:
-
Sakari Ailus authored
The error handling code in smiapp_power_on() returned in case of a failed I2C write instead of cleaning up the mess. Fix this. Signed-off-by:
-
Sakari Ailus authored
ov13858 contained a 64-bit division. Use do_div() for calculating it. Signed-off-by:
Chiranjeevi Rapolu <chiranjeevi.rapolu@intel.com> Signed-off-by:
-
Chiranjeevi Rapolu authored
Previously, with crop (0, 0), (4255, 3167), VTS < 0xC9E was resulting in blank frames sometimes. This appeared as video flickering. But we need VTS < 0xC9E to get ~30fps. Omni Vision recommends to use crop (0,8), (4255, 3159) for 4224x3136. With this crop, VTS 0xC8E is supported and yields ~30fps. Signed-off-by:
Tomasz Figa <tfiga@chromium.org> Signed-off-by:
-
Chiranjeevi Rapolu authored
Calculate pixel-rate at run time instead of compile time. Instead of using hardcoded pixels-per-line, extract it from current sensor mode. Signed-off-by:
-
Colin Ian King authored
Don't populate the array reset_seq on the stack, instead make it static. Makes the object code smaller by over 50 bytes: Before: text data bss dec hex filename 11737 6000 64 17801 4589 drivers/media/i2c/ov2640.o After: text data bss dec hex filename 11582 6096 64 17742 454e drivers/media/i2c/ov2640.o Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Sakari Ailus authored
The active and has_no_links arrays will overrun in media_entity_pipeline_start() if there's an entity which has more than MEDIA_ENTITY_MAX_PAD pads. Ensure in media_entity_init() that there are fewer pads than that. Signed-off-by:
Hans Verkuil <hans.verkuil@cisco.com> Signed-off-by:
-
Markus Elfring authored
Replace the specification of a data structure by pointer dereferences as the parameter for the operator "sizeof" to make size determination a bit safer according to the Linux coding style convention. This issue was detected by using the Coccinelle software. [mchehab@s-opensource.com: merged similar patches] Signed-off-by:
Markus Elfring <elfring@users.sourceforge.net> Signed-off-by:
-
Markus Elfring authored
Omit extra messages for memory allocation failures. This issue was detected by using the Coccinelle software. [mchehab@s-opensource.com: merged similar patches] Signed-off-by:
-
Chiranjeevi Rapolu authored
Previously, the sensor was not streaming after resume from suspend, i.e. on S0->S3->S0 transition. Due to this, camera app preview appeared as stuck. Now, handle streaming state correctly in case of suspend-resume. Signed-off-by:
-
Rajmohan Mani authored
Current v4l2 focus ctrl step value of 16, limits the minimum granularity of focus positions to 16. Setting this value as 1, enables more accurate focus positions. Signed-off-by:
Rajmohan Mani <rajmohan.mani@intel.com> Signed-off-by:
-
Fabio Estevam authored
clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by:
Fabio Estevam <fabio.estevam@nxp.com> Signed-off-by:
-
Fabio Estevam authored
devm_clk_get() may return different error codes other than -EPROBE_DEFER, so it is better to return the real error code instead. Signed-off-by:
-
Fabio Estevam authored
v4l2_clk_get() may return different error codes other than -EPROBE_DEFER, so it is better to return the real error code instead. Signed-off-by:
-
Chiranjeevi Rapolu authored
Previously, images were relatively darker due to non-optimal settings for black target level and bias. Now, use recommended settings for black target level and output bias as default values. The same default settings apply to all the resolutions. Given these recommeneded settings do not change dynamically, add these to existing mode register settings. Signed-off-by:
-
Hans Verkuil authored
If you have a control handler that does not contain any controls, then currently calling VIDIOC_G/S/TRY_EXT_CTRLS with count == 0 will return -EINVAL in the class_check() function. This is not correct, there is no reason why this should return an error. The purpose of setting count to 0 is to test if the ioctl can mix controls from different control classes. And this is possible. The fact that there are not actually any controls defined is another matter that is unrelated to this test. This caused v4l2-compliance to fail, so that is fixed with this patch applied. Signed-off-by:
Dave Stevenson <dave.stevenson@raspberrypi.org> Tested-by:
-
Hans Verkuil authored
Only send HPD_LOW/HIGH event if the gpio actually changed value. Signed-off-by:
-
Johan Hovold authored
Make sure to check that we actually have an Interface Association Descriptor before dereferencing it during probe to avoid dereferencing a NULL-pointer. Fixes: e0d3bafd ("V4L/DVB (10954): Add cx231xx USB driver") Cc: stable <stable@vger.kernel.org> # 2.6.30 Reported-by:
Andrey Konovalov <andreyknvl@google.com> Signed-off-by:
Johan Hovold <johan@kernel.org> Tested-by:
-
Kees Cook authored
This converts to use setup_timer() to set callback and data, though it doesn't look like this would have worked with timer checking enabled since no init_timer() was ever called before. Cc: Mats Randgaard <matrandg@cisco.com> Cc: Mauro Carvalho Chehab <mchehab@kernel.org> Signed-off-by:
Kees Cook <keescook@chromium.org> Signed-off-by:
-
Hans Verkuil authored
Add support for 10 and 12 bit luma formats. Signed-off-by:
Hans Verkuil <hansverk@cisco.com> Signed-off-by:
-
