Skip to content
GitLab
  1. Jul 20, 2008
    • Ralf Baechle's avatar
      [MIPS] Tinker with constraints in <asm/atomic.h> to fix build error. · d6d8a463
      Ralf Baechle authored 
      

[...]
  CC      init/main.o
include/asm/bitops.h: In function `start_kernel':
include/asm/bitops.h:76: warning: asm operand 2 probably doesn't match
constraints
include/asm/bitops.h:76: warning: asm operand 2 probably doesn't match
constraints
include/asm/bitops.h:76: warning: asm operand 2 probably doesn't match
constraints
include/asm/bitops.h:76: error: impossible constraint in `asm'
include/asm/bitops.h:76: error: impossible constraint in `asm'
include/asm/bitops.h:76: error: impossible constraint in `asm'
make[1]: *** [init/main.o] Error 1
[...]

The build error is caused by the ages old gcc bug where gcc at the time of
analyzing the constraints is unable to figure out that an "i" constraint
actually can be satisfied and thus will abort unless an "r" is added to
the constraint.  For the actual code generation gcc will only ever use the
"i" constraint.

Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      d6d8a463
    • Dmitri Vorobiev's avatar
      [MIPS] Add missing prototypes to asm/page.h · c29d1503
      Dmitri Vorobiev authored 
      

This patch fixes the following sparse warnings:

>>>>>>>>>>>>>>>>>>
arch/mips/mm/page.c:284:16: warning: symbol
'build_clear_page' was not declared. Should it be static?

arch/mips/mm/page.c:426:16: warning: symbol 'build_copy_page'
was not declared. Should it be static?
>>>>>>>>>>>>>>>>>>

The fix is to add appropriate prototypes to the header
include/asm-mips/page.h.

Build-tested against Malta defconfig.

Signed-off-by: default avatarDmitri Vorobiev <dmitri.vorobiev@movial.fi>
Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      c29d1503
    • Dmitri Vorobiev's avatar
      [MIPS] Fix missing prototypes in asm/fpu.h · f028b860
      Dmitri Vorobiev authored 
      

While building the Malta defconfig, sparse spat the following
warnings:

>>>>>>>>>>>>>>>>>>
arch/mips/math-emu/kernel_linkage.c:31:6: warning: symbol
'fpu_emulator_init_fpu' was not declared. Should it be static?

arch/mips/math-emu/kernel_linkage.c:54:5: warning: symbol
'fpu_emulator_save_context' was not declared. Should it be
static?

arch/mips/math-emu/kernel_linkage.c:68:5: warning: symbol
'fpu_emulator_restore_context' was not declared. Should it be
static?
>>>>>>>>>>>>>>>>>>

This patch fixes these errors by adding the proper prototypes
to the include/asm-mips/fpu.h header, and actually using this
header in the sparse-spotted source file.

Build-tested with Malta defconfig.

Signed-off-by: default avatarDmitri Vorobiev <dmitri.vorobiev@movial.fi>
Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      f028b860
    • Dmitri Vorobiev's avatar
      [MIPS] PCI: Make the pcibios_max_latency variable static · 3450004a
      Dmitri Vorobiev authored 
      

The pcibios_max_latency variable is needlessly defined global, and this
patch makes it static.

Build-tested using malta_defconfig.

Signed-off-by: default avatarDmitri Vorobiev <dmitri.vorobiev@movial.fi>
Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
      3450004a
  3. Jul 18, 2008
  5. Jul 17, 2008