- May 15, 2017
-
-
Andrey Shvetsov authored
This replaces the call of wait_for_completion in case of an invalid MAC address in the function most_nd_open() with the dormant state of the network device. As a side effect, opening the network device cannot fail anymore. Signed-off-by:
Andrey Shvetsov <andrey.shvetsov@k2l.de> Signed-off-by:
Christian Gromm <christian.gromm@microchip.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Andrey Shvetsov authored
The function most_nd_stop is only called by successful return from the function most_nd_open, so the channels_opened is always true in the function most_nd_stop. The functions aim_resume_tx_channel and aim_rx_data are only called after successful most_start_channel in the function most_nd_open, so the channels_opened is always true in the functions aim_resume_tx_channel and aim_rx_data. Signed-off-by:
-
Aviv Palivoda authored
Constants should be on the right side of comparisons. Issue found by checkpatch.pl script. Signed-off-by:
Aviv Palivoda <palaviv@gmail.com> Signed-off-by:
-
Matthew Giassa authored
Resolving checkpatch issue: CHECK: 'Regsiter' may be misspelled - perhaps 'Register'? CHECK: 'Interrup' may be misspelled - perhaps 'Interrupt'? All instances resolved. Signed-off-by: -
Matthew Giassa authored
Resolving checkpatch issue: WARNING: please, no space before tabs All instances resolved. Signed-off-by: -
Matthew Giassa authored
Resolving checkpatch issue: CHECK: Please don't use multiple blank lines All instances resolved. Signed-off-by: -
Andrea della Porta authored
staging: wlan-ng: prism2mgmt.c: fixed a double endian conversion before calling hfa384x_drvr_setconfig16, also fixes relative sparse warning staging: wlan-ng: prism2mgmt.c: This patches fixes a double endian conversion. cpu_to_le16() was called twice first in prism2mgmt_scan and again inside hfa384x_drvr_setconfig16() for the same variable, hence it was swapped twice. Incidentally, it also fixed the following sparse warning: drivers/staging/wlan-ng/prism2mgmt.c:173:30: warning: incorrect type in assignment (different base types) drivers/staging/wlan-ng/prism2mgmt.c:173:30: expected unsigned short [unsigned] [usertype] word drivers/staging/wlan-ng/prism2mgmt.c:173:30: got restricted __le16 [usertype] <noident> Unfortunately, only compile tested. Signed-off-by:
Andrea della Porta <sfaragnaus@gmail.com> Signed-off-by:
-
Anton Bondarenko authored
Use usb_put_hdc to release hdc allocated by usb_create_hcd. This is needed to handle sub-allocations and HCD sharing correctly. Signed-off-by:
Anton Bondarenko <anton.bondarenko.sama@gmail.com> Signed-off-by:
-
Jaya Durga authored
Fixed coding style issue Signed-off-by:
Jaya Durga <rjdurga@gmail.com> Signed-off-by:
-
Tobin C. Harding authored
Target device is little endian. Host interface data structures used for building frames to pass to target device should use little endian data types. All u32 structure members in ks_hostif.h need to be changed to __le32. Change all u16 data types in host interface structures to be __le32. Signed-off-by:
Tobin C. Harding <me@tobin.cc> Signed-off-by:
-
Tobin C. Harding authored
Target device is little endian. Host interface data structures used for building frames to pass to target device should use little endian data types. All u16 structure members in ks_hostif.h need to be changed to __le16, Sparse can then be used to make sure we update all code that touches these data. Change all u16 data types in host interface structures to be __le16. Update all code that touches modified data types. Check using Sparse. Signed-off-by:
-
Tobin C. Harding authored
Sparse emits warning: cast to restricted __be16. EAP header uses network byte order. The structures used to describe it should use __beXX data types. Change data type unsigned short -> __be16. Signed-off-by:
-
Salvatore Benedetto authored
Fix all PARENTHESIS_ALIGNMENT type errors reported by checkpatch in rtxt.c Signed-off-by:
Salvatore Benedetto <salvatore.benedetto@gmail.com> Signed-off-by:
-
Juliana Rodrigues authored
Removed comparison to NULL fixing checkpatch issues. Signed-off-by:
Juliana Rodrigues <juliana.orod@gmail.com> Signed-off-by:
-
Derek Robson authored
Changed include of <asm/io.h> to be <linux/io.h> Complies, but I don't have hardware. Found using checkpatch. Signed-off-by:
Derek Robson <robsonde@gmail.com> Signed-off-by:
-
Alexis Lothoré authored
Ensure that "Reserved" members of registers mapping structure do not mix upper/lower case Signed-off-by:
Alexis Lothoré <alexis.lothore@gmail.com> Signed-off-by:
-
Alexis Lothoré authored
Make sure to break long lines to 80 Signed-off-by:
-
Alexis Lothoré authored
Ensure that function parameters use snake_case (some mixed upper/lower case) Signed-off-by:
-
Alexis Lothoré authored
Ensure that any any local variable use snake_case (many mixed upper/lower case) Signed-off-by:
-
Alexis Lothoré authored
Ensure that function names does not mix upper/lower case Signed-off-by:
-
Alexis Lothoré authored
Add missing parenthesis for else statement Signed-off-by:
-
Alexis Lothoré authored
Update EPn* variables names to EPN* to prevent CamelCase usage Signed-off-by:
-
Geert Uytterhoeven authored
Closing braces should match the first characters of the openings. Signed-off-by:
Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by:
-
Gilad Ben-Yossef authored
Fix various checkpatch warnings and errors in LLI macro definitions Signed-off-by:
Gilad Ben-Yossef <gilad@benyossef.com> Signed-off-by:
-
Gilad Ben-Yossef authored
Drop uneeded include guard for __KERNEL__. Signed-off-by:
-
Gilad Ben-Yossef authored
The MSB64 is defined in two include file. One copy is sufficient. Signed-off-by:
-
Gilad Ben-Yossef authored
Fix checkpatch reported white space style violations in cc_lli_defs.h Signed-off-by:
-
Gilad Ben-Yossef authored
Fix checkpatch reported white space style violations in cc_hw_queue_defs.h Signed-off-by:
-
Gilad Ben-Yossef authored
Fix enum and struct definition coding style by removing uneeded typedef and s/CamelCase/snake_case/g. Signed-off-by:
-
Gilad Ben-Yossef authored
Replace open coded struct zeroing with a memset call. Signed-off-by:
-
Gilad Ben-Yossef authored
Remove useless and wrong min/max macros. Signed-off-by:
-
Gilad Ben-Yossef authored
Move from stdint style int_t/uint_t to kernel style u/s types. Signed-off-by:
-
Gilad Ben-Yossef authored
Remove a bunch of cruft being used in HW debugging but not useful or compiled for driver use or development. Signed-off-by:
-
Thibaut Robert authored
This patch fixes checkpatch warnings: "WARNING: braces {} are not necessary for single statement blocks" and "WARNING: braces {} are not necessary for any arm of this statement". Signed-off-by:Thibaut Robert <thibaut.robert@gmail.com> Signed-off-by:
-
Gustavo A. R. Silva authored
offset is an unsigned variable and, greater-than-or-equal-to-zero comparison of an unsigned variable is always true. Addresses-Coverity-ID: 1373919 Signed-off-by:
Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by:
-
Matthew Giassa authored
Resolving a minor checkpatch/indentation issue in ion_carveout_heap.c, ie: drivers/staging/android/ion/ion_carveout_heap.c ----------------------------------------------- CHECK: Alignment should match open parenthesis +static phys_addr_t ion_carveout_allocate(struct ion_heap *heap, + unsigned long size) Signed-off-by:
Matthew Giassa <matthew@giassa.net> Signed-off-by:
-
JB Van Puyvelde authored
According to checkpatch.pl, kcalloc should be preferred to kzalloc with multiply. Signed-off-by:
JB Van Puyvelde <jbvanpuyvelde@gmail.com> Acked-by:
Viresh Kumar <viresh.kumar@linaro.org> Reviewed-by:
Rui Miguel Silva <rmfrfs@gmail.com> Signed-off-by:
-
Karthik Tummala authored
Fixed following checkpatch.pl warning: * WARNING: Prefer kcalloc over kzalloc with multiply Instead of specifying no.of bytes * size as argument in kzalloc, prefer kcalloc. Signed-off-by:
Karthik Tummala <karthik@techveda.org> Reviewed-by:
-
Laurence Rochfort authored
Balance if/else braces as recommended by checkpatch.pl Signed-off-by:
Laurence Rochfort <laurence.rochfort@gmail.com> Signed-off-by:
-
Ivan Safonov authored
Remove unused RTW_IEEE80211_FCTL_*, RTW_IEEE80211_FTYPE_*, RTW_IEEE80211_STYPE_*, IEEE80211_STATMASK_*, IEEE80211_DEFAULT_*, BEACON_PROBE_SSID_ID_POSITION, MFIE_TYPE_*, IEEE80211_DTIM_* and IEEE80211_PS_*. Signed-off-by:
Ivan Safonov <insafonov@gmail.com> Signed-off-by:
-
