- Aug 02, 2023
-
-
Andrei Coardos authored
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Reviewed-by:
Alexandru Ardelean <alex@shruggie.ro> Signed-off-by:
Andrei Coardos <aboutphysycs@gmail.com> Reviewed-by:
Andy Shevchenko <andy.shevchenko@gmail.com> Signed-off-by:
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
-
Andrei Coardos authored
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Reviewed-by:
-
Andrei Coardos authored
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Reviewed-by:
-
Stanislav Jakubek authored
Convert Broadcom Kona family GPIO controller bindings to DT schema. Changes during conversion: - add used, but previously undocumented SoC-specific compatibles Signed-off-by:
Stanislav Jakubek <stano.jakubek@gmail.com> Reviewed-by:
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by:
-
Andrei Coardos authored
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Reviewed-by:
-
Andrei Coardos authored
This function call is not required because no counterpart platform_get_drvdata() call is present to leverage the private data of the driver. Since the private data is confined to this driver file, external access is not feasible. The use of this function appears redundant in the current context of the driver's implementation. Reviewed-by:
Andy Shevchenko <andy@kernel.org> Signed-off-by:
-
Andrei Coardos authored
This function call was found to be unnecessary as there is no equivalent platform_get_drvdata() call, to access the private data of the driver. Also, the private data is defined in this driver, so there is no risk of it being accessed outside of this driver file. Reviewed-by:
-
- Jul 29, 2023
-
-
Andrei Coardos authored
The platform_set_drvdata() call was never used, ever since the driver was originally added. It looks like this copy+paste left-over. Possibly the author copied from a driver that had this line, but also had a remove hook. Reviewed-by:
Baolin Wang <baolin.wang@linux.alibaba.com> Signed-off-by:
-
Andrei Coardos authored
The platform_set_drvdata() isn't needed for anything. The function is a simple setter that doesn't change anything in the code. That is because there isn't a get function and since it has no dependencies it can be removed. Reviewed-by:
-
Andrei Coardos authored
The platform_set_drvdata() was needed when the driver had an explicit remove function. That function got removed a while back, so we don't need to keep a pointer (on 'dev->driver_data') for the private data of the driver anymore. Reviewed-by:
-
Alexandru Ardelean authored
The platform_set_drvdata() was needed when the driver had an explicit remove function. That function got removed a while back, so we don't need to keep a pointer (on 'dev->driver_data') for the private data of the driver anymore. Signed-off-by:
Linus Walleij <linus.walleij@linaro.org> Signed-off-by:
-
Alexander Stein authored
This is a gpio-controller, so gpio-line-names should be allowed as well. stmpe2403 supports up to 24 GPIOs. Signed-off-by:
Alexander Stein <alexander.stein@ew.tq-group.com> Reviewed-by:
-
Ruan Jinjie authored
There is no need to call the dev_err_probe() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. Signed-off-by:
Ruan Jinjie <ruanjinjie@huawei.com> Reviewed-by:
-
Okan Sahin authored
The DS4520 is a 9-bit nonvolatile (NV) I/O expander. It offers users a digitally programmable alternative to hardware jumpers and mechanical switches that are being used to control digital logic node. Signed-off-by:
Okan Sahin <okan.sahin@analog.com> Signed-off-by:
-
Okan Sahin authored
Add ADI DS4520 devicetree document. Signed-off-by:
-
Ruan Jinjie authored
There is no need to call the dev_err_probe() function directly to print a custom message when handling an error from platform_get_irq() function as it is going to display an appropriate error message in case of a failure. And the code to handle bank->irq = 0 is redundant because platform_get_irq() do not return 0. Signed-off-by:
-
- Jul 27, 2023
-
-
William Breathitt Gray authored
The 104-DIO-48E features an 8254 Counter/Timer chip providing three counter/timers which can be used for frequency measurement, frequency output, pulse width modulation, pulse width measurement, event count, etc. The counter/timers use the same addresses as PPI 0 (addresses 0x0 to 0x3), so a raw_spinlock_t is used to synchronize operations between the two regmap mappings to prevent clobbering. Reviewed-by:
William Breathitt Gray <william.gray@linaro.org> Signed-off-by:
-
Peng Fan authored
Add i.MX8QM/DXL gpio compatible which is compatible with i.MX35. Signed-off-by:
Peng Fan <peng.fan@nxp.com> Acked-by:
-
Andy Shevchenko authored
Driver is so simple, yet there was a room for mistakes. Reduce their appearance in the future by enabling COMPILE_TEST option. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by:
Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> # build-tested Signed-off-by:
-
Andy Shevchenko authored
Replace the GPLv2 boilerplate text with a nice and short SPDX header. Signed-off-by:
-
Andy Shevchenko authored
We have a temporary variable to keep pointer to struct device. Utilise it inside the ->probe() implementation. Signed-off-by:
-
Andy Shevchenko authored
There is nothing in the driver that requires OF APIs, make the driver OF independent. Signed-off-by:
-
Andy Shevchenko authored
Fix English spelling and grammar in the comments. While at it, fix the MODULE_AUTHOR() email address format. Reported-by:
-
Andy Shevchenko authored
Add missing platform_device.h that used to be implied by of_device.h. While at it, sort headers alphabetically for better maintenance. Reported-by:
Rob Herring <robh@kernel.org> Acked-by:
-
- Jul 25, 2023
-
-
Samuel Holland authored
This can reduce the kernel image size in multiplatform configurations. Acked-by:
Palmer Dabbelt <palmer@rivosinc.com> Reviewed-by:
Samuel Holland <samuel.holland@sifive.com> Signed-off-by:
-
Samuel Holland authored
Do not parse the devicetree again when the data is already available from the IRQ subsystem. This follows the example of the ThunderX and X-Gene GPIO drivers. The ngpio check is needed to avoid a possible out-of-bounds read. Signed-off-by:
-
Samuel Holland authored
of_irq_count(), or eqivalently platform_irq_count(), simply looks up successively-numbered IRQs until that fails. Since this driver needs to look up each IRQ anyway to get its virq number, use that existing loop to count the IRQs at the same time. The check against SIFIVE_GPIO_MAX functioned as a bounds check for chip->irq_number. That is now handled by the loop condition. Signed-off-by:
-
Samuel Holland authored
There is no need to convert dev->of_node back to a fwnode_handle. Signed-off-by:
-
Geert Uytterhoeven authored
If CONFIG_PM=n (e.g. m68k/allmodconfig): drivers/gpio/gpio-mxc.c:612:12: error: ‘mxc_gpio_runtime_resume’ defined but not used [-Werror=unused-function] 612 | static int mxc_gpio_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/gpio/gpio-mxc.c:602:12: error: ‘mxc_gpio_runtime_suspend’ defined but not used [-Werror=unused-function] 602 | static int mxc_gpio_runtime_suspend(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~~ Fix this by using the non-SET *_PM_OPS to configure the dev_pm_ops callbacks, and by wrapping the driver.pm initializer insider pm_ptr(). As NOIRQ_SYSTEM_SLEEP_PM_OPS() uses pm_sleep_ptr() internally, the __maybe_unused annotations for the noirq callbacks are no longer needed, and can be removed. Fixes: 3283d820 ("gpio: mxc: add runtime pm support") Reported-by:<noreply@ellerman.id.au> Signed-off-by:
Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by:
-
- Jul 20, 2023
-
-
Krzysztof Kozlowski authored
Allow the GPIO controller subnode to define GPIO names. Already used in at least on DTS: bitmain/bm1880-sophon-edge.dtb: gpio@50027000: gpio-controller@0: 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+' Signed-off-by:
Serge Semin <fancer.lancer@gmail.com> Acked-by:
-
Andrew Davis authored
Use devm version of gpiochip add function to handle removal for us. While here update copyright and module author. Signed-off-by:
Andrew Davis <afd@ti.com> Reviewed-by:
-
- Jul 19, 2023
-
-
Andy Shevchenko authored
The pdev member is assigned and not used, drop it. Signed-off-by:
-
Andrei Coardos authored
The platform_set_drvdata() call was never used, ever since the driver was originally added. It looks like this copy+paste left-over. Possibly the author copied from a driver that had this line, but also had a remove hook. Reviewed-by:
-
Andy Shevchenko authored
There is nothing in the driver that requires OF APIs, make the driver OF independent. Signed-off-by:
-
Rob Herring authored
The DT of_device.h and of_platform.h date back to the separate of_platform_bus_type before it as merged into the regular platform bus. As part of that merge prepping Arm DT support 13 years ago, they "temporarily" include each other. They also include platform_device.h and of.h. As a result, there's a pretty much random mix of those include files used throughout the tree. In order to detangle these headers and replace the implicit includes with struct declarations, users need to explicitly include the correct includes. Signed-off-by:
Romain Perier <romain.perier@gmail.com> Signed-off-by:
-
Asmaa Mnebhi authored
bgpio_init() uses "sz" argument to populate ngpio, which is not accurate. Instead, read the "ngpios" property from the DT and if it doesn't exist, use the "sz" argument. With this change, drivers no longer need to overwrite the ngpio variable after calling bgpio_init(). If the "ngpios" property is specified, bgpio_bits is calculated as the round up value of ngpio. At the moment, the only requirement specified is that the round up value must be a multiple of 8 but it should also be a power of 2 because we provide accessors based on the bank size in bgpio_setup_accessors(). Signed-off-by:
Asmaa Mnebhi <asmaa@nvidia.com> Reviewed-by:
-
- Jul 13, 2023
-
-
Bartosz Golaszewski authored
After adding the missing notifier.h header, let's order all includes alphabetically. Suggested-by:
-
Bartosz Golaszewski authored
It was supposed to say 'for' not 'fo'. Signed-off-by:
-
- Jul 10, 2023
-
-
Samuel Holland authored
Each pin drives a separate interrupt in the parent IRQ domain, so there is no need to set IRQCHIP_MASK_ON_SUSPEND. Signed-off-by:
-
Andy Shevchenko authored
Replace open coded variant of gpiochip_irqchip_add_allocated_domain() in gpiochip_add_irqchip(). Signed-off-by:
-
