- Mar 06, 2018
-
-
Rinkle Jain authored
Replace line ending with '(' with function parameters to resolve style issue found by checkpath. Signed-off-by:Rinkle Jain <rinklejain96@gmail.com> Acked-by:
Julia Lawall <julia.lawall@lip6.fr> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Santha Meena Ramamoorthy authored
Remove unnecessary parentheses around variables to conform to the Linux kernel coding style. Issue found using checkpatch. Signed-off-by:
Santha Meena Ramamoorthy <santhameena13@gmail.com> Acked-by:
-
Dafna Hirschfeld authored
Replace 'unsigned' with 'unsigned int' to improve readability. Issues found with checkpatch.pl Signed-off-by:
Dafna Hirschfeld <dafna3@gmail.com> Acked-by:
-
Dafna Hirschfeld authored
Replace 'const char*' arrays with 'const char * const' since the values in the arrays are not changed. Issues found with checkpatch.pl Signed-off-by:
-
Dafna Hirschfeld authored
Replace comparison to NULL with a 'not' operator. Issue found with checkpatch. Signed-off-by:
-
Arushi Singhal authored
Replace "dont" with "don't". "Dont" is not same as "Do not" or "Don't". Signed-off-by:
Arushi Singhal <arushisinghal19971997@gmail.com> Acked-by:
-
Arushi Singhal authored
This patch replace "to to" with "to". Signed-off-by:
-
Arushi Singhal authored
This patch replace "be be" with "be". Signed-off-by:
-
Arushi Singhal authored
Replace "dont" with "don't". "Dont" is not same as "Do not" or "Don't". Signed-off-by:
-
Santha Meena Ramamoorthy authored
Match alignment with the open parenthesis to conform to the Linux kernel coding style. Issue found using checkpatch. Signed-off-by:
Samuel Thibault <samuel.thibault@ens-lyon.org> Signed-off-by:
-
- Mar 02, 2018
-
-
Bogdan Purcareata authored
Some functions and associated structures are not used by current code, so remove them. Signed-off-by:
Bogdan Purcareata <bogdan.purcareata@nxp.com> Signed-off-by:
-
Quytelda Kahja authored
This driver defined constants FRAME_TYPE_* to represent frame control field codes; however, these constants are already defined in the header 'linux/ieee80211.h' as IEEE80211_STYPE_*. This change removes the locally defined constants and substitutes the kernel's constants. Signed-off-by:
Quytelda Kahja <quytelda@tamalin.org> Reviewed-by:
Tobin C. Harding <me@tobin.cc> Signed-off-by:
-
Quytelda Kahja authored
This driver defined constants BSS_CAP_* to represent WLAN capability codes; however, these constants are already defined in the header 'linux/ieee80211.h' as WLAN_CAPABILITY_*. This change removes the locally defined constants and substitutes the kernel's constants. Signed-off-by:
-
Quytelda Kahja authored
The code that generates a WLAN capability mask is repeated in five functions. This change refactors that code into a new function, which is called now in each of those functions. Signed-off-by:
-
Quytelda Kahja authored
SSID_MAX_SIZE is a constant defined locally in ks_hostif.h, but it should be replaced with IEEE80211_MAX_SSID_LEN from the kernel's 802.11 header, of which it is just a copy. Signed-off-by:
-
Quytelda Kahja authored
The case statement in get_ap_information() should not use literal integers to parse information element IDs when these values are provided by name in 'enum ieee80211_eid' in the header 'linux/ieee80211.h'. Signed-off-by:
-
Ivan Safonov authored
Custom AES decrypt implementation replaced with lib80211 library. Signed-off-by:
Ivan Safonov <insafonov@gmail.com> Signed-off-by:
-
Colin Ian King authored
The error variable ret is currently a u8 and so two comparisons to see if an error return is less than zero will always be false because ret is unsigned. Fix this by making ret an int. Fixes: 554c0a3a ("staging: Add rtl8723bs sdio wifi driver") Signed-off-by:
Colin Ian King <colin.king@canonical.com> Signed-off-by:
-
Jeremy Fertic authored
Remove unnecessary blank lines found using checkpatch.pl script. Signed-off-by:
Jeremy Fertic <jeremyfertic@gmail.com> Signed-off-by:
-
Fengguang Wu authored
Fixes: 1628e2e4dc76 ("staging: fsl-mc/dpio: allow the driver to compile multi-arch") Signed-off-by:Fengguang Wu <fengguang.wu@intel.com> Signed-off-by:
-
Ioana Radulescu authored
The DPAA2 Ethernet driver incorrectly assumes virtual addresses are always 64b long, which causes compiler errors when building for a 32b platform. Fix this by using explicit casts to uintptr_t where necessary. Signed-off-by:
Ioana Radulescu <ruxandra.radulescu@nxp.com> Signed-off-by:
-
Ioana Radulescu authored
Drop dependency on ARCH_LAYERSCAPE (which in turn depends on ARM64), thus allowing this driver to compile on all architectures supported by the fsl-mc bus driver. This was compile tested on: - powerpc (corenet_basic_defconfig, ppc64_defconfig) - x86 (i386_defconfig, x86_64_defconfig, needs CONFIG_OF) - arm64 (defconfig) Signed-off-by:
-
Greg Kroah-Hartman authored
With the zillion different compilers out there, never use -Werror, otherwise your code will end up breaking the build for odd reasons. Like now, if this driver is enabled, it breaks the build due to a function that could be marked static. So it's obvious no one is even paying attention to this driver :( Cc: Ioana Radulescu <ruxandra.radulescu@nxp.com> Signed-off-by: -
Ioana Radulescu authored
The DPIO driver incorrectly assumes virtual addresses are always 64b long, which causes compiler errors when building for a 32b platform. Fix this by using explicit casts to uintptr_t where necessary. Signed-off-by:
-
Colin Ian King authored
Currently the allocation of priv->oldaddr is not null checked which will lead to subsequent errors when accessing priv->oldaddr. Fix this with a null pointer check and a return of -ENOMEM on allocation failure. Detected with Coccinelle: drivers/staging/rtl8192u/r8192U_core.c:1708:2-15: alloc with no test, possible model on line 1723 Fixes: 8fc8598e ("Staging: Added Realtek rtl8192u driver to staging") Signed-off-by:
-
Ajay Singh authored
Fix "Avoid camelCase" issue found by checkpatch.pl script. Signed-off-by:
Ajay Singh <ajay.kathat@microchip.com> Signed-off-by:
-
Ajay Singh authored
Move the same #define from multiple '.c' files to common header file. Instead of having same macro in different '.c' files, now kept in common '.h' file. Signed-off-by:
-
Ajay Singh authored
Refactor wilc_wlan_handle_txq() to fix 'line over 80 char' issue found by checkpatch.pl script. Signed-off-by:
-
Ajay Singh authored
Rename label name starting with '_' to follow as per linux coding style. Signed-off-by:
-
Ajay Singh authored
Refactor wilc_wlan_handle_txq() by removing unnecessary while(0) loop. "Line over 80 char" issues in wilc_wlan_handle_txq() are fix by reducing extra leading tab. Signed-off-by:
-
Quytelda Kahja authored
The function pointer 'complete' in 'struct mbo' should use an identifier for its argument. Signed-off-by:
-
Quytelda Kahja authored
It isn't necessary for the driver to log out-of-memory errors, so these have been removed and the functions simply return -ENOMEM. Signed-off-by:
-
Santha Meena Ramamoorthy authored
Move logical continuation '&&' to the previous line to conform to the Linux kernel coding style. Issue found using checkpatch. Signed-off-by:
-
Santha Meena Ramamoorthy authored
Replace NULL comparison of the variable with just the variable name to conform to the Linux kernel coding style. Issue found using checkpatch. Signed-off-by:
-
Santha Meena Ramamoorthy authored
Add trailing */ on a separate line for block comments to conform to the Linux kernel coding style. Issue found using checkpatch. Signed-off-by:
-
Dafna Hirschfeld authored
Use kmemdup instead of kzalloc and memcpy to simplify the code. Issue found with coccicheck. Signed-off-by:
-
- Feb 27, 2018
-
-
NeilBrown authored
If lstcon_test_add sets 'ret' (passed by reference) to 1, then lst_test_add_ioctl() ignores the return value. This isn't justified - the return value must be zero for 'ret' to be meaningful. Signed-off-by:
NeilBrown <neilb@suse.com> Reviewed-by:
James Simmons <jsimmons@infradead.org> Signed-off-by:
-
NeilBrown authored
Commit 8f18c8a4 ("staging: lustre: lmv: separate master object with master stripe") changed how lmo_root inodes were managed, particularly when LMV_HASH_FLAG_MIGRATION is not set. Previously lsm_md_oinfo[0].lmo_root was always a borrowed inode reference and didn't need to by iput(). Since the change, that special case only applies when LMV_HASH_FLAG_MIGRATION is set In the upstream (lustre-release) version of this patch [Commit 60e07b972114 ("LU-4690 lod: separate master object with master stripe")] the for loop in the lmv_unpack_md() was changed to count from 0 and to ignore entry 0 if LMV_HASH_FLAG_MIGRATION is set. In the patch that got applied to Linux, that change was missing, so lsm_md_oinfo[0].lmo_root is never iput(). This results in a "VFS: Busy inodes" warning at unmount. Fixes: 8f18c8a4 ("staging: lustre: lmv: separate master object with master stripe") Signed-off-by:
-
NeilBrown authored
lov - the logical object volume manager - is responsible for striping data across multiple volumes. So when it is given a request, it creates one or more sub-requests, one for each target volume. Each sub_io request has a sub_env environment which it operates in. When lov_io_data_version_end() calls lov_io_end_wrapper() to wait for and close off a sub_io, it passes the wrong environment. This causes an LINVRNT() to fail in cl2osc_io(), and may cause other problems. This patch changes the call to use ->sub_env, much like other code in the same file. Fixes: f0cf21ab ("staging: lustre: clio: add CIT_DATA_VERSION and remove IOC_LOV_GETINFO") Signed-off-by:
-
Greg Kroah-Hartman authored
This reverts commit 444634f5 . Should not be going through my tree, sorry about that. Reported-by:
Hans Verkuil <hverkuil@xs4all.nl> Cc: Quytelda Kahja <quytelda@tamalin.org> Signed-off-by:
-
