- Nov 14, 2009
-
-
William Allen Simpson authored
Define two symbols needed in both kernel and user space. Remove old (somewhat incorrect) kernel variant that wasn't used in most cases. Default should apply to both RMSS and SMSS (RFC2581). Replace numeric constants with defined symbols. Stand-alone patch, originally developed for TCPCT. Signed-off-by:
<William.Allen.Simpson@gmail.com> Acked-by:
Eric Dumazet <eric.dumazet@gmail.com> Signed-off-by:
David S. Miller <davem@davemloft.net>
-
Patrick McHardy authored
Both vlan and macvlan devices usually don't use a qdisc and immediately queue packets to the underlying device. Propagate transmission state of the underlying device to the upper layers so they can react on congestion and/or inform the sending process. Signed-off-by:
Patrick McHardy <kaber@trash.net> Signed-off-by:
-
Patrick McHardy authored
Currently the ->ndo_hard_start_xmit() callbacks are only permitted to return one of the NETDEV_TX codes. This prevents any kind of error propagation for virtual devices, like queue congestion of the underlying device in case of layered devices, or unreachability in case of tunnels. This patches changes the NET_XMIT codes to avoid clashes with the NETDEV_TX codes and changes the two callers of dev_hard_start_xmit() to expect either errno codes, NET_XMIT codes or NETDEV_TX codes as return value. In case of qdisc_restart(), all non NETDEV_TX codes are mapped to NETDEV_TX_OK since no error propagation is possible when using qdiscs. In case of dev_queue_xmit(), the error is propagated upwards. Signed-off-by:
-
Joe Perches authored
Untested, no hardware Signed-off-by:
Joe Perches <joe@perches.com> Signed-off-by:
-
- Nov 12, 2009
-
-
Arnd Bergmann authored
We have two implementations of the compat_ioctl handling for ATM, the one that we have had for ages in fs/compat_ioctl.c and the one added to net/atm/ioctl.c by David Woodhouse. Unfortunately, both versions are incomplete, and in practice we use a very confusing combination of the two. For ioctl numbers that have the same identifier on 32 and 64 bit systems, we go directly through the compat_ioctl socket operation, for those that differ, we do a conversion in fs/compat_ioctl.c. This patch moves both variants into the vcc_compat_ioctl() function, while preserving the current behaviour. It also kills off the COMPATIBLE_IOCTL definitions that we never use here. Doing it this way is clearly not a good solution, but I hope it is a step into the right direction, so that someone is able to clean up this mess for real. Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Cc: Eric Dumazet <eric.dumazet@gmail.com> Cc: David Woodhouse <dwmw2@infradead.org> Signed-off-by:
-
Arnd Bergmann authored
Handling for SIOCSHWTSTAMP is broken on architectures with a split user/kernel address space like s390, because it passes a real user pointer while using set_fs(KERNEL_DS). A similar problem might arise the next time somebody adds code to dev_ifsioc. Split up dev_ifsioc into three separate functions for SIOCSHWTSTAMP, SIOC*IFMAP and all other numbers so we can get rid of set_fs in all potentially affected cases. Signed-off-by:
-
Ben Dooks authored
Add support for Wake on LAN (WOL) reception and waking the device up from this signal via the ethtool interface. Currently we are only supporting the magic-packet variant of wakeup. WOL is enabled by specifying a second interrupt resource to the driver which indicates where the interrupt for the WOL is being signalled. This then enables the necessary ethtool calls to leave the device in a state to receive WOL frames when going into suspend. Signed-off-by:
Ben Dooks <ben@simtec.co.uk> Signed-off-by:
Simtec Linux Team <linux@simtec.co.uk> Signed-off-by:
-
Ali Gholami Rudi authored
The values of r_idx and rx_ring are not used after the last time they are set in ixgbe_msix_clean_rx(), so they can be removed. Signed-off-by:
Ali Gholami Rudi <ali@rudi.ir> Acked-by:
Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com> Signed-off-by:
-
stephen hemminger authored
There is no reason for this lock to be reader/writer since the reader only has lock held for a very brief period. The overhead of read_lock is more expensive than spinlock. Compile tested only, I am not a decnet user. Signed-off-by:
Stephen Hemminger <shemminger@vyatta.com> Signed-off-by:
-
stephen hemminger authored
Add missing locking in the case of auto binding to the default device. The address list might change while this code is looking at the list. Compile tested only, I am not a decnet user. Signed-off-by:
-
stephen hemminger authored
The full_name_hash function does not produce well distributed values in the lower bits, so most code uses hash_32() to fold it. This is really a bug introduced when name hashing was added, back in 2.5 when I added name hashing. hash_32 is all that is needed since full_name_hash returns unsigned int which is only 32 bits on 64 bit platforms. Also, there is no point in using hash_32 on ifindex, because the is naturally sequential and usually well distributed. Signed-off-by:
-
Ron Mercer authored
Signed-off-by:
Ron Mercer <ron.mercer@qlogic.com> Signed-off-by:
-
Ron Mercer authored
Change it to match qlge_xxx convention. Signed-off-by:
-
Ron Mercer authored
Force asic to known state at open(). Signed-off-by:
-
Ron Mercer authored
We do not need to change the frame routing to direct all frames to the management fifo during suspend. This is now done by the firmware. Signed-off-by:
-
David S. Miller authored
Noticed by Thomas GLeixner. Signed-off-by: -
Anton Vorontsov authored
Before calling gfar_clean_tx_ring() the driver grabs an irqsave spinlock, and then tries to recycle skbs. But since skb_recycle_check() returns 0 with IRQs disabled, we'll never recycle any skbs. It appears that gfar_clean_tx_ring() and gfar_start_xmit() are mostly idependent and can work in parallel, except when they modify num_txbdfree. So we can drop the lock from most sections and thus fix the skb recycling. Signed-off-by:
Anton Vorontsov <avorontsov@ru.mvista.com> Acked-by:
Kumar Gala <galak@kernel.crashing.org> Signed-off-by:
-
Anton Vorontsov authored
gfar_error() can arrive at the middle of gfar_start_xmit() processing, and so it can trigger transfers of BDs that we don't yet expect to be transmitted. Fix this by locking the tx queues in gfar_error(). Signed-off-by:
-
Anton Vorontsov authored
We obviously want to write a modified 'temp' value back to the register, not the saved IRQ flags. Signed-off-by:
-
Anton Vorontsov authored
commit fba4ed03 ("gianfar: Add Multiple Queue Support") introduced the following build failure: CC gianfar.o gianfar.c: In function 'gfar_restore': gianfar.c:1249: error: request for member 'napi' in something not a structure or union This patch fixes the issue. Signed-off-by:
-
Anton Vorontsov authored
It is OK to poll with disabled IRQs, so remove the warning. Signed-off-by:
-
Anton Vorontsov authored
NAPI drivers try to recycle SKBs in their polling routine, but we generally don't know the context in which the polling will be called, and the skb recycling itself may require IRQs to be enabled. This patch adds irqs_disabled() test to the skb_recycle_check() routine, so that we'll not let the drivers hit the skb recycling path with IRQs disabled. As a side effect, this patch actually disables skb recycling for some [broken] drivers. E.g. gianfar driver grabs an irqsave spinlock during TX ring processing, and then tries to recycle an skb, and that caused the following badness: nf_conntrack version 0.5.0 (1008 buckets, 4032 max) ------------[ cut here ]------------ Badness at kernel/softirq.c:143 NIP: c003e3c4 LR: c423a528 CTR: c003e344 ... NIP [c003e3c4] local_bh_enable+0x80/0xc4 LR [c423a528] destroy_conntrack+0xd4/0x13c [nf_conntrack] Call Trace: [c15d1b60] [c003e32c] local_bh_disable+0x1c/0x34 (unreliable) [c15d1b70] [c423a528] destroy_conntrack+0xd4/0x13c [nf_conntrack] [c15d1b80] [c02c6370] nf_conntrack_destroy+0x3c/0x70 Signed-off-by: -
David S. Miller authored
Reported by Stephen Rothwell: -------------------- Today's linux-next build (x86_64 allmodconfig) produced this warning: net/ipv6/addrconf.c: In function 'inet6_dump_ifinfo': net/ipv6/addrconf.c:3833: warning: unused variable 'err' Introduced by commit 84d2697d ("ipv6: speedup inet6_dump_ifinfo()"). -------------------- Signed-off-by:
-
John W. Linville authored
I may have botched my merge conflict resolution instructions for Dave... Signed-off-by:
John W. Linville <linville@tuxdriver.com> Signed-off-by:
-
David S. Miller authored
Conflicts: drivers/net/wireless/iwlwifi/iwl-1000.c drivers/net/wireless/iwlwifi/iwl-6000.c drivers/net/wireless/iwlwifi/iwl-core.h
-
- Nov 11, 2009
-
-
stephen hemminger authored
Use new function to avoid doing read_lock(). Signed-off-by:
Oliver Hartkopp <oliver@hartkopp.net> Signed-off-by:
-
stephen hemminger authored
This also needs to be optimized for large number of devices. Signed-off-by:
-
stephen hemminger authored
When showing device statistics use RCU rather than read_lock(&dev_base_lock) Compile tested only. Signed-off-by:
-
stephen hemminger authored
This is similar to other cases where for_each_netdev_rcu can be used when gathering information. By inspection, don't have platform or cross-build environment to validate. Signed-off-by:
-
stephen hemminger authored
Use RCU to walk list of network devices in qdisc dump. This could be optimized for large number of devices. Signed-off-by:
-
stephen hemminger authored
Do not need to use read_lock(&dev_base_lock), use RCU instead. Signed-off-by:
-
stephen hemminger authored
This adds an RCU macro for continuing search, useful for some network devices like vlan. Signed-off-by:
-
Brian Haley authored
Change udp6_portaddr_hash() to use ipv6_addr_v4mapped() inline instead of ipv6_addr_type(). Signed-off-by:
Brian Haley <brian.haley@hp.com> Acked-by:
-
Eric Dumazet authored
Use for_each_netdev_rcu() and dont lock dev_base_lock anymore Signed-off-by:
-
Herbert Xu authored
This patch rearranges the SIT DF bit handling using the new IPIP DF code. The only externally visible effect should be the case where PMTU is enabled and the MTU is exactly 1280 bytes. In this case the previous code would send packets out with DF off while the new code would set the DF bit. This is inline with RFC 4213. Signed-off-by:
Herbert Xu <herbert@gondor.apana.org.au> Thanks, Signed-off-by:
-
Eric Dumazet authored
Apparently, inet6_dump_addr() is not able to handle more than 64 ipv6 addresses per device. We must break from inner loops in case skb is full, or else cursor is put at the end of list. Signed-off-by:
-
Eric Dumazet authored
When handling large number of netdevice, inet6_dump_ifinfo() is very slow because it has O(N^2) complexity. Instead of scanning one single list, we can use the 256 sub lists of the dev_index hash table, and RCU lookups. Signed-off-by:
-
Cyrill Gorcunov authored
Use guard DECLARE_SOCKADDR in a few more places which allow us to catch if the structure copied back is too big. Signed-off-by:
Cyrill Gorcunov <gorcunov@openvz.org> Signed-off-by:
-
Ben Hutchings authored
Some usbnet drivers update link state while others do not due to hardware limitations. Add a flag to distinguish those that do, and set the link down initially for their devices. This is intended to fix this bug: http://bugs.debian.org/444043 Signed-off-by:
Ben Hutchings <ben@decadent.org.uk> Signed-off-by:
-
Marin Mitov authored
Use DMA_BIT_MASK(44) instead of deprecated DMA_44BIT_MASK Signed-off-by:
Marin Mitov <mitov@issp.bas.bg> Signed-off-by:
-
