- Feb 26, 2016
-
-
Bhumika Goyal authored
Use list_for_each_entry instead of list_for_each and list_entry as it simplifies the code. Done using coccinelle: @@ type T,T2; identifier I1,I2; expression e1,e2; iterator name list_for_each_entry; iterator name list_for_each; @@ - T *I1; ... - list_for_each(I1,e1) + list_for_each_entry(I2,e1,e2) { ...when!=T *I1; - I2=list_entry(I1,T2,e2); ... } ...when!=I2; @@ type T,T2,T3; identifier I1,I2,I3; expression e1,e2; @@ - T *I1; + T3 *I3; ... - list_for_each(I1,e1) + list_for_each_entry(I3,e1,e2) { ...when!=T *I1; - T3 *I3=list_entry(I1,T2,e2); ... } ...when!=I3; Signed-off-by:Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Anchal Jain authored
For single statment of if not required a braces {}. Signed-off-by:Anchal Jain <anchalj109@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Amitoj Kaur Chawla authored
Replace comparison with zero with ! operator. Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Amitoj Kaur Chawla authored
Removed unncessary braces from the if-else block to remove the following checkpatch.pl warning: WARNING: braces {} are not necessary for any arm of this statement Signed-off-by:Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Amitoj Kaur Chawla authored
Use swap() function instead of using a temporary variable for swapping two variables. The Coccinelle semantic patch used to make this change is as follows: //<smpl> @@ type T; T a,b,c; @@ - a = b; - b = c; - c = a; + swap(b, c); //<smpl> Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Dmitry Eremin authored
NFS can ask to encode dentries that are not connected to the root. The fix check for parent is NULL and encode a file handle accordingly. Reviewed-on: http://review.whamcloud.com/8347 Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-4231 Reviewed-by:
Fan Yong <fan.yong@intel.com> Reviewed-by:
James Simmons <uja.ornl@gmail.com> Reviewed-by:
Jian Yu <jian.yu@intel.com> Signed-off-by:
Dmitry Eremin <dmitry.eremin@intel.com> Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Acked-by:
Jeff Layton <jlayton@poochiereds.net> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Amitoj Kaur Chawla authored
ll_iget() has been modified to always return NULL in case of error and not a ERR_PTR. Consequently, remove unnecessary IS_ERR tests as now ll_iget() function can never return a ERR_PTR. Additionally, reinitialising root and inode to NULL has been removed since they have already been tested for the same. Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
ll_orphan_dentry_list and ll_conn_chain are not used and could be removed. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
obd_register_page_removal_cb, obd_unregister_page_removal_cb obd_register_lock_cancel_cb, obd_unregister_lock_cancel_cb Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
There were some messages in Lustre that ended with a space followed by a newline which is pointless, so remove the extra spaces. Found with checkpatch. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
none look like bugs or bugs-inducing, mostly just off by a couple of spaces all around. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch fixes "Block comments use a trailing */ on a separate line" warnings from checkpatch. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This fixes most of the "Block comments use a trailing */ on a separate line" checkpatch warnings, also some slight reformats of structures or comments at places. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This file mostly contains various on the wire data and got significantly mangled in transition. This patch rectifies the situation somewhat. Also fixes the comment style for block comments. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
Capabilities code was the only user and it is long gone. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This code has been commented out since end of 2012, so it's clearly not needed here. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
last_rcvd (last received) is a special server-side file on the Lustre FS that stores information about server filesystem and also list of connected clients and their state. There's no point in having any of tha ton the client, though. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
Despite it's name struct obd_export could exist on the client too (used for reverse exports), but all the actual server bits are not needed there, so could be dropped. This is mostly various target-related stuff. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
struct idx_info, struct lu_idxpage, lustre_swab_idx_info, request formats and related defines are all unused and could only happen for between-servers communications, so remove them from the client code. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
So no need to see if they are. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
No need to check for it. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
These server-only structures and some supporting defines are unused on the client. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
It's only used for communications between servers. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
QUOTABLOCK_BITS, QUOTABLOCK_SIZE and toqb are only used on the server and are copied from kernel code anyway. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
These defines are only used on the servers to determine what connect flags corresponding servers support: MDT_CONNECT_SUPPORTED OST_CONNECT_SUPPORTED MGS_CONNECT_SUPPORTED ECHO_CONNECT_SUPPORTED Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
These values cannot be seen on the client so we probably should not even be aware of them on the client. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Oleg Drokin authored
This patch removes remaining several places that still had that extra paragraph included in Lustre code. Signed-off-by:
Oleg Drokin <green@linuxhacker.ru> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-