- Mar 08, 2012
-
-
Rob Clark authored
Get the supported formats for a plane from ovl's supported_modes bitmask. Signed-off-by:
Rob Clark <rob@ti.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Grant Grundler authored
tsl2563 probe function has two minor issues with it's error handling paths: 1) it is silent (did not report errors to dmesg) 2) did not return failure code (mixed up use of ret and err) and two major issues: 3) goto fail2 would corrupt a free memory pool ("double free") 4) device registration failure did NOT cancel/flush delayed work. (and thus dereference a freed data structure later) The "double free" is subtle and was introduced with this change: Author: Jonathan Cameron <jic23@cam.ac.uk> Date: Mon Apr 18 12:58:55 2011 +0100 staging:iio:tsl2563 take advantage of new iio_device_allocate private data. Originally, chip was allocated seperately. Now it's appended to the indio_dev by iio_allocate_device(sizeof(*chip)). So we only need one kfree call as well (in iio_free_device()). Gory details of tracking this down are here: http://crosbug.com/26819 Despite iio_device_registration failing, system can at least now boot. Will follow up with a fix to "double register : in_intensity_both_raw" error that is included in the bug report. Signed-off-by:Grant Grundler <grundler@chromium.org> Acked-by:
Jonathan Cameron <jic23@kernel.org> Reviewed-by:
Bryan Freed <bfreed@chromium.org> Reviewed-by:
Benson Leung <bleung@chromium.org> Signed-off-by:
-
Larry Finger authored
The patch 2080913e: "staging: r8712u: Fix regression caused by commit 8c213fa5 " from Feb 25, 2012, leads to the following Smatch complaint: drivers/staging/rtl8712/usb_intf.c:629 r871xu_dev_remove() warn: variable dereferenced before check 'padapter' (see line 625) The fix is to move the new statements inside the block where padapter is not NULL. Reported-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Seth Jennings authored
This patch removes the SPARSEMEM from the zsmalloc Kconfig Signed-off-by:
Seth Jennings <sjenning@linux.vnet.ibm.com> Acked-by:
Nitin Gupta <ngupta@vflare.org> Signed-off-by:
-
Seth Jennings authored
This patch ensures that the value of ZS_MIN_ALLOC_SIZE, for the PAGE_SIZE and MAX_PHYSMEM_BITS on the system, allows for all possible object ids in the lowest storage class to be encoded in the object handle. Signed-off-by:
-
Seth Jennings authored
This patch provides a way to determine or "set a reasonable value for" MAX_PHYSMEM_BITS in the case that it is not defined (i.e. !SPARSEMEM) Signed-off-by:
-
Seth Jennings authored
This patch moves where max_zspage_order is declared and changes its meaning. "Order" typically implies 2^order of something; however, it is currently being used as the "maximum number of single pages in a zspage". To add clarity, ZS_MAX_ZSPAGE_ORDER is now used to calculate ZS_MAX_PAGES_PER_ZSPAGE, which is 2^ZS_MAX_ZSPAGE_ORDER and is the upper bound on the number of pages in a zspage. Signed-off-by:
-
Seth Jennings authored
This patch moves the definitions of _PFN_BITS, OBJ_INDEX_BITS and OBJ_INDEX_MASK from zsmalloc-main.c to zsmalloc_int.h They will be needed to determine ZS_MIN_ALLOC_SIZE in the next patch Signed-off-by:
-
Seth Jennings authored
zcache cannot currently be loaded as a module. However the Kconfig allows it to be built as a module; something that the user probably does not intend since the module is not loadable. This patch switches zcache from a tristate to a bool in the Kconfig Signed-off-by:
Dan Magenheimer <dan.magenheimer@oracle.com> Signed-off-by:
-
Lars-Peter Clausen authored
commit e553f182 ("staging: iio: core: Introduce debugfs support, add support for direct register access") added a '#if defined(CONFIG_DEBUG_FS)' around iio_read_channel_ext_info and iio_write_channel_ext_info causing the following compile error if CONFIG_DEBUG_FS is not defined. drivers/staging/iio/industrialio-core.c:621:11: error: 'iio_read_channel_ext_info' undeclared (first use in this function) drivers/staging/iio/industrialio-core.c:623:11: error: 'iio_write_channel_ext_info' undeclared (first use in this function) This patch fixes the issue by moving the functions out of the '#if defined(CONFIG_DEBUG_FS)' section again. Reported-by:
Randy Dunlap <rdunlap@xenotime.net> Signed-off-by:
Lars-Peter Clausen <lars@metafoo.de> Acked-by:
-
Greg Kroah-Hartman authored
Fix compiler warning about the type of the module parameter. Cc: San Mehat <san@google.com> Signed-off-by: -
Paul E. McKenney authored
The lowmemorykiller registers an atomic notifier for notfication of when the task is freed. From this atomic notifier callback, it removes the atomic notifier via task_free_unregister(). This is incorrect because atomic_notifier_chain_unregister() calls syncronize_rcu(), which can sleep, which shouldn't be done from an atomic notifier. Fix this by registering the notifier during init, and only unregister it if the lowmemorykiller is unloaded. Rebased to -next by Paul E. McKenney. Rebased to -next again by Anton Vorontsov. Signed-off-by:
Rabin Vincent <rabin.vincent@stericsson.com> Signed-off-by:
Christian Bejram <christian.bejram@stericsson.com> Signed-off-by:
Paul E. McKenney <paulmck@linux.vnet.ibm.com> Reported-by:
John Stultz <john.stultz@linaro.org> Signed-off-by:
Anton Vorontsov <anton.vorontsov@linaro.org> Cc: stable <stable@vger.kernel.org> Signed-off-by:
-
Zhengwang Ruan authored
GCC warns that module_param_named() indirectly returns a bool type value which is different from 'int' type binder_debug_no_lock declared. Change it to bool because it is a internal switch for debugging. Signed-off-by:
Zhengwang Ruan <ruan.zhengwang@gmail.com> Signed-off-by:
-
- Mar 03, 2012
-
-
Greg Kroah-Hartman authored
The kernel already has a debug allocator, no need to have one unique to a single driver. So delete it, replace with kfree, kmalloc, and, in a few places that need it, kzalloc(). Cc: Chris Kelly <ckelly@ozmodevices.com> Signed-off-by: -
Kevin McKinney authored
Memory is being allocated by kmalloc and stored in variable pstAddIndication. However, this memory is not being freed in all cases. Therefore, this patch frees it on several exit paths. This patch also removes a whitespace. Signed-off-by:
Kevin McKinney <klmckinney1@gmail.com> Signed-off-by:
-
Martin Krause authored
It seems the USB device ID 0bda:8192 is wrongly assigned to the RTL8192SU chip and not to the RTL8191SU chip in the USB database. So this patch moves this device ID from the rtl8192u staging driver to the rtl8712 staging driver. This patch was tested with a Radicom WIFIHU embedded wireless module with a RTL8191SU chip and the USB device ID 0bda:8192. Without the patch the rtl8192u driver claims this device, but it does not work. With the patch the rtl8712 driver services this device and it works. Signed-off-by:
Martin Krause <martin.krause@tqs.de> Acked-by:
-
Martin Krause authored
Remove copies of the double USB device IDs: - 0bda:8172 - 0bda:8174 Signed-off-by:
-
Michael Hennerich authored
No functional changes. Signed-off-by:
Michael Hennerich <michael.hennerich@analog.com> Acked-by:
-
Michael Hennerich authored
Drivers may not need setup_ops at all, so let the core supply some empty ops. Signed-off-by:
-
Michael Hennerich authored
Changes since V1: Exclude iio debugfs code in case CONFIG_DEBUG_FS isn't enabled. Introduce helper function iio_get_debugfs_dentry. Document additions to struct iio_dev iio_debugfs_read_reg: Use snprintf. Use a shorter fixed length. Introduce len instead of pointer math. iio_debugfs_write_reg: Fix return value use PT_ERR. Changes since V2: Use debugfs_remove. Fix whitespace damage. Signed-off-by:
-
Justin P. Mattock authored
The below patch fixes some comments and some typos that I have found while reading drivers/staging/iio/* Signed-off-by:
Justin P. Mattock <justinmattock@gmail.com> Signed-off-by:
-
Dan Carpenter authored
app_id comes from the network and can't be trusted. If it's zero then it will lead to a kernel crash. Signed-off-by:
Chris Kelly <ckelly@ozmodevices.com> Signed-off-by:
-
Chris Kelly authored
Added TODO file for ozwpan driver. Signed-off-by:
-
- Mar 01, 2012
-
-
Larry Finger authored
In commit c6dc001f "staging: r8712u: Merging Realtek's latest (v2.6.6). Various fixes", the returned qual.qual member of the iw_statistics struct was changed. For strong signals, this change made no difference; however for medium and weak signals it results in a low signal that shows considerable fluctuation, When using wicd for a medium-strength AP, the value reported in the status line is reduced from 100% to 60% by this bug. This problem is reported in https://bugzilla.kernel.org/show_bug.cgi?id=42826 . Reported-and-tested-by:
Robert Crawford <wrc1944@gmail.com> Signed-off-by:
-
Larry Finger authored
In commit 8c213fa5 "staging: r8712u: Use asynchronous firmware loading", the command to release the firmware was placed in the wrong routine. In combination with the bug introduced in commit a5ee6529 "staging: r8712u: Interface-state not fully tracked", the driver attempts to upload firmware that had already been released. This bug is the source of one of the problems in https://bugs.archlinux.org/task/27996#comment89833 . Tested-by:
Alberto Lago Ballesteros <saniukeokusainaya@gmail.com> Tested-by:
Adrian <agib@gmx.de> Signed-off-by:
-
Larry Finger authored
In commit a5ee6529 "staging: r8712u: Interface-state not fully tracked", the private boolean "bup" was set false when the interface was brought down, as that seemed appropriate. This change has not caused any problems when using NetworkManager or manual control of the device; however, when wicd control is used, there is a locking problem in wpa_supplicant, as shown in https://bugzilla.kernel.org/show_bug.cgi?id=42818. This fix reverts the only code change in commit a5ee6529. My analysis is that "bup" is badly named. In its present form, it seems to indicate the up/down state of the device, but its usage is more consistent with an initialized/uninitialized state. That problem will be addressed in a later patch. Note: Commit 8c213fa5, which introdued asynchronous firmware loading for this driver, exposed this bug to a greater extent. That bug is addressed in the next patch in this series. This bug is also responsible for the bug in https://bugzilla.kernel.org/show_bug.cgi?id=42815. and this bug is also part of the problems discussed at https://bugs.archlinux.org/task/27996#comment89950 . Tested-by:
-
Dan Carpenter authored
In commit 1ca1a92c "Staging: wlan-ng: memsetting the wrong amount of data" I changed the code so we didn't memset() past the end of the msg1.bssid.data[] array. Walter Harms noticed that it was weird that we were setting the len to 6 when there were 7 elements in the array. Pavel Roskin pointed out that the intent of the code was actually to memset() msg1.bssid.data.data[] which is a 6 character array. Reported-by:
Walter Harms <wharms@bfs.de> Reported-by:
Pavel Roskin <proski@gnu.org> Signed-off-by:
-
Jorgyano Vieira authored
The header bc_dts_types is not used, so we can remove it. Signed-off-by:
Jorgyano Vieira <jorgyano@gmail.com> Signed-off-by:
-
Jorgyano Vieira authored
This patch replaces the local includes with the global header. So the the crystalhd.h will be the only header included by the other files. Signed-off-by:
-
Jorgyano Vieira authored
In the crystalhd_cmds.h there was a struct dependence bug: the struct crystalhd_adp (which is declared on crystalhd_lnx.h) is used on the crystalhd_cmd struct, however the crystalhd_lnx.h is never included on crystalhd_cmds.h at all. Including the crystalhd_lnx.h on crystalhd_cmds.h breaks the build, many dependencies error occurrs, most of the type "error: 'struct bar' has no member named 'foo'", so I decided to reorganize the headers by adding a global header. The gobal header crystalhd.h includes all the local headers. The idea is that the crystalhd header will be the only included by the others files, this will avoid the mess of many #include levels. The order of the headers included by crystalhd.h considers the dependencies among the headers. Signed-off-by:
-
Andrew Miller authored
Fixed some coding style issues. Signed-off-by:
Andrew Miller <amiller@amilx.com> Signed-off-by:
-
Johannes Thumshirn authored
Signed-off-by:
Johannes Thumshirn <morbidrsa@googlemail.com> Signed-off-by:
-
Peter Huewe authored
This patch removes a superfluous loop in asus_oled.c The code is equivalent to do{...} while (0) and thus executes the code exactly once -> so we can simply remove the loop. Signed-off-by:Peter Huewe <peterhuewe@gmx.de> Signed-off-by:
-
Tomas Winkler authored
Replace bitfield struct hbm_cmd with simple u8 as we always access the value as whole. This allows us to remove few ugly type casts For possible further uses and documentation purposes we add corresponding bitmask defines Signed-off-by:
Tomas Winkler <tomas.winkler@intel.com> Signed-off-by:
-
Devin J. Pohly authored
~ENODEV is a different number than -ENODEV Signed-off-by:
Devin J. Pohly <djpohly@gmail.com> Signed-off-by:
-
Greg Kroah-Hartman authored
-
Seth Jennings authored
This patch fixes a bug where the zv code writes before the allocated buffer, resulting in system memory corruption. This was introduced during the switch from xvmalloc to zsmalloc. Signed-off-by:
-
Seth Jennings authored
This fixes a type mismatch in the compression code where a size_t pointer was cast to a unsigned int pointer. On little endian archs, there is no issue. However on big endian archs, the value is incorrect, taking the high order bits and truncating the lower order bits. Signed-off-by:
-
Chris Kelly authored
This structure is used in an ioctl definition and was causing the 64-bit PowerPC build to fail. The size of the array in the structure has been reduced to fix this. Signed-off-by:
Stephen Rothwell <sfr@canb.auug.org.au> Signed-off-by:
-
- Feb 25, 2012
-
-
Michael Hennerich authored
The core must not modify available_scan_mask, because it causes problems with drivers where multiple instances of the driver share the same mask set. So make this explicit by marking available scan masks as const. The max1363 driver needs some minor adjustment to accommodate this change. Pull scan mask allocation into a separate function. Signed-off-by:
-
