- Mar 05, 2024
-
-
Shahar Avidar authored
FREQUENCY is not being used, delete its comment. Signed-off-by:
Shahar Avidar <ikobh7@gmail.com> Reviewed-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://lore.kernel.org/r/20240227221204.534131-5-ikobh7@gmail.com Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Shahar Avidar authored
Use HZ_PER_MHZ for a more robust definition. Suggested-by:
-
Shahar Avidar authored
F_OSC is already defined & only used by rf69.c source file. Signed-off-by:
-
Shahar Avidar authored
FIFO_SIZE is being used in both rf69.c & pi433_if.c source files. It is also already defined in rf69.h header file. Signed-off-by:
-
Michael Straube authored
Enum members are usually named all upper case. Rename the members of the enum fsync_state to improve readability and follow the common kernel coding style. Default_Fsync -> DEFAULT_FSYNC HW_Fsync -> HW_FSYNC SW_Fsync -> SW_FSYNC Signed-off-by:
Michael Straube <straube.linux@gmail.com> Tested-by:
Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20240222112723.18428-4-straube.linux@gmail.com Signed-off-by:
-
Michael Straube authored
Rmove empty cases from switch statements to improve readability. All of these empty cases are covered by a default case already. Signed-off-by:
-
Michael Straube authored
Rename the variable rateIndex in the function _rtl92e_update_received_rate_histogram_stats() to avoid camel case. rateIndex -> rate_index Signed-off-by:
-
Colin Ian King authored
Variable hoffset in functions hal_EfuseGetCurrentSize_WiFi and hal_EfuseGetCurrentSize_BT is being assigned a value but it not being read for any useful reason at all. The variable is redundant and can be removed. Cleans up clang scan build warnings for lines 957 and 1050: drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:957:5: warning: variable 'hoffset' set but not used [-Wunused-but-set-variable] Signed-off-by:
Colin Ian King <colin.i.king@gmail.com> Link: https://lore.kernel.org/r/20240304161045.769912-1-colin.i.king@gmail.com Signed-off-by:
-
Meir Elisha authored
Clean dead code from is_same_network() and _rtw_free_network(). Signed-off-by:
Meir Elisha <meir6264@gmail.com> Link: https://lore.kernel.org/r/20240229121445.22257-1-meir6264@gmail.com Signed-off-by:
-
Meir Elisha authored
Remove braces from single statement blocks to improve coding style. Signed-off-by:
-
Dorine Tipo authored
Align the function parameters to silence a checkpatch warning. Signed-off-by:
Dorine Tipo <dorine.a.tipo@gmail.com> Link: https://lore.kernel.org/r/20240305092310.3594-1-dorine.a.tipo@gmail.com Signed-off-by:
-
Philipp Hortmann authored
Remove unused variables ntotalfrag and Seq_Num as they are set and never evaluated. Remove resulting local variables seq, sc and hdr as well. Signed-off-by:
-
Philipp Hortmann authored
Remove unused variables bShortPreamble and fragoffset as they are set and never evaluated. Signed-off-by:
-
Philipp Hortmann authored
Remove unused variables nic_type and RxPower as they are set and never evaluated. Signed-off-by:
-
Philipp Hortmann authored
Remove unused variables fraglength and packetlength as they are set and never evaluated. Signed-off-by:
-
Philipp Hortmann authored
Remove unused variables bIsQosData and RxIs40MHzPacket as they are set and never evaluated. Signed-off-by:
-
Philipp Hortmann authored
Remove unused variable bShift as it is set and never evaluated. Signed-off-by:
-
Philipp Hortmann authored
Remove unused variables Wakeup, Reserved0 and AGC. Signed-off-by:
-
Philipp Hortmann authored
Remove unused variables tsf, beacon_time and Antenna. Signed-off-by:
-
Ricardo B. Marliere authored
Since commit 43a7206b ("driver core: class: make class_register() take a const *"), the driver core allows for struct class to be in read-only memory, so move the fieldbus_class structure to be declared at build time placing it into read-only memory, instead of having to be dynamically allocated at boot time. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Suggested-by:
"Ricardo B. Marliere" <ricardo@marliere.net> Link: https://lore.kernel.org/r/20240301-class_cleanup-staging-v1-1-34db2a5b0eb0@marliere.net Signed-off-by:
-
John Garry authored
The version is same as the default, so don't bother filling it in. Signed-off-by:
John Garry <john.g.garry@oracle.com> Link: https://lore.kernel.org/r/20240222090042.12609-4-john.g.garry@oracle.com Signed-off-by:
-
Moritz C. Weber authored
Reformat function parameters to fix checkpatch check: Increase readability and consistency Signed-off-by:
"Moritz C. Weber" <mo.c.weber@gmail.com> Link: https://lore.kernel.org/r/20240219112234.8673-3-mo.c.weber@gmail.com Signed-off-by:
-
Moritz C. Weber authored
Remove blank line to fix checkpatch check: Increase readability and consistency Signed-off-by:
-
Kees Cook authored
FORTIFY_SOURCE has been ignoring 0-sized destinations while the kernel code base has been converted to flexible arrays. In order to enforce the 0-sized destinations (e.g. with __counted_by), the remaining 0-sized destinations need to be handled. Instead of converting an empty struct into using a flexible array, just directly use a pointer without any additional indirection. Remove struct gb_bootrom_get_firmware_response and struct gb_fw_download_fetch_firmware_response. Signed-off-by:
Kees Cook <keescook@chromium.org> Reviewed-by:
Alex Elder <elder@linaro.org> Link: https://lore.kernel.org/r/20240304211940.it.083-kees@kernel.org Signed-off-by:
-
Dan Carpenter authored
The get_channel_from_mode() function is supposed to return the channel which matches the mode. But it has a bug where if it doesn't find a matching channel then it returns the last channel. It should return NULL instead. Also remove an unnecessary NULL check on "channel". Fixes: 2870b52b ("greybus: lights: add lights implementation") Signed-off-by:
Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by:
Rui Miguel Silva <rmfrfs@gmail.com> Reviewed-by:
-
Colin Ian King authored
The variable mask is being assigned and bit-set but it is never being used apart from this. The variable is redundant and can be removed. Cleans up clang scan build warning: drivers/staging/greybus/audio_topology.c:764:15: warning: variable 'mask' set but not used [-Wunused-but-set-variable] Signed-off-by:
Vaibhav Agarwal <vaibhav.sr@gmail.com> Link: https://lore.kernel.org/r/20240229120541.219429-1-colin.i.king@gmail.com Signed-off-by:
-
Erick Archer authored
When a struct containing a flexible array is included in another struct, and there is a member after the struct-with-flex-array, there is a possibility of memory overlap. These cases must be audited [1]. See: struct inner { ... int flex[]; }; struct outer { ... struct inner header; int overlap; ... }; This is the scenario for the "struct audio_apbridgea_hdr" structure that is included in the following "struct audio_apbridgea_*_request" structures: struct audio_apbridgea_set_config_request struct audio_apbridgea_register_cport_request struct audio_apbridgea_unregister_cport_request struct audio_apbridgea_set_tx_data_size_request struct audio_apbridgea_prepare_tx_request struct audio_apbridgea_start_tx_request struct audio_apbridgea_stop_tx_request struct audio_apbridgea_shutdown_tx_request struct audio_apbridgea_set_rx_data_size_request struct audio_apbridgea_prepare_rx_request struct audio_apbridgea_start_rx_request struct audio_apbridgea_stop_rx_request struct audio_apbridgea_shutdown_rx_request The pattern is like the one shown below: struct audio_apbridgea_hdr { ... __u8 data[]; } __packed; struct audio_apbridgea_*_request { struct audio_apbridgea_hdr hdr; ... } __packed; In this case, the trailing flexible array can be removed because it is never used. Link: https://github.com/KSPP/linux/issues/202 [1] Signed-off-by:Erick Archer <erick.archer@gmx.com> Reviewed-by:
Mark Greer <mgreer@animalcreek.com> Link: https://lore.kernel.org/r/20240217154758.7965-1-erick.archer@gmx.com Signed-off-by:
-
- Feb 19, 2024
-
-
Marc Dietrich authored
replace old/implemented items with new todo list Signed-off-by:
Marc Dietrich <marvin24@gmx.de> Link: https://lore.kernel.org/r/20240218212557.22836-2-marvin24@gmx.de Signed-off-by:
-
Marc Dietrich authored
Update the comment before the udelay on how to replace it. Signed-off-by:
-
- Feb 18, 2024
-
-
Ricardo B. Marliere authored
Since commit aed65af1 ("drivers: make device_type const"), the driver core can properly handle constant struct device_type. Move the wwan_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Signed-off-by:
-
Ricardo B. Marliere authored
Now that the driver core can properly handle constant struct bus_type, move the vme_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Suggested-by:
-
Ricardo B. Marliere authored
Now that the driver core can properly handle constant struct bus_type, move the vchiq_bus_type variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Suggested-by:
-
Ricardo B. Marliere authored
Now that the driver core can properly handle constant struct bus_type, move the anybus_bus variable to be a constant structure as well, placing it into read-only memory which can not be modified at runtime. Suggested-by:
-
Christophe JAILLET authored
sysfs_read() is anly called from _show() functions declared by DEVICE_ATTR_RW(). Using sysfs_emit() is the preferred style and here, it saves a useless copy and a temporary buffer in the stack. Signed-off-by:
Christophe JAILLET <christophe.jaillet@wanadoo.fr> Link: https://lore.kernel.org/r/588327734f374b5f5cb5c4d5725d884fdc83663e.1707654406.git.christophe.jaillet@wanadoo.fr Signed-off-by:
-
Michael Straube authored
Initialize two variables at declaration instead of first declare and then initialize them. This saves a line of code and clears a checkpatch warning. WARNING: Missing a blank line after declarations Signed-off-by:
-
Michael Straube authored
Remove return from the void function rtl92e_set_channel. Found by checkpatch. WARNING: void function return statements are not generally useful Signed-off-by:
-
Michael Straube authored
Remove braces from single statement blocks to clear some checkpatch warnings. WARNING: braces {} are not necessary for single statement blocks Signed-off-by: -
Tree Davies authored
Rename variable bForcedBgMode to forced_bg_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by:
Tree Davies <tdavies@darkphysics.net> Link: https://lore.kernel.org/r/20240126223106.986093-19-tdavies@darkphysics.net Signed-off-by:
-
Tree Davies authored
Rename variable NumRecvBcnInPeriod to num_recv_bcn_in_period to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
Tree Davies authored
Rename variable LpsIdleCount to lps_idle_count to fix checkpatch warning Avoid CamelCase. Signed-off-by:
-
