- May 23, 2014
-
-
Chase Southwood authored
The addi-data common code always allocates 7 subdevices. This driver cannot or will not use the ones we are currently allocating for analog input and output or EEPROM, so just don't allocate these subdevices at all. Signed-off-by:
Chase Southwood <chase.southwood@gmail.com> Reviewed-by:
Ian Abbott <abbotti@mev.co.uk> Reviewed-by:
H Hartley Sweeten <hsweeten@visionengravers.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Chase Southwood authored
This board always has 32 digital outputs. Remove the test when initializing the subdevice. Also, since this board is the only one supported by this driver, remove the boardinfo about the digital outputs and just use the data directly in the subdevice init. Signed-off-by:
-
Michele CURTI authored
Removed a few spaces to fix style errors Signed-off-by:
Michele Curti <michele.curti@gmail.com> Signed-off-by:
-
Martin Kepplinger authored
For obvious error messages, use dev_err() in order to provide userspace with more useful information and use the common kernel coding style. Signed-off-by:
Martin Kepplinger <martink@posteo.de> Acked-by:
Pavel Machek <pavel@ucw.cz> Signed-off-by:
-
Peter Senna Tschudin authored
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // </smpl> Signed-off-by:
Peter Senna Tschudin <peter.senna@gmail.com> Signed-off-by:
-
James A Shackleford authored
Signed-off-by:
James A Shackleford <shack@linux.com> Signed-off-by:
-
Rupesh Gujare authored
I will be not able to work on ozwpan driver anymore. Remove my name & add Tateno as maintainer. Signed-off-by:
Rupesh Gujare <rupesh.gujare@atmel.com> Acked-by:
Shigekatsu Tateno <shigekatsu.tateno@atmel.com> Signed-off-by:
-
Anil Belur authored
staging: ozwpan: ozproto.c fix for "WARNING: Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)" Fixed the warning message by replacing memcpy() with ether_addr_copy() Signed-off-by:
Anil Belur <askb23@gmail.com> Signed-off-by:
-
Daeseok Youn authored
The "devs" is a pointer to g_net_dev in ozmain.c. g_net_dev has a default value as empty string. So "devs" cannot be NULL, removes NULL check for "devs". Signed-off-by:
Daeseok Youn <daeseok.youn@gmail.com> Signed-off-by:
-
Manuel Schölling authored
To be future-proof and for better readability the time comparisons are modified to use time_before() instead of plain, error-prone math. Signed-off-by:
Manuel Schölling <manuel.schoelling@gmx.de> Signed-off-by:
-
Rickard Strandqvist authored
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by:
Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se> Signed-off-by:
-
Rickard Strandqvist authored
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by:
-
Andreas Platschek authored
This fixes the following sparse error: drivers/staging/lustre/lustre/obdclass/llog_ioctl.c:388:39: error: incompatible types for operation (>) drivers/staging/lustre/lustre/obdclass/llog_ioctl.c:388:39: left side has type char *ioc_inlbuf2 drivers/staging/lustre/lustre/obdclass/llog_ioctl.c:388:39: right side has type int Signed-off-by:
Andreas Platschek <platschek@ict.tuwien.ac.at> Signed-off-by:
-
Masaru Nomura authored
Remove unnecessary brackets from return statements in socklnd.c, socklnd.h, socklnd_cb.c and socklnd_lib-linux.c to meet kernel coding style. Signed-off-by:
Masaru Nomura <massa.nomura@gmail.com> Signed-off-by:
-
Masaru Nomura authored
Remove unnecessary line continuation '\' in socklnd.c to meet kernel coding style. Signed-off-by:
-
Masaru Nomura authored
Fixed indenting of if statement in socklnd.c to meet kernel coding style. Signed-off-by:
-
Masaru Nomura authored
Added a required space before open brace and parenthsis in socklnd.c to meet kernel coding style. Signed-off-by:
-
Masaru Nomura authored
Remove unnecessary brackets from return statements in socklnd.c to meet kernel coding style. Signed-off-by:
-
Zi Shen Lim authored
This patch fixes the following sparse warnings: drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:44:1: warning: symbol 'kiblnd_tx_done' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:102:10: warning: symbol 'kiblnd_get_idle_tx' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:131:1: warning: symbol 'kiblnd_drop_rx' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:212:10: warning: symbol 'kiblnd_find_waiting_tx_locked' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:238:1: warning: symbol 'kiblnd_handle_completion' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:277:1: warning: symbol 'kiblnd_send_completion' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:296:1: warning: symbol 'kiblnd_handle_rx' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:457:1: warning: symbol 'kiblnd_rx_complete' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:527:13: warning: symbol 'kiblnd_kvaddr_to_page' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:699:1: warning: symbol 'kiblnd_setup_rd_iov' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:752:1: warning: symbol 'kiblnd_setup_rd_kiov' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:792:1: warning: symbol 'kiblnd_post_tx_locked' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:996:1: warning: symbol 'kiblnd_tx_complete' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1270:1: warning: symbol 'kiblnd_connect_peer' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1627:1: warning: symbol 'kiblnd_reply' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1814:1: warning: symbol 'kiblnd_thread_fini' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1828:1: warning: symbol 'kiblnd_peer_notify' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1934:1: warning: symbol 'kiblnd_handle_early_rxs' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1957:1: warning: symbol 'kiblnd_abort_txs' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:1993:1: warning: symbol 'kiblnd_finalise_conn' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:2167:1: warning: symbol 'kiblnd_reject' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:2178:1: warning: symbol 'kiblnd_passive_connect' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:2452:1: warning: symbol 'kiblnd_reconnect' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:2516:1: warning: symbol 'kiblnd_rejected' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:2655:1: warning: symbol 'kiblnd_check_connreply' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:2754:1: warning: symbol 'kiblnd_active_connect' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:3025:1: warning: symbol 'kiblnd_check_conns' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:3108:1: warning: symbol 'kiblnd_disconnect_conn' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:3247:1: warning: symbol 'kiblnd_complete' was not declared. Should it be static? drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c:904:20: warning: context imbalance in 'kiblnd_post_tx_locked' - unexpected unlock Signed-off-by:
Zi Shen Lim <zlim.lnx@gmail.com> Signed-off-by:
-
Brilliantov Kirill Vladimirovich authored
Signed-off-by:
Brilliantov Kirill Vladimirovich <brilliantov@inbox.ru> Signed-off-by:
-
Toby Smith authored
Fix the following warning in lib-eq.c warning: symbol 'lnet_eq_dequeue_event' was not declared. Should it be static? Signed-off-by:
Toby Smith <toby@tismith.id.au> Signed-off-by:
-
Toby Smith authored
Fix the following warning in lib-eq.c warning: context imbalance in 'lnet_eq_wait_locked' - unexpected unlock Signed-off-by:
-
Peng Tao authored
I am leaving emc for a new company where I cannot have much time working on Lustre. So remove myself from the contact list. I will still be around and continue to contribute as a hobbyist though. Cc: Andreas Dilger <andreas.dilger@intel.com> Cc: Oleg Drokin <oleg.drokin@intel.com> Signed-off-by:
Peng Tao <bergwolf@gmail.com> Signed-off-by:
-
Greg DeAngelis authored
Signed-off-by:
Greg DeAngelis <gdeangel@gmail.com> Signed-off-by:
-
Matthias Beyer authored
Signed-off-by:
Matthias Beyer <mail@beyermatthias.de> Signed-off-by:
-
Matthias Beyer authored
This patch outsources the code from the IsFlash2x() check in bcm_char_ioctl_nvm_rw() function to shorten it. Signed-off-by:
-
Matthias Beyer authored
This patch outsourced the true-branch for the IOCTL_BCM_NVM_READ command handling to shorten the bcm_char_ioctl_nvm_rw() function. Signed-off-by:
-
Matthias Beyer authored
Signed-off-by:
-
Daeseok Youn authored
Signed-off-by:
-
Christian Engelmayer authored
Fix the error path when a cookie mismatch is detected. In that case the function jumps to the exit label without setting the uninitialized, local variable 'return_error'. Detected by Coverity - CID 201453. Signed-off-by:
Christian Engelmayer <cengelma@gmx.at> Acked-by:
Arve <arve@android.com> Signed-off-by:
-
Jerry Snitselaar authored
Clean up sparse warnings for cred struct dereference. Signed-off-by:
Jerry Snitselaar <dev@snitselaar.org> Signed-off-by:
-
Greg Kroah-Hartman authored
Roger writes: Since all patches have been applied and the device is now supported by the new driver, would you remove the former staging one at drivers/staging/rts5139? Cc: Roger Tseng <rogerable@realtek.com> Signed-off-by: -
Fabio Estevam authored
WARNING: Missing a blank line after declarations #160: FILE: drivers/staging/imx-drm/imx-hdmi.c:160: + u8 val = hdmi_readb(hdmi, reg) & ~mask; + val |= data & mask; WARNING: Missing a blank line after declarations #1609: FILE: drivers/staging/imx-drm/imx-hdmi.c:1609: + const struct platform_device_id *device_id = of_id->data; + hdmi->dev_type = device_id->driver_data; total: 0 errors, 2 warnings, 1767 lines checked drivers/staging/imx-drm/imx-hdmi.c has style problems, please review. If any of these errors are false positives, please report them to the maintainer, see CHECKPATCH in MAINTAINERS. Signed-off-by:
Fabio Estevam <fabio.estevam@freescale.com> Signed-off-by:
-
Daniele Forsi authored
It was added by commit e0349d5b (staging: et131x: Remove unused rcv_pend_lock spinlock) Signed-off-by:
Daniele Forsi <dforsi@gmail.com> Acked-by:
Mark Einon <mark.einon@gmail.com> Signed-off-by:
-
Maarten de Jonge authored
Signed-off-by:
Maarten de Jonge <mdejonge1990@gmail.com> Acked-by:
-
Peter Senna Tschudin authored
This patch remove variables that are initialized with a constant, are never updated, and are only used as parameter of return. Return the constant instead of using a variable. Verified by compilation only. The coccinelle script that find and fixes this issue is: // <smpl> @@ type T; constant C; identifier ret; @@ - T ret = C; ... when != ret - return ret; + return C; // </smpl> Signed-off-by:
-
Christian Engelmayer authored
Pointer 'pbpctl_dev_c' in function bypass_init_module() is unused. Thus remove it. With the last variable declaration gone, there is no more need for an own block. Remove it and adapt the indenting accordingly. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
-
Christian Engelmayer authored
Remove a needless pointer initialisation and call to get_status_port_fn() in functions remove_bypass_tpl_auto() and set_tpl_fn(). Variable 'pbpctl_dev_b' is set correctly later in the function before first use. Signed-off-by:
-
Fernando Apesteguia authored
Add blank line after declarations and delete extra blank line at the beginning of the function Signed-off-by:
Fernando Apesteguia <fernando.apesteguia@gmail.com> Signed-off-by:
-
Daeseok Youn authored
cleanup checkpatch.pl error: ERROR: do not initialise statics to 0 or NULL Signed-off-by:
-
