1. Jun 23, 2022
  2. Jun 17, 2022
    • Marc Zyngier's avatar
      KVM: arm64: Add Oliver as a reviewer · cbc6d448
      Marc Zyngier authored
      
      
      Oliver Upton has agreed to help with reviewing the KVM/arm64
      patches, and has been doing so for a while now, so adding him
      as to the reviewer list.
      
      Note that Oliver is using a different email address for this
      purpose, rather than the one his been using for his other
      contributions.
      
      Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
      Acked-by: default avatarOliver Upton <oupton@google.com>
      Link: https://lore.kernel.org/r/20220616085318.1303657-1-maz@kernel.org
      cbc6d448
    • Quentin Perret's avatar
      KVM: arm64: Prevent kmemleak from accessing pKVM memory · 56961c63
      Quentin Perret authored
      Commit a7259df7 ("memblock: make memblock_find_in_range method
      private") changed the API using which memory is reserved for the pKVM
      hypervisor. However, memblock_phys_alloc() differs from the original API in
      terms of kmemleak semantics -- the old one didn't report the reserved
      regions to kmemleak while the new one does. Unfortunately, when protected
      KVM is enabled, all kernel accesses to pKVM-private memory result in a
      fatal exception, which can now happen because of kmemleak scans:
      
      $ echo scan > /sys/kernel/debug/kmemleak
      [   34.991354] kvm [304]: nVHE hyp BUG at: [<ffff800008fa3750>] __kvm_nvhe_handle_host_mem_abort+0x270/0x290!
      [   34.991580] kvm [304]: Hyp Offset: 0xfffe8be807e00000
      [   34.991813] Kernel panic - not syncing: HYP panic:
      [   34.991813] PS:600003c9 PC:0000f418011a3750 ESR:00000000f2000800
      [   34.991813] FAR:ffff000439200000 HPFAR:0000000004792000 PAR:0000000000000000
      [   34.991813] VCPU:0000000000000000
      [   34.993660] CPU: 0 PID: 304 Comm: bash Not tainted 5.19.0-rc2 #102
      [   34.994059] Hardware name: linux,dummy-virt (DT)
      [   34.994452] Call trace:
      [   34.994641]  dump_backtrace.part.0+0xcc/0xe0
      [   34.994932]  show_stack+0x18/0x6c
      [   34.995094]  dump_stack_lvl+0x68/0x84
      [   34.995276]  dump_stack+0x18/0x34
      [   34.995484]  panic+0x16c/0x354
      [   34.995673]  __hyp_pgtable_total_pages+0x0/0x60
      [   34.995933]  scan_block+0x74/0x12c
      [   34.996129]  scan_gray_list+0xd8/0x19c
      [   34.996332]  kmemleak_scan+0x2c8/0x580
      [   34.996535]  kmemleak_write+0x340/0x4a0
      [   34.996744]  full_proxy_write+0x60/0xbc
      [   34.996967]  vfs_write+0xc4/0x2b0
      [   34.997136]  ksys_write+0x68/0xf4
      [   34.997311]  __arm64_sys_write+0x20/0x2c
      [   34.997532]  invoke_syscall+0x48/0x114
      [   34.997779]  el0_svc_common.constprop.0+0x44/0xec
      [   34.998029]  do_el0_svc+0x2c/0xc0
      [   34.998205]  el0_svc+0x2c/0x84
      [   34.998421]  el0t_64_sync_handler+0xf4/0x100
      [   34.998653]  el0t_64_sync+0x18c/0x190
      [   34.999252] SMP: stopping secondary CPUs
      [   35.000034] Kernel Offset: disabled
      [   35.000261] CPU features: 0x800,00007831,00001086
      [   35.000642] Memory Limit: none
      [   35.001329] ---[ end Kernel panic - not syncing: HYP panic:
      [   35.001329] PS:600003c9 PC:0000f418011a3750 ESR:00000000f2000800
      [   35.001329] FAR:ffff000439200000 HPFAR:0000000004792000 PAR:0000000000000000
      [   35.001329] VCPU:0000000000000000 ]---
      
      Fix this by explicitly excluding the hypervisor's memory pool from
      kmemleak like we already do for the hyp BSS.
      
      Cc: Mike Rapoport <rppt@kernel.org>
      Fixes: a7259df7
      
       ("memblock: make memblock_find_in_range method private")
      Signed-off-by: default avatarQuentin Perret <qperret@google.com>
      Acked-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
      Signed-off-by: default avatarMarc Zyngier <maz@kernel.org>
      Link: https://lore.kernel.org/r/20220616161135.3997786-1-qperret@google.com
      56961c63
  3. Jun 15, 2022
    • Dmitry Klochkov's avatar
      tools/kvm_stat: fix display of error when multiple processes are found · 933b5f9f
      Dmitry Klochkov authored
      Instead of printing an error message, kvm_stat script fails when we
      restrict statistics to a guest by its name and there are multiple guests
      with such name:
      
        # kvm_stat -g my_vm
        Traceback (most recent call last):
          File "/usr/bin/kvm_stat", line 1819, in <module>
            main()
          File "/usr/bin/kvm_stat", line 1779, in main
            options = get_options()
          File "/usr/bin/kvm_stat", line 1718, in get_options
            options = argparser.parse_args()
          File "/usr/lib64/python3.10/argparse.py", line 1825, in parse_args
            args, argv = self.parse_known_args(args, namespace)
          File "/usr/lib64/python3.10/argparse.py", line 1858, in parse_known_args
            namespace, args = self._parse_known_args(args, namespace)
          File "/usr/lib64/python3.10/argparse.py", line 2067, in _parse_known_args
            start_index = consume_optional(start_index)
          File "/usr/lib64/python3.10/argparse.py", line 2007, in consume_optional
            take_action...
      933b5f9f
  4. Jun 14, 2022
    • Linus Torvalds's avatar
      Merge tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm · 24625f7d
      Linus Torvalds authored
      Pull kvm fixes from Paolo Bonzini:
       "While last week's pull request contained miscellaneous fixes for x86,
        this one covers other architectures, selftests changes, and a bigger
        series for APIC virtualization bugs that were discovered during 5.20
        development. The idea is to base 5.20 development for KVM on top of
        this tag.
      
        ARM64:
      
         - Properly reset the SVE/SME flags on vcpu load
      
         - Fix a vgic-v2 regression regarding accessing the pending state of a
           HW interrupt from userspace (and make the code common with vgic-v3)
      
         - Fix access to the idreg range for protected guests
      
         - Ignore 'kvm-arm.mode=protected' when using VHE
      
         - Return an error from kvm_arch_init_vm() on allocation failure
      
         - A bunch of small cleanups (comments, annotations, indentation)
      
        RISC-V:
      
         - Typo fix in arch/riscv/kvm/vmid.c
      
         - Remove broken reference pattern from MAINTAINERS entry
      
        x86-64:
      
         - Fix error in page tables with MKTME enabled
      
         - Dirty page tracking performance test extended to running a nested
           guest
      
         - Disable APICv/AVIC in cases that it cannot implement correctly"
      
      [ This merge also fixes a misplaced end parenthesis bug introduced in
        commit 3743c2f0 ("KVM: x86: inhibit APICv/AVIC on changes to APIC
        ID or APIC base") pointed out by Sean Christopherson ]
      
      Link: https://lore.kernel.org/all/20220610191813.371682-1-seanjc@google.com/
      
      * tag 'for-linus' of git://git.kernel.org/pub/scm/virt/kvm/kvm: (34 commits)
        KVM: selftests: Restrict test region to 48-bit physical addresses when using nested
        KVM: selftests: Add option to run dirty_log_perf_test vCPUs in L2
        KVM: selftests: Clean up LIBKVM files in Makefile
        KVM: selftests: Link selftests directly with lib object files
        KVM: selftests: Drop unnecessary rule for STATIC_LIBS
        KVM: selftests: Add a helper to check EPT/VPID capabilities
        KVM: selftests: Move VMX_EPT_VPID_CAP_AD_BITS to vmx.h
        KVM: selftests: Refactor nested_map() to specify target level
        KVM: selftests: Drop stale function parameter comment for nested_map()
        KVM: selftests: Add option to create 2M and 1G EPT mappings
        KVM: selftests: Replace x86_page_size with PG_LEVEL_XX
        KVM: x86: SVM: fix nested PAUSE filtering when L0 intercepts PAUSE
        KVM: x86: SVM: drop preempt-safe wrappers for avic_vcpu_load/put
        KVM: x86: disable preemption around the call to kvm_arch_vcpu_{un|}blocking
        KVM: x86: disable preemption while updating apicv inhibition
        KVM: x86: SVM: fix avic_kick_target_vcpus_fast
        KVM: x86: SVM: remove avic's broken code that updated APIC ID
        KVM: x86: inhibit APICv/AVIC on changes to APIC ID or APIC base
        KVM: x86: document AVIC/APICv inhibit reasons
        KVM: x86/mmu: Set memory encryption "value", not "mask", in shadow PDPTRs
        ...
      24625f7d
    • Linus Torvalds's avatar
      Merge tag 'x86-bugs-2022-06-01' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip · 8e8afafb
      Linus Torvalds authored
      Pull x86 MMIO stale data fixes from Thomas Gleixner:
       "Yet another hw vulnerability with a software mitigation: Processor
        MMIO Stale Data.
      
        They are a class of MMIO-related weaknesses which can expose stale
        data by propagating it into core fill buffers. Data which can then be
        leaked using the usual speculative execution methods.
      
        Mitigations include this set along with microcode updates and are
        similar to MDS and TAA vulnerabilities: VERW now clears those buffers
        too"
      
      * tag 'x86-bugs-2022-06-01' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
        x86/speculation/mmio: Print SMT warning
        KVM: x86/speculation: Disable Fill buffer clear within guests
        x86/speculation/mmio: Reuse SRBDS mitigation for SBDS
        x86/speculation/srbds: Update SRBDS mitigation selection
        x86/speculation/mmio: Add sysfs reporting for Processor MMIO Stale Data
        x86/speculation/mmio: Enable CPU Fill buffer clearing on idle
        x86/bugs: Group MDS, TAA & Processor MMIO Stale Data mitigations
        x86/speculation/mmio: Add mitigation for Processor MMIO Stale Data
        x86/speculation: Add a common function for MD_CLEAR mitigation update
        x86/speculation/mmio: Enumerate Processor MMIO Stale Data bug
        Documentation: Add documentation for Processor MMIO Stale Data
      8e8afafb
  5. Jun 13, 2022
    • Linus Torvalds's avatar
      Linux 5.19-rc2 · b13baccc
      Linus Torvalds authored
      b13baccc
    • Linus Torvalds's avatar
      Merge tag 'platform-drivers-x86-v5.19-2' of... · 99795285
      Linus Torvalds authored
      Merge tag 'platform-drivers-x86-v5.19-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86
      
      Pull x86 platform driver fixes from Hans de Goede:
       "Highlights:
      
         - Fix hp-wmi regression on HP Omen laptops introduced in 5.18
      
         - Several hardware-id additions
      
         - A couple of other tiny fixes"
      
      * tag 'platform-drivers-x86-v5.19-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86:
        platform/x86/intel: hid: Add Surface Go to VGBS allow list
        platform/x86: hp-wmi: Use zero insize parameter only when supported
        platform/x86: hp-wmi: Resolve WMI query failures on some devices
        platform/x86: gigabyte-wmi: Add support for B450M DS3H-CF
        platform/x86: gigabyte-wmi: Add Z690M AORUS ELITE AX DDR4 support
        platform/x86: barco-p50-gpio: Add check for platform_driver_register
        platform/x86/intel: pmc: Support Intel Raptorlake P
        platform/x86/intel: Fix pmt_crashlog array reference
        platform/mellanox: Add static in struct declaration.
        platform/mellanox: Spelling s/platfom/platform/
      99795285
    • Linus Torvalds's avatar
      Merge tag 'wq-for-5.19-rc1-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq · b0cb8db3
      Linus Torvalds authored
      Pull workqueue fixes from Tejun Heo:
       "Tetsuo's patch to trigger build warnings if system-wide wq's are
        flushed along with a TP type update and trivial comment update"
      
      * tag 'wq-for-5.19-rc1-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq:
        workqueue: Switch to new kerneldoc syntax for named variable macro argument
        workqueue: Fix type of cpu in trace event
        workqueue: Wrap flush_workqueue() using a macro
      b0cb8db3
    • Linus Torvalds's avatar
      Merge tag 'kbuild-fixes-v5.19' of... · e3b8e2de
      Linus Torvalds authored
      Merge tag 'kbuild-fixes-v5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild
      
      Pull Kbuild fixes from Masahiro Yamada:
      
       - Make the *.mod build rule portable for POSIX awk
      
       - Fix regression of 'make nsdeps'
      
       - Make scripts/check-local-export working for older bash versions
      
       - Fix scripts/gdb to extract the .config data from vmlinux
      
      * tag 'kbuild-fixes-v5.19' of git://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild:
        scripts/gdb: change kernel config dumping method
        scripts/check-local-export: avoid 'wait $!' for process substitution
        scripts/nsdeps: adjust to the format change of *.mod files
        kbuild: avoid regex RS for POSIX awk
      e3b8e2de
    • Linus Torvalds's avatar
      Merge tag '5.19-rc1-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6 · 2275c6ba
      Linus Torvalds authored
      Pull cifs client fixes from Steve French:
       "Three reconnect fixes, all for stable as well.
      
        One of these three reconnect fixes does address a problem with
        multichannel reconnect, but this does not include the additional
        fix (still being tested) for dynamically detecting multichannel
        adapter changes which will improve those reconnect scenarios even
        more"
      
      * tag '5.19-rc1-smb3-client-fixes' of git://git.samba.org/sfrench/cifs-2.6:
        cifs: populate empty hostnames for extra channels
        cifs: return errors during session setup during reconnects
        cifs: fix reconnect on smb3 mount types
      2275c6ba
    • Linus Torvalds's avatar
      Merge tag 'random-5.19-rc2-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/crng/random · 3cae0d84
      Linus Torvalds authored
      Pull random number generator fixes from Jason Donenfeld:
      
       - A fix for a 5.19 regression for a case in which early device tree
         initializes the RNG, which flips a static branch.
      
         On most plaforms, jump labels aren't initialized until much later, so
         this caused splats. On a few mailing list threads, we cooked up easy
         fixes for arm64, arm32, and risc-v. But then things looked slightly
         more involved for xtensa, powerpc, arc, and mips. And at that point,
         when we're patching 7 architectures in a place before the console is
         even available, it seems like the cost/risk just wasn't worth it.
      
         So random.c works around it now by checking the already exported
         `static_key_initialized` boolean, as though somebody already ran into
         this issue in the past. I'm not super jazzed about that; it'd be
         prettier to not have to complicate downstream code. But I suppose
         it's practical.
      
       - A few small code nits and adding a missing __init annotation.
      
       - A change to the default config values to use the cpu and bootloader's
         seeds for initializing the RNG earlier.
      
         This brings them into line with what all the distros do (Fedora/RHEL,
         Debian, Ubuntu, Gentoo, Arch, NixOS, Alpine, SUSE, and Void... at
         least), and moreover will now give us test coverage in various test
         beds that might have caught the above device tree bug earlier.
      
       - A change to WireGuard CI's configuration to increase test coverage
         around the RNG.
      
       - A documentation comment fix to unrelated maintainerless CRC code that
         I was asked to take, I guess because it has to do with polynomials
         (which the RNG thankfully no longer uses).
      
      * tag 'random-5.19-rc2-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/crng/random:
        wireguard: selftests: use maximum cpu features and allow rng seeding
        random: remove rng_has_arch_random()
        random: credit cpu and bootloader seeds by default
        random: do not use jump labels before they are initialized
        random: account for arch randomness in bits
        random: mark bootloader randomness code as __init
        random: avoid checking crng_ready() twice in random_init()
        crc-itu-t: fix typo in CRC ITU-T polynomial comment
      3cae0d84
  6. Jun 12, 2022
    • Duke Lee's avatar
      platform/x86/intel: hid: Add Surface Go to VGBS allow list · d4fe9cc4
      Duke Lee authored
      The Surface Go reports Chassis Type 9 (Laptop,) so the device needs to be
      added to dmi_vgbs_allow_list to enable tablet mode when an attached Type
      Cover is folded back.
      
      BugLink: https://github.com/linux-surface/linux-surface/issues/837
      
      
      Signed-off-by: default avatarDuke Lee <krnhotwings@gmail.com>
      Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
      Link: https://lore.kernel.org/r/20220607213654.5567-1-krnhotwings@gmail.com
      
      
      Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      d4fe9cc4
    • Bedant Patnaik's avatar
      platform/x86: hp-wmi: Use zero insize parameter only when supported · 65f936f3
      Bedant Patnaik authored
      commit be9d73e6 ("platform/x86: hp-wmi: Fix 0x05 error code reported by
      several WMI calls") and commit 12b19f14 ("platform/x86: hp-wmi: Fix
      hp_wmi_read_int() reporting error (0x05)") cause ACPI BIOS Error (bug):
      Attempt to CreateField of length zero (20211217/dsopcode-133) because of
      the ACPI method HWMC, which unconditionally creates a Field of
      size (insize*8) bits:
      	CreateField (Arg1, 0x80, (Local5 * 0x08), DAIN)
      In cases where args->insize = 0, the Field size is 0, resulting in
      an error.
      
      Fix this by using zero insize only if 0x5 error code is returned
      
      Tested on Omen 15 AMD (2020) board ID: 8786.
      
      Fixes: be9d73e6
      
       ("platform/x86: hp-wmi: Fix 0x05 error code reported by several WMI calls")
      Signed-off-by: default avatarBedant Patnaik <bedant.patnaik@gmail.com>
      Tested-by: default avatarJorge Lopez <jorge.lopez2@hp.com>
      Link: https://lore.kernel.org/r/41be46743d21c78741232a47bbb5f1cdbcc3d21e.camel@gmail.com
      
      
      Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      65f936f3
    • Jorge Lopez's avatar
      platform/x86: hp-wmi: Resolve WMI query failures on some devices · dc6a6ab5
      Jorge Lopez authored
      WMI queries fail on some devices where the ACPI method HWMC
      unconditionally attempts to create Fields beyond the buffer
      if the buffer is too small, this breaks essential features
      such as power profiles:
      
               CreateByteField (Arg1, 0x10, D008)
               CreateByteField (Arg1, 0x11, D009)
               CreateByteField (Arg1, 0x12, D010)
               CreateDWordField (Arg1, 0x10, D032)
               CreateField (Arg1, 0x80, 0x0400, D128)
      
      In cases where args->data had zero length, ACPI BIOS Error
      (bug): AE_AML_BUFFER_LIMIT, Field [D008] at bit
      offset/length 128/8 exceeds size of target Buffer (128 bits)
      (20211217/dsopcode-198) was obtained.
      
      ACPI BIOS Error (bug): AE_AML_BUFFER_LIMIT, Field [D009] at bit
      offset/length 136/8 exceeds size of target Buffer (136bits)
      (20211217/dsopcode-198)
      
      The original code created a buffer size of 128 bytes regardless if
      the WMI call required a smaller buffer or not.  This particular
      behavior occurs in older BIOS and reproduced in OMEN laptops.  Newer
      BIOS handles buffer sizes properly and meets the latest specification
      requirements.  This is the reason why testing with a dynamically
      allocated buffer did not uncover any failures with the test systems at
      hand.
      
      This patch was tested on several OMEN, Elite, and Zbooks.  It was
      confirmed the patch resolves HPWMI_FAN GET/SET calls in an OMEN
      Laptop 15-ek0xxx.  No problems were reported when testing on several Elite
      and Zbooks notebooks.
      
      Fixes: 4b4967cb
      
       ("platform/x86: hp-wmi: Changing bios_args.data to be dynamically allocated")
      Signed-off-by: default avatarJorge Lopez <jorge.lopez2@hp.com>
      Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
      Link: https://lore.kernel.org/r/20220608212923.8585-2-jorge.lopez2@hp.com
      
      
      Reviewed-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      dc6a6ab5
    • Jonathan Neuschäfer's avatar
      workqueue: Switch to new kerneldoc syntax for named variable macro argument · 8bee9dd9
      Jonathan Neuschäfer authored
      The syntax without dots is available since commit 43756e34
      
      
      ("scripts/kernel-doc: Add support for named variable macro arguments").
      
      The same HTML output is produced with and without this patch.
      
      Signed-off-by: default avatarJonathan Neuschäfer <j.neuschaefer@gmx.net>
      Acked-by: default avatarTejun Heo <tj@kernel.org>
      Signed-off-by: default avatarTejun Heo <tj@kernel.org>
      8bee9dd9
    • Linus Torvalds's avatar
      Merge tag 'gpio-fixes-for-v5.19-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux · 7a68065e
      Linus Torvalds authored
      Pull gpio fixes from Bartosz Golaszewski:
       "A set of fixes. Most address the new warning we emit at build time
        when irq chips are not immutable with some additional tweaks to
        gpio-crystalcove from Andy and a small tweak to gpio-dwapd.
      
         - make irq_chip structs immutable in several Diolan and intel drivers
           to get rid of the new warning we emit when fiddling with irq chips
      
         - don't print error messages on probe deferral in gpio-dwapb"
      
      * tag 'gpio-fixes-for-v5.19-rc2' of git://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux:
        gpio: dwapb: Don't print error on -EPROBE_DEFER
        gpio: dln2: make irq_chip immutable
        gpio: sch: make irq_chip immutable
        gpio: merrifield: make irq_chip immutable
        gpio: wcove: make irq_chip immutable
        gpio: crystalcove: Join function declarations and long lines
        gpio: crystalcove: Use specific type and API for IRQ number
        gpio: crystalcove: make irq_chip immutable
      7a68065e
    • Linus Torvalds's avatar
      Merge tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi · cecb3540
      Linus Torvalds authored
      Pull SCSI fixes from James Bottomley:
       "Driver fixes and and one core patch.
      
        Nine of the driver patches are minor fixes and reworks to lpfc and the
        rest are trivial and minor fixes elsewhere"
      
      * tag 'scsi-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi:
        scsi: pmcraid: Fix missing resource cleanup in error case
        scsi: ipr: Fix missing/incorrect resource cleanup in error case
        scsi: mpt3sas: Fix out-of-bounds compiler warning
        scsi: lpfc: Update lpfc version to 14.2.0.4
        scsi: lpfc: Allow reduced polling rate for nvme_admin_async_event cmd completion
        scsi: lpfc: Add more logging of cmd and cqe information for aborted NVMe cmds
        scsi: lpfc: Fix port stuck in bypassed state after LIP in PT2PT topology
        scsi: lpfc: Resolve NULL ptr dereference after an ELS LOGO is aborted
        scsi: lpfc: Address NULL pointer dereference after starget_to_rport()
        scsi: lpfc: Resolve some cleanup issues following SLI path refactoring
        scsi: lpfc: Resolve some cleanup issues following abort path refactoring
        scsi: lpfc: Correct BDE type for XMIT_SEQ64_WQE in lpfc_ct_reject_event()
        scsi: vmw_pvscsi: Expand vcpuHint to 16 bits
        scsi: sd: Fix interpretation of VPD B9h length
      cecb3540
    • Linus Torvalds's avatar
      Merge tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost · abe71eb3
      Linus Torvalds authored
      Pull virtio fixes from Michael Tsirkin:
       "Fixes all over the place, most notably fixes for latent bugs in
        drivers that got exposed by suppressing interrupts before DRIVER_OK,
        which in turn has been done by 8b4ec69d ("virtio: harden vring
        IRQ")"
      
      * tag 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost:
        um: virt-pci: set device ready in probe()
        vdpa: make get_vq_group and set_group_asid optional
        virtio: Fix all occurences of the "the the" typo
        vduse: Fix NULL pointer dereference on sysfs access
        vringh: Fix loop descriptors check in the indirect cases
        vdpa/mlx5: clean up indenting in handle_ctrl_vlan()
        vdpa/mlx5: fix error code for deleting vlan
        virtio-mmio: fix missing put_device() when vm_cmdline_parent registration failed
        vdpa/mlx5: Fix syntax errors in comments
        virtio-rng: make device ready before making request
      abe71eb3
    • Linus Torvalds's avatar
      Merge tag 'loongarch-fixes-5.19-1' of... · 0678afa6
      Linus Torvalds authored
      Merge tag 'loongarch-fixes-5.19-1' of git://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson
      
      Pull LoongArch fixes from Huacai Chen.
       "Fix build errors and a stale comment"
      
      * tag 'loongarch-fixes-5.19-1' of git://git.kernel.org/pub/scm/linux/kernel/git/chenhuacai/linux-loongson:
        LoongArch: Remove MIPS comment about cycle counter
        LoongArch: Fix copy_thread() build errors
        LoongArch: Fix the !CONFIG_SMP build
      0678afa6
    • Linus Torvalds's avatar
      iov_iter: fix build issue due to possible type mis-match · 1c27f1fc
      Linus Torvalds authored
      Commit 6c776766
      
       ("iov_iter: Fix iter_xarray_get_pages{,_alloc}()")
      introduced a problem on some 32-bit architectures (at least arm, xtensa,
      csky,sparc and mips), that have a 'size_t' that is 'unsigned int'.
      
      The reason is that we now do
      
          min(nr * PAGE_SIZE - offset, maxsize);
      
      where 'nr' and 'offset' and both 'unsigned int', and PAGE_SIZE is
      'unsigned long'.  As a result, the normal C type rules means that the
      first argument to 'min()' ends up being 'unsigned long'.
      
      In contrast, 'maxsize' is of type 'size_t'.
      
      Now, 'size_t' and 'unsigned long' are always the same physical type in
      the kernel, so you'd think this doesn't matter, and from an actual
      arithmetic standpoint it doesn't.
      
      But on 32-bit architectures 'size_t' is commonly 'unsigned int', even if
      it could also be 'unsigned long'.  In that situation, both are unsigned
      32-bit types, but they are not the *same* type.
      
      And as a result 'min()' will complain about the distinct types (ignore
      the "pointer types" part of the error message: that's an artifact of the
      way we have made 'min()' check types for being the same):
      
        lib/iov_iter.c: In function 'iter_xarray_get_pages':
        include/linux/minmax.h:20:35: error: comparison of distinct pointer types lacks a cast [-Werror]
           20 |         (!!(sizeof((typeof(x) *)1 == (typeof(y) *)1)))
              |                                   ^~
        lib/iov_iter.c:1464:16: note: in expansion of macro 'min'
         1464 |         return min(nr * PAGE_SIZE - offset, maxsize);
              |                ^~~
      
      This was not visible on 64-bit architectures (where we always define
      'size_t' to be 'unsigned long').
      
      Force these cases to use 'min_t(size_t, x, y)' to make the type explicit
      and avoid the issue.
      
      [ Nit-picky note: technically 'size_t' doesn't have to match 'unsigned
        long' arithmetically. We've certainly historically seen environments
        with 16-bit address spaces and 32-bit 'unsigned long'.
      
        Similarly, even in 64-bit modern environments, 'size_t' could be its
        own type distinct from 'unsigned long', even if it were arithmetically
        identical.
      
        So the above type commentary is only really descriptive of the kernel
        environment, not some kind of universal truth for the kinds of wild
        and crazy situations that are allowed by the C standard ]
      
      Reported-by: default avatarSudip Mukherjee <sudipm.mukherjee@gmail.com>
      Link: https://lore.kernel.org/all/YqRyL2sIqQNDfky2@debian/
      
      
      Cc: Jeff Layton <jlayton@kernel.org>
      Cc: David Howells <dhowells@redhat.com>
      Cc: Al Viro <viro@zeniv.linux.org.uk>
      Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
      1c27f1fc
  7. Jun 11, 2022