- Apr 20, 2012
-
-
Dan Carpenter authored
If the user passes an invalid command, then we don't drop the lock before returning. The check for invalid commands doesn't need to be done under lock so I moved it forward a couple lines. Signed-off-by:
Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Julia Lawall authored
The need for wl_device_dealloc is motivated by the error-handling code for the failure of wl_adapter_insert. The need for wl_remove in the third case is motivated by the code in the definition of wl_pci_remove. Signed-off-by:
Julia Lawall <Julia.Lawall@lip6.fr> Signed-off-by:
-
Laxman Dewangan authored
Using tab inplace of multiple spaces for indenting. Signed-off-by:
Laxman Dewangan <ldewangan@nvidia.com> Acked-by:
Jonathan Cameron <jic23@kernel.org> Signed-off-by:
-
W. Trevor King authored
* No braces for single statement blocks. Signed-off-by:
W. Trevor King <wking@tremily.us> Signed-off-by:
-
W. Trevor King authored
Signed-off-by:
-
- Apr 19, 2012
-
-
Marcos Paulo de Souza authored
The output of "make versioncheck" told us that: drivers/staging/rtl8712/osdep_service.h: 32 linux/version.h not needed. drivers/staging/rtl8712/rtl871x_ioctl_linux.c: 46 linux/version.h not needed. If we take a look at these files, we will agree to remove it. Cc: Larry Finger <Larry.Finger@lwfinger.net> Cc: Florian Schilhabel <florian.c.schilhabel@googlemail.com> Cc: <devel@driverdev.osuosl.org> Signed-off-by:
Marcos Paulo de Souza <marcos.souza.org@gmail.com> ACKed-by:
Larry Finger <Larry.Finger@lwfinger.net> Signed-off-by:
-
Dan Carpenter authored
Count is used to cap "req->bssindex.data" which is used as an offset into the hw->scanresults->info.hscanresult.result[] array. The array has only HFA384x_SCANRESULT_MAX (31) elements so the 32 is off by one. Signed-off-by:
-
Marcos Paulo de Souza authored
The output of "make versioncheck" told us that: drivers/staging/media/as102/as102_fe.c: 20 linux/version.h not needed. If we take a look at the code, we can agree to remove this include. Cc: Mauro Carvalho Chehab <mchehab@infradead.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: <linux-media@vger.kernel.org> Cc: <devel@driverdev.osuosl.org> Signed-off-by:
-
Marcos Paulo de Souza authored
The output of "make versioncheck" told us that: drivers/staging/media/as102/as102_usb_drv.h: 20 linux/version.h not needed. If we take a look at the code, we can agree to remove it. Cc: Mauro Carvalho Chehab <mchehab@infradead.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: <linux-media@vger.kernel.org> Cc: <devel@driverdev.osuosl.org > Signed-off-by:
-
Marcos Paulo de Souza authored
The output of "make versioncheck" told us that: drivers/staging/media/easycap/easycap_ioctl.c: 2442: need linux/version.h If we take a look at the code, we will see the macro KERNEL_VERSION be used. So, we need this include. Cc: Mauro Carvalho Chehab <mchehab@infradead.org> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: <linux-media@vger.kernel.org> Cc: <devel@driverdev.osuosl.org > Signed-off-by:
-
Marcos Paulo de Souza authored
The output of "make versioncheck" told us that: drivers/staging/vme/devices/vme_pio2_core.c: 13 linux/version.h not needed. drivers/staging/vme/devices/vme_pio2_gpio.c: 13 linux/version.h not needed. If we take a look at these files, we will agree to remove it. Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: <devel@driverdev.osuosl.org> Signed-off-by:
-
Dan Carpenter authored
The original code had some confusion about the dimensions of the array. It should have been an array of 2 element arrays but it was declared as an array of 50 element arrays. The limitter on the outside array should have been ARRAY_SIZE(chan_freq_list) or 26 but instead 50 was used. It meant that we read past the end. It's probably harmless but it's obviously worth fixing. Signed-off-by:
-
Benedikt Bergenthal authored
Fixed a code style issue. Signed-off-by:
Benedikt Bergenthal <benedikt@kdrennert.de> Signed-off-by:
-
Larry Finger authored
It is possible to misconfigure a kernel by selecting the rtllib crypto routines without enabling the underlying support from the crypto library. Signed-off-by:
Sean MacLennan <seanm@seanm.ca> Signed-off-by:
-
Dan Carpenter authored
We don't use the rxcmdpkt[] counters at all and we can remove them. Signed-off-by:
-
Dan Carpenter authored
When we received a command we incremented a stat counter depending on the type of message. The problem is there were 8 types of commands but there were only 4 counters allocated so it corrupted memory past the end of the rxcmdpkt[] array. The fix is just to remove the counters because they aren't used. Signed-off-by:
-
Justin P. Mattock authored
Signed-off-by:
Justin P. Mattock <justinmattock@gmail.com> Signed-off-by:
-
Randy Dunlap authored
Fix printk format warnings by using 't' modifier for ptrdiff_t. drivers/staging/android/alarm.c:344:2: warning: format '%ld' expects type 'long int', but argument 2 has type 'int' drivers/staging/android/alarm.c:367:3: warning: format '%ld' expects type 'long int', but argument 2 has type 'int' Signed-off-by:
Randy Dunlap <rdunlap@xenotime.net> Cc: Brian Swetland <swetland@google.com> Signed-off-by:
-
Masanari Iida authored
Fix spelling typo in comments within android drivers. Signed-off-by:
Masanari Iida <standby24x7@gmail.com> Signed-off-by:
-
Jonathan Cameron authored
There is no longer any need for this as we have separate info_mask elements for raw and processed value reads. Signed-off-by:
Lars-Peter Clausen <lars@metafoo.de> Signed-off-by:
-
Jonathan Cameron authored
Until now all channels have had read/write attributes. This patch allows for channels where we can't actually read the value (or for output devices, write it!) v2 introduces separate elements for processed and raw thus removing some special case code from the core. Thanks to Lars-Peter for an excellent suggestion! Signed-off-by:
-
Jonathan Cameron authored
Precursor to making value read / write attribute optional. This one stands along as it merged just before the series doing all the other drivers. Signed-off-by:
-
Lars-Peter Clausen authored
Precursor to making value read / write attribute optional. No processed values in resolvers at the moment. Signed-off-by:
-
Lars-Peter Clausen authored
Precursor to making value read / write attribute optional. No processed values in resolvers at the moment. Signed-off-by:
-
Jonathan Cameron authored
Precursor to making value read / write attribute optional. Signed-off-by:
-
Jonathan Cameron authored
Precursor to making value read / write attribute optional. Signed-off-by:
-
Jonathan Cameron authored
Precursor to making value read / write attribute optional. No processed values in resolvers at the moment. Signed-off-by:
-
Jonathan Cameron authored
Precursor to making value read / write attribute optional. No processed values for magnetometers. Signed-off-by:
-
Jonathan Cameron authored
Precursor to making value read / write attribute optional. Note that minimal change route taken here. The read_raw callbacks in both drivers could do fewer checks to identify the channel than they now do. Signed-off-by:
-
Jonathan Cameron authored
Precursor to making value read / write attribute optional. No processed values in IMU. Signed-off-by:
-
Jonathan Cameron authored
Precursor to making value read / write attribute optional. No processed values in gyroscopes. Signed-off-by:
-
Jonathan Cameron authored
Precursor to making value read / write attribute optional. No processed versions in DACs. Signed-off-by:
-
Jonathan Cameron authored
Precursor to making value read / write attribute optional. No processed values for adc's. Updated to include the spear adc driver (hence introducing a dependency on the patch that adds that driver). Signed-off-by:
-
Jonathan Cameron authored
Precursor to making value read / write attribute optional. No processed values in accelerometers. Signed-off-by:
-
Jonathan Cameron authored
This will allow us to have drivers where the channel value may not be read or written but other information is available. Also adds the ability to have both processed and raw access to a given channel, though in most cases this doesn't make sense. Ultimately will lead to simpler code by allowing us to drop the special case handling for the value reading cases. Signed-off-by:
-
W. Trevor King authored
Update comments in comedi.h accordingly. Signed-off-by:
W. Trevor King <wking@drexel.edu> Acked-by:
Ian Abbott <abbotti@mev.co.uk> Signed-off-by:
-
Laxman Dewangan authored
The mask value in the read_raw/write_raw is absolute value, not the bit position value. Fixing this in the implemented function to check value, not with the bit position value. Signed-off-by:
Jonathan Cameron <jic23@cam.ac.uk> Signed-off-by:
-
Jesper Juhl authored
release_firmware() deals gracefullt with NULL pointers - it's redundant to check for them before calling the function. Also remove a few pointless comments - it's rather obvious from the code that kfree() free's a buffer and that release_firmware() releases firmware - comments just stating that add no value. Signed-off-by:
Jesper Juhl <jj@chaosbits.net> Signed-off-by:
-
Jesper Juhl authored
Checking for a NULL pointer before calling release_firmware() is redundant since the function does that check itself. Signed-off-by:
-
- Apr 14, 2012
-
-
Ian Abbott authored
Allow the default values for the module parameters for the default initial buffer size and default maximum buffer size to be specified in the kernel configuration. I'm not sure what the defaults for the defaults for the defaults should be, but 64 KiB seems to small, so I used values suggested by Bernd Porr, which are 2048 KiB for the default initial buffer size and 20480 for the default maximum buffer size. Signed-off-by:
-
