- Mar 12, 2016
-
-
Rehas Sachdeva authored
The preferred way to break up long math lines is to break after an arthimetic or boolean operator. This patch fixes the checkpatch.pl warning: Logical continuations should be on the previous line. Signed-off-by:
Rehas Sachdeva <aquannie@gmail.com> Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-
Rehas Sachdeva authored
This patch fixes the block comment style. 1. The checkpatch.pl warning: Block comments use a trailing */ on a separate line. 2. '====' separator is unnecessary and should not be used. Signed-off-by:
-
Rehas Sachdeva authored
This patch fixes the checkpatch.pl warnings regarding multiple blank lines as single blank line is the preferred coding style. Signed-off-by:
-
Rehas Sachdeva authored
One space on either side of binary and ternary operators is preferred. This patch fixes the related checkpatch.pl warnings. Signed-off-by:
-
Eva Rachel Retuya authored
Eliminate unneeded parentheses around the right hand side of an assignment. Coccinelle semantic patch used: @@ expression e1, e2; identifier v; @@ ( v = (e1 == e2) | v = (e1 != e2) | v = (e1 <= e2) | v = (e1 >= e2) | v = - ( e1 - ) ) Signed-off-by:
Eva Rachel Retuya <eraretuya@gmail.com> Signed-off-by:
-
Amitoj Kaur Chawla authored
Devm_ functions allocate memory that is released when a driver detaches. Replace kzalloc with devm_kzalloc and remove corresponding kfrees from probe and remove functions of a platform device. Also, unnecessary labels have been removed. Signed-off-by:
Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:
-
Janani Ravichandran authored
Void pointers need not be cast to other pointer types. Semantic patch used: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x) [...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
Janani Ravichandran <janani.rvchndrn@gmail.com> Signed-off-by:
-
Janani Ravichandran authored
Void pointers need not be cast to other pointer types. Semantic patch used: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x) [...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Janani Ravichandran authored
Remove unneeded cast on the void pointer par->txbuf.buf . Semantic patch used: @r@ expression x; void* e; type T; identifier f; @@ ( *((T *)e) | ((T *)x) [...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Amitoj Kaur Chawla authored
Replace devm_kzalloc with devm_kcalloc to ensure there are no integer overflows from the multiplication of a number * sizeof The following Coccinelle semantic patch was used to make this change: //<smpl> @@ expression dev,E1,E2,E3,E4; @@ - devm_kzalloc(dev,E1*E2*sizeof(E3),E4) + devm_kcalloc(dev,E1*E2,sizeof(E3),E4) //</smpl> Signed-off-by:
-
Amitoj Kaur Chawla authored
Unnecessary spi_set_drvdata() has been removed since the driver core clears the driver data to NULL after device release or on probe failure. There is no need to manually clear the device driver data to NULL. The Coccinelle semantic patch used to make this change is as follows: @@ struct spi_device *spi; @@ - spi_set_drvdata(spi, NULL); // </smpl> Due to this removal, variable `spi` was unused so dropped `spi` Signed-off-by:
-
Alison Schofield authored
Use macro min() to get the minimum of two values for brevity and readability. Found using Coccinelle: @@ type T; T x; T y; @@ ( - x < y ? x : y + min(x,y) | - x > y ? x : y + max(x,y) ) Signed-off-by:
Alison Schofield <amsfield22@gmail.com> Signed-off-by:
-
Bhaktipriya Shridhar authored
Use kmalloc_array instead of kmalloc for arrays to prevent integer overflows. This was done using Coccinelle: @@ expression e1, e2; constant C; type t; @@ ( - kmalloc( + kmalloc_array( e2 - * + , sizeof(e1), C) | - kmalloc( + kmalloc_array( e1 - * + , sizeof(t), C) | - kmalloc( + kmalloc_array( - sizeof(e1) - * e2 + , + sizeof(e1) , C) | - kmalloc( + kmalloc_array( - sizeof(t) - * e1 + , + sizeof(t) , C) ) Signed-off-by:
Bhaktipriya Shridhar <bhaktipriya96@gmail.com> Signed-off-by:
-
Ben Marsh authored
Patch to nvec_ps2.c to remove an unnecessary cast on a void pointer. Signed-off-by:
Ben Marsh <bmarsh94@gmail.com> Signed-off-by:
-
Janani Ravichandran authored
Void pointers need not be cast to other pointer types. Semantic patch used: @r@ expression x; void *e; type T; identifier f; @@ ( *((T *)e) | ((T *)x) [...] | ((T *)x)->f | - (T *) e ) Signed-off-by:
-
Laura Garcia Liebana authored
Prevent a kernel panic by avoiding the use of the BUG_ON macro. Checkpatch detected this issue. The BUG_ON macro is not needed as such cases shouldn't happen and they were introduced for debugging purposes. Signed-off-by:
Laura Garcia Liebana <nevola@gmail.com> Acked-by:
Marc Dietrich <marvin24@gmx.de> Signed-off-by:
-
Laura Garcia Liebana authored
Blank lines aren't necessary before a close brace '}'. Checkpatch detected this issue. Signed-off-by:
-
Bhumika Goyal authored
Remove function rtw_freq2ch as it is never used anywhere in the kernel. Also, remove the function prototype. Signed-off-by:
Bhumika Goyal <bhumirks@gmail.com> Signed-off-by:
-
Claudiu Beznea authored
This patch removes unnecessary "if (true)" check in update_BCNTIM() from core/rtw_ap.c file. After this remove the code alignment was necessary. Signed-off-by:
Claudiu Beznea <claudiu.beznea@gmail.com> Signed-off-by:
-
Bhaktipriya Shridhar authored
This patch fixes the checkpatch warning that else is not generally useful after a break or return. This was done using Coccinelle: @@ expression e2; statement s1; @@ if(e2) { ... return ...; } -else s1 Signed-off-by: -
Sandhya Bankar authored
Use !x instead of x==NULL. Signed-off-by:
Sandhya Bankar <bankarsandhya512@gmail.com> Signed-off-by:
-
Sandhya Bankar authored
Do not print message if kzalloc() failed. kzalloc() has its own messages. So no need to add extra one. Signed-off-by:
-
Sandhya Bankar authored
Do not print message if kzalloc() failed. kzalloc() has its own messages. So no need to add extra one. Signed-off-by:
-
Kyle Kuffermann authored
This fixes the checkpatch.pl issue: CHECK: spaces preferred around that '+' Signed-off-by:
Kyle Kuffermann <kyle.kuffermann@gmail.com> Signed-off-by:
-
Ivan Safonov authored
staging: rtl8188eu: remove PWR_BASEADDR_* macro definitions and "base" member of wl_pwr_cfg structure These macros and "base" member of wl_pwr_cfg structure are used only to produce debug output. Signed-off-by:
Ivan Safonov <insafonov@gmail.com> Signed-off-by:
-
Ivan Safonov authored
staging: rtl8188eu: remove PWR_INTF_*_MSK macro definitions and interface_mask of wl_pwr_cfg structure This driver is intended only for usb devices. Signed-off-by:
-
Ivan Safonov authored
fab_msk used for marking commands for devices of a certain manufacturer. However, always used only PWR_FAB_ALL_MSK value of fab_msk. Most likely, such mark is useless. Signed-off-by:
-
Ivan Safonov authored
Value of this variable is hardcoded and used only to produce debug output. Probably, FabVersion is useless. Signed-off-by:
-
Ivan Safonov authored
chip_type variable is unnecessary here, because this driver is only for one chip and it is not used after initialization. Signed-off-by:
-
Ivan Safonov authored
It is a checkpatch cleanups: CHECK: Comparasion to NULL could be written ... Signed-off-by:
-
Ivan Safonov authored
Debug output in rtw_drw_init is excess Signed-off-by:
-
Ivan Safonov authored
FIELD_OFFSET, READEF1BYTE, READEF2BYTE, READEF4BYTE WRITEEF1BYTE, WRITEEF2BYTE, WRITEEF4BYTE are removed. Signed-off-by:
-
Ivan Safonov authored
This file is not used for the driver compiling Signed-off-by:
-
Ivan Safonov authored
FIELD_OFFSET and offsetof macro are equal Signed-off-by:
-
Bhaktipriya Shridhar authored
vfree frees the virtually continuous memory area starting at addr. If addr is NULL, no operation is performed. So NULL test is not needed before vfree. This was done using Coccinelle: @@ expression x; @@ -if (x != NULL) vfree(x); @@ expression x; @@ -if (x != NULL) { vfree(x); x = NULL; -} Signed-off-by: -
Bhaktipriya Shridhar authored
vfree frees the virtually continuous memory area starting at addr. If addr is NULL, no operation is performed. So NULL test is not needed before vfree. This was done using Coccinelle: @@ expression x; @@ -if (x != NULL) vfree(x); @@ expression x; @@ -if (x != NULL) { vfree(x); x = NULL; -} Signed-off-by: -
Bhaktipriya Shridhar authored
This patch removes unnecessary return variables and compresses the return logic. The coccinelle script that finds and fixes this issue is: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(...); - return i; ) Signed-off-by:
-
Bhaktipriya Shridhar authored
This patch removes unnecessary return variables and compresses the return logic. The coccinelle script that finds and fixes this issue is: @@ type T; identifier i,f; constant C; @@ - T i; ...when != i when strict ( return -C; | - i = + return f(...); - return i; ) Signed-off-by:
-
Bhaktipriya Shridhar authored
Casting a pointer to a pointer of the same type is unnecessary, so remove these unnecessary casts. This was done with Coccinelle: @@ type T; T *ptr; @@ - (T *)ptr + ptr Signed-off-by:
-
Bhaktipriya Shridhar authored
Removed initialisation of a varible if it is immediately reassigned. Changes were made using Coccinelle. @bad@ identifier i; position p; @@ i =@p <+...i...+>; @@ type T; constant C; expression e; identifier i; position p != bad.p; @@ T i - = C ; i =@p e; Signed-off-by:
-
