- Jun 29, 2017
-
-
Biju Das authored
Renesas RZ/G1M (R8A7743) SoC GPIO blocks are identical to the R-Car Gen2 family. Add support for its GPIO controllers. Signed-off-by:
Biju Das <biju.das@bp.renesas.com> Reviewed-by:
Chris Paterson <chris.paterson2@renesas.com> Acked-by:
Geert Uytterhoeven <geert+renesas@glider.be> Acked-by:
Rob Herring <robh@kernel.org> Signed-off-by:
Linus Walleij <linus.walleij@linaro.org>
-
Kuppuswamy Sathyanarayanan authored
According to Whiskey Cove PMIC GPIO controller specification, for GPIO pins 0-12, GPIO input and output register control address range from, 0x4e44-0x4e50 for GPIO outputs control register 0x4e51-0x4e5d for GPIO input control register But, currently when calculating the GPIO register offsets in to_reg() function, all GPIO pins in the same bank uses the same GPIO control register address. This logic is incorrect. This patch fixes this issue. This patch also adds support to selectively skip register modification for virtual GPIOs. In case of Whiskey Cove PMIC, ACPI code may use up 94 virtual GPIOs. These virtual GPIOs are used by the ACPI code as means to access various non GPIO bits of PMIC. So for these virtual GPIOs, we don't need to manipulate the physical GPIO pin register. A similar patch has been merged recently by Hans for Crystal Cove PMIC GPIO driver. You can find more details about it in Commit 9a752b4c ("gpio: crystalcove: Do not write regular gpio registers for virtual GPIOs") Signed-off-by:
Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com> Reported-by:
Jukka Laitinen <jukka.laitinen@intel.com> Signed-off-by:
-
- Jun 21, 2017
-
-
Keerthy authored
Add driver for lp87565 PMIC family GPIOs. Three GPIOs are supported and can be configured in Open-drain output or Push-pull output. Signed-off-by:
Keerthy <j-keerthy@ti.com> Signed-off-by:
-
Xiaoguang Chen authored
dwapb_irq_set_type overwrites polarity register value for IRQ_TYPE_EDGE_BOTH case. If the polarity of one gpio is 0 by default, then it will set falling edge irq trigger. and the gpio may requires rising edge irq for the first time, and it will be missed. Do not overwrite polarity register for IRQ_TYPE_EDGE_BOTH case can solve this issue. Signed-off-by:
Xiaoguang Chen <xgchenshy@gmail.com> Tested-by:
Jisheng Zhang <jszhang@marvell.com> [Fix some really weird text encoding problem] Signed-off-by:
-
- Jun 20, 2017
-
-
Andy Shevchenko authored
We will help Linus to maintain GPIO ACPI support. Append a dedicated record to the MAINTAINERS data base. Signed-off-by:
Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by:
Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by:
-
Jan Kiszka authored
First, the logic for translating a register bit to the return code of exar_get_direction and exar_get_value were wrong. And second, there was a flip regarding the register bank in exar_get_direction. Signed-off-by:
Jan Kiszka <jan.kiszka@siemens.com> Reviewed-by:
Andy Shevchenko <andy.shevchenko@gmail.com> Acked-by:
-
Jan Kiszka authored
Do not allocate resources on behalf of the parent device but on our own. Otherwise, cleanup does not properly work if gpio-exar is removed but not the parent device. Signed-off-by:
-
Jan Kiszka authored
This fixes reloading of the GPIO driver for the same platform device instance as created by the exar UART driver: First of all, the driver sets drvdata to its own value during probing and does not restore the original value on exit. But this won't help anyway as the core clears drvdata after the driver left. Set the platform device parent instead. Signed-off-by:
Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by:
-
Bartosz Golaszewski authored
When allocating a zeroed array of objects use devm_kcalloc() instead of manually calculating the required size and using devm_kzalloc(). Signed-off-by:
Bartosz Golaszewski <brgl@bgdev.pl> Reviewed-by:
-
Bartosz Golaszewski authored
Just taking credit for the recent changes and new features. :) Signed-off-by:
-
Bartosz Golaszewski authored
Indicate the error number and make the message a bit more elaborate. Signed-off-by:
-
Bartosz Golaszewski authored
When the requested number of GPIO lines is 0, return -EINVAL, not -1 which is -EPERM. Signed-off-by:
-
Bartosz Golaszewski authored
We currently shift bits here and there without actually explaining what we're doing. Add some helper variables with names indicating their purpose to improve the code readability. Signed-off-by:
-
Bartosz Golaszewski authored
Currently we ignore the last odd range value, since each chip is described by two values. Be more strict and require the user to pass an even number of ranges. Signed-off-by:
-
Bartosz Golaszewski authored
Invert the logic of the irq_enabled check and only access the private data after the input is sanitized. Signed-off-by:
-
Bartosz Golaszewski authored
We're currently only checking the first character of the input to the debugfs event files, so a string like '0sdfdsf' is valid and indicates a falling edge event. Be more strict and only allow '0', '1', '0\n' & '1\n'. While we're at it: move the sanitization code before the irq_enabled check so that we indicate an error on invalid input even if nobody is waiting for events. Signed-off-by:
-
- Jun 16, 2017
-
-
Gregory CLEMENT authored
The Armada 7K and 8K SoCs use the same gpio controller as most of the other mvebu SoCs. However, the main difference is that the GPIO controller is part of a bigger system controller, and a syscon is used to control the overall system controller. Therefore, the driver needs to be adjusted to retrieve the regmap of the syscon to access registers, and account for the fact that registers are located at a certain offset within the regmap. This commit add the support of the syscon and introduce a new variant for this case. It was based on the preliminary work of Thomas Petazzoni. Tested-by:
Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Signed-off-by:
Gregory CLEMENT <gregory.clement@free-electrons.com> Signed-off-by:
-
Gregory CLEMENT authored
In some place in the driver regmap_update_bits was misused. Indeed the last argument is not the value of the bit (or group of bits) itself but the mask value inside the register. So when setting the bit N, then the value must be BIT(N) and not 1. CC: Ralph Sennhauser <ralph.sennhauser@gmail.com> Signed-off-by:
Ralph Sennhauser <ralph.sennhauser@gmail.com> Tested-by:
Chris Packham <Chris.Packham@alliedtelesis.co.nz> Signed-off-by:
-
Soren Brinkmann authored
The one quirk used in the zynq GPIO driver was called FOO which is not very descriptive. Rename the quirk to IS_ZYNQ as it indicates whether the HW is a zynq or zynqmp device to allow handling of device-specific differences of the HW. Also provide a helper function to test whether the HW is zynq or zynqmp. Signed-off-by:
Soren Brinkmann <soren.brinkmann@xilinx.com> Signed-off-by:
-
Keerthy authored
Add an entry for the gpio-davinci driver and add myself as a maintainer for the same. Signed-off-by:
-
Andy Shevchenko authored
I don't remember how linux/gpio.h made the source, now it seems unused. Remove it. Signed-off-by:
-
Geert Uytterhoeven authored
Signed-off-by:
-
- May 31, 2017
-
-
Arnd Bergmann authored
Without the regmap code, we get a link error: drivers/gpio/built-in.o: In function `xra1403_probe': (.text+0x132e0): undefined reference to `__devm_regmap_init_spi' Fixes: 5704520d ("gpio: xra1403: Add EXAR XRA1403 SPI GPIO expander driver") Signed-off-by:
Arnd Bergmann <arnd@arndb.de> Reviewed-by:
Nandor Han <nandor.han@ge.com> Signed-off-by:
-
Arnd Bergmann authored
This was left behind by a cleanup patch: drivers/gpio/gpiolib.c: In function 'gpiochip_irqchip_init_valid_mask': drivers/gpio/gpiolib.c:1474:6: error: unused variable 'i' [-Werror=unused-variable] Fixes: 923a654c ("gpiolib: Re-use bitmap_fill() instead of open coded loop") Reported-by:
kbuild test robot <fengguang.wu@intel.com> Reported-by:
Stephen Rothwell <sfr@canb.auug.org.au> Reported-by:
Colin King <colin.king@canonical.com> Signed-off-by:
-
- May 29, 2017
-
-
Wolfram Sang authored
include/linux/i2c is not for client devices. Move the header file to a more appropriate location. Signed-off-by:
Wolfram Sang <wsa@the-dreams.de> Acked-by:
Dmitry Torokhov <dmitry.torokhov@gmail.com> Signed-off-by:
-
Bartosz Golaszewski authored
This function can fail, so check the return value before dereferencing the returned pointer. Signed-off-by:
-
Bartosz Golaszewski authored
This function can fail, so check the return value before dereferencing the returned pointer. Signed-off-by:
-
Bartosz Golaszewski authored
This function can fail, so check the return value before dereferencing the returned pointer. Signed-off-by:
-
Bartosz Golaszewski authored
Even though this is a testing module, be nice and actually implement these functions. Signed-off-by:
-
Bartosz Golaszewski authored
When inserting and removing the module repeatedly (e.g. when running the libgpiod test-suite) the kernel log gets clobbered with messages reporting successful creation of dummy gpiochips. Remove this message and only emit logs when something bad happens. Signed-off-by:
-
Bartosz Golaszewski authored
All internal symbols except for the direction enum follow the same convention and use the gpio_mockup prefix. Add the prefix to the DIR_IN and DIR_OUT definitions as well for consistency across the file. Signed-off-by:
-
Bartosz Golaszewski authored
The comment in linux/gpio/driver.h says: @get_direction: returns direction for signal "offset", 0=out, 1=in We got those switched at some point. Fix the values. Signed-off-by:
-
Andy Shevchenko authored
Re-use bitmap_fill() instead of open coded loop for setting an area of bits in a bitmap. Signed-off-by:
-
Andy Shevchenko authored
There is no point in keeping an address in the file since it's subject to change. Signed-off-by:
-
Andy Shevchenko authored
Simply join string literals back for better maintenance and debugging. No functional changes intended. Signed-off-by:
-
Jagadish Krishnamoorthy authored
The PNP ACPI driver parses ACPI interrupt resource but not GpioInt resource. When the firmware passes GpioInt resource for IRQ the PNP ACPI driver ignores it and hence the interrupt for the particular driver will not work. One such example is 8042 keyboard which uses PNP driver for obtaining the interrupt resource. On Intel Braswell project GpioInt is used instead of interrupt resource and the keyboard driver fails to register interrupt. Fix the issue by parsing GpioInt resource type. Signed-off-by:
Jagadish Krishnamoorthy <jagadish.krishnamoorthy@intel.com> Signed-off-by:
-
Andy Shevchenko authored
The helper does retrieve pointer to struct acpi_resource_gpio from struct acpi_resource if it represents GpioInt() resource. It will be used by PNP code later on. Signed-off-by:
-
Andy Shevchenko authored
This allows ACPI GPIO code to modify flags based on ACPI GpioIo() / GpioInt() resources. Signed-off-by:
Jarkko Nikula <jarkko.nikula@linux.intel.com> Reviewed-by:
-
Andy Shevchenko authored
The helper function acpi_gpio_to_gpiod_flags() will be used later to configure pin properly whenever it's requested. While here, introduce a checking error code returned by gpiod_configure_flags() and bail out if it's not okay. Signed-off-by:
-
Andy Shevchenko authored
Documentation lacks of explanation how we actually use device properties for GPIO resources. Add a section to the documentation about that. Suggested-by:
-
